All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] pvshim: introduce a PV shim defconfig
@ 2018-08-22 10:36 Roger Pau Monne
  2018-08-22 11:40 ` Ian Jackson
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Roger Pau Monne @ 2018-08-22 10:36 UTC (permalink / raw)
  To: xen-devel
  Cc: Wei Liu, Andrew Cooper, Ian Jackson, Jan Beulich, Roger Pau Monne

In order to build a tailored pvshim-only binary from Xen. Switch the
PV shim build from the tools firmware into using the new defconfig.

A diff of the .config generated for the pvshim firmware build before
and after this change shows no differences.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>
---
 tools/firmware/xen-dir/Makefile       |  5 +-
 tools/firmware/xen-dir/shim.config    | 84 ---------------------------
 xen/arch/x86/configs/pvshim_defconfig | 23 ++++++++
 3 files changed, 25 insertions(+), 87 deletions(-)
 delete mode 100644 tools/firmware/xen-dir/shim.config
 create mode 100644 xen/arch/x86/configs/pvshim_defconfig

diff --git a/tools/firmware/xen-dir/Makefile b/tools/firmware/xen-dir/Makefile
index 84648c3faf..83597f0017 100644
--- a/tools/firmware/xen-dir/Makefile
+++ b/tools/firmware/xen-dir/Makefile
@@ -41,9 +41,8 @@ linkfarm.stamp: $(DEP_DIRS) $(DEP_FILES) FORCE
 $(D): linkfarm.stamp
 	$(MAKE) -C $(D)/xen distclean
 
-$(D)/xen/.config: shim.config $(D)
-	cp $< $@
-	$(MAKE) -C $(@D) olddefconfig XEN_CONFIG_EXPERT=y
+$(D)/xen/.config: $(D)
+	$(MAKE) -C $(@D) KBUILD_DEFCONFIG=pvshim_defconfig XEN_CONFIG_EXPERT=y defconfig
 
 xen-shim: $(D)/xen/.config
 	$(MAKE) -C $(<D) build XEN_CONFIG_EXPERT=y
diff --git a/tools/firmware/xen-dir/shim.config b/tools/firmware/xen-dir/shim.config
deleted file mode 100644
index 21d7075bb4..0000000000
--- a/tools/firmware/xen-dir/shim.config
+++ /dev/null
@@ -1,84 +0,0 @@
-#
-# Automatically generated file; DO NOT EDIT.
-# Xen/x86 4.11-unstable Configuration
-#
-CONFIG_X86_64=y
-CONFIG_X86=y
-CONFIG_ARCH_DEFCONFIG="arch/x86/configs/x86_64_defconfig"
-
-#
-# Architecture Features
-#
-CONFIG_NR_CPUS=32
-CONFIG_PV=y
-CONFIG_PV_LINEAR_PT=y
-CONFIG_HVM=y
-# CONFIG_SHADOW_PAGING is not set
-# CONFIG_BIGMEM is not set
-# CONFIG_HVM_FEP is not set
-# CONFIG_TBOOT is not set
-CONFIG_XEN_GUEST=y
-CONFIG_PVH_GUEST=y
-CONFIG_PV_SHIM=y
-CONFIG_PV_SHIM_EXCLUSIVE=y
-
-#
-# Common Features
-#
-CONFIG_COMPAT=y
-CONFIG_CORE_PARKING=y
-CONFIG_HAS_ALTERNATIVE=y
-CONFIG_HAS_EX_TABLE=y
-CONFIG_MEM_ACCESS=y
-CONFIG_HAS_MEM_PAGING=y
-CONFIG_HAS_MEM_SHARING=y
-CONFIG_HAS_PDX=y
-CONFIG_HAS_UBSAN=y
-CONFIG_HAS_KEXEC=y
-CONFIG_HAS_GDBSX=y
-CONFIG_HAS_IOPORTS=y
-# CONFIG_KEXEC is not set
-# CONFIG_TMEM is not set
-# CONFIG_XENOPROF is not set
-# CONFIG_XSM is not set
-
-#
-# Schedulers
-#
-CONFIG_SCHED_CREDIT=y
-# CONFIG_SCHED_CREDIT2 is not set
-# CONFIG_SCHED_RTDS is not set
-# CONFIG_SCHED_ARINC653 is not set
-# CONFIG_SCHED_NULL is not set
-CONFIG_SCHED_CREDIT_DEFAULT=y
-CONFIG_SCHED_DEFAULT="credit"
-# CONFIG_LIVEPATCH is not set
-# CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS is not set
-CONFIG_CMDLINE=""
-
-#
-# Device Drivers
-#
-CONFIG_ACPI=y
-CONFIG_ACPI_LEGACY_TABLES_LOOKUP=y
-CONFIG_NUMA=y
-CONFIG_HAS_NS16550=y
-CONFIG_HAS_EHCI=y
-CONFIG_HAS_CPUFREQ=y
-CONFIG_HAS_PASSTHROUGH=y
-CONFIG_HAS_PCI=y
-CONFIG_DEFCONFIG_LIST="$ARCH_DEFCONFIG"
-CONFIG_ARCH_SUPPORTS_INT128=y
-
-#
-# Debugging Options
-#
-# CONFIG_DEBUG is not set
-# CONFIG_CRASH_DEBUG is not set
-# CONFIG_FRAME_POINTER is not set
-# CONFIG_COVERAGE is not set
-# CONFIG_LOCK_PROFILE is not set
-# CONFIG_PERF_COUNTERS is not set
-# CONFIG_VERBOSE_DEBUG is not set
-# CONFIG_SCRUB_DEBUG is not set
-# CONFIG_UBSAN is not set
diff --git a/xen/arch/x86/configs/pvshim_defconfig b/xen/arch/x86/configs/pvshim_defconfig
new file mode 100644
index 0000000000..38ba9feb1f
--- /dev/null
+++ b/xen/arch/x86/configs/pvshim_defconfig
@@ -0,0 +1,23 @@
+# Enable PV shim mode
+CONFIG_PV=y
+CONFIG_XEN_GUEST=y
+CONFIG_PVH_GUEST=y
+CONFIG_PV_SHIM=y
+CONFIG_PV_SHIM_EXCLUSIVE=y
+# Disable features not used by the PV shim
+CONFIG_NR_CPUS=32
+CONFIG_SHADOW_PAGING=n
+CONFIG_BIGMEM=n
+CONFIG_HVM_FEP=n
+CONFIG_TBOOT=n
+CONFIG_KEXEC=n
+CONFIG_TMEM=n
+CONFIG_XENOPROF=n
+CONFIG_XSM=n
+CONFIG_SCHED_CREDIT2=n
+CONFIG_SCHED_RTDS=n
+CONFIG_SCHED_ARINC653=n
+CONFIG_SCHED_NULL=n
+CONFIG_LIVEPATCH=n
+CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=n
+CONFIG_DEBUG=n
-- 
2.18.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] pvshim: introduce a PV shim defconfig
  2018-08-22 10:36 [PATCH] pvshim: introduce a PV shim defconfig Roger Pau Monne
@ 2018-08-22 11:40 ` Ian Jackson
  2018-08-22 13:47 ` Wei Liu
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 6+ messages in thread
From: Ian Jackson @ 2018-08-22 11:40 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: xen-devel, Wei Liu, Jan Beulich, Andrew Cooper

Roger Pau Monne writes ("[PATCH] pvshim: introduce a PV shim defconfig"):
> In order to build a tailored pvshim-only binary from Xen. Switch the
> PV shim build from the tools firmware into using the new defconfig.
> 
> A diff of the .config generated for the pvshim firmware build before
> and after this change shows no differences.

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pvshim: introduce a PV shim defconfig
  2018-08-22 10:36 [PATCH] pvshim: introduce a PV shim defconfig Roger Pau Monne
  2018-08-22 11:40 ` Ian Jackson
@ 2018-08-22 13:47 ` Wei Liu
  2018-08-22 16:29 ` Wei Liu
  2018-08-27  9:46 ` Jan Beulich
  3 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2018-08-22 13:47 UTC (permalink / raw)
  To: Roger Pau Monne
  Cc: xen-devel, Ian Jackson, Wei Liu, Jan Beulich, Andrew Cooper

On Wed, Aug 22, 2018 at 12:36:55PM +0200, Roger Pau Monne wrote:
> In order to build a tailored pvshim-only binary from Xen. Switch the
> PV shim build from the tools firmware into using the new defconfig.
> 
> A diff of the .config generated for the pvshim firmware build before
> and after this change shows no differences.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pvshim: introduce a PV shim defconfig
  2018-08-22 10:36 [PATCH] pvshim: introduce a PV shim defconfig Roger Pau Monne
  2018-08-22 11:40 ` Ian Jackson
  2018-08-22 13:47 ` Wei Liu
@ 2018-08-22 16:29 ` Wei Liu
  2018-08-27  9:46 ` Jan Beulich
  3 siblings, 0 replies; 6+ messages in thread
From: Wei Liu @ 2018-08-22 16:29 UTC (permalink / raw)
  To: Roger Pau Monne
  Cc: xen-devel, Ian Jackson, Wei Liu, Jan Beulich, Andrew Cooper

On Wed, Aug 22, 2018 at 12:36:55PM +0200, Roger Pau Monne wrote:
> In order to build a tailored pvshim-only binary from Xen. Switch the
> PV shim build from the tools firmware into using the new defconfig.
> 
> A diff of the .config generated for the pvshim firmware build before
> and after this change shows no differences.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Andrew Cooper <andrew.cooper3@citrix.com>
> ---
>  tools/firmware/xen-dir/Makefile       |  5 +-
>  tools/firmware/xen-dir/shim.config    | 84 ---------------------------
>  xen/arch/x86/configs/pvshim_defconfig | 23 ++++++++

FAOD I'm expecting an ack from x86 maintainers because a new file under
x86 is created.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pvshim: introduce a PV shim defconfig
  2018-08-22 10:36 [PATCH] pvshim: introduce a PV shim defconfig Roger Pau Monne
                   ` (2 preceding siblings ...)
  2018-08-22 16:29 ` Wei Liu
@ 2018-08-27  9:46 ` Jan Beulich
  2018-09-03 13:49   ` Roger Pau Monné
  3 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2018-08-27  9:46 UTC (permalink / raw)
  To: Roger Pau Monne; +Cc: Andrew Cooper, Wei Liu, Ian Jackson, xen-devel

>>> On 22.08.18 at 12:36, <roger.pau@citrix.com> wrote:
> --- /dev/null
> +++ b/xen/arch/x86/configs/pvshim_defconfig
> @@ -0,0 +1,23 @@
> +# Enable PV shim mode
> +CONFIG_PV=y
> +CONFIG_XEN_GUEST=y
> +CONFIG_PVH_GUEST=y
> +CONFIG_PV_SHIM=y
> +CONFIG_PV_SHIM_EXCLUSIVE=y
> +# Disable features not used by the PV shim
> +CONFIG_NR_CPUS=32
> +CONFIG_SHADOW_PAGING=n
> +CONFIG_BIGMEM=n
> +CONFIG_HVM_FEP=n
> +CONFIG_TBOOT=n
> +CONFIG_KEXEC=n
> +CONFIG_TMEM=n
> +CONFIG_XENOPROF=n
> +CONFIG_XSM=n
> +CONFIG_SCHED_CREDIT2=n
> +CONFIG_SCHED_RTDS=n
> +CONFIG_SCHED_ARINC653=n
> +CONFIG_SCHED_NULL=n
> +CONFIG_LIVEPATCH=n
> +CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=n
> +CONFIG_DEBUG=n

Since the *defconfig-s we have so far are all empty, and since the
Linux x86 ones aren't written this way I wonder: Is there a reason
you use "=n" instead of the "# CONFIG_... is not set" form?

Jan



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] pvshim: introduce a PV shim defconfig
  2018-08-27  9:46 ` Jan Beulich
@ 2018-09-03 13:49   ` Roger Pau Monné
  0 siblings, 0 replies; 6+ messages in thread
From: Roger Pau Monné @ 2018-09-03 13:49 UTC (permalink / raw)
  To: Jan Beulich; +Cc: Andrew Cooper, Wei Liu, Ian Jackson, xen-devel

On Mon, Aug 27, 2018 at 03:46:03AM -0600, Jan Beulich wrote:
> >>> On 22.08.18 at 12:36, <roger.pau@citrix.com> wrote:
> > --- /dev/null
> > +++ b/xen/arch/x86/configs/pvshim_defconfig
> > @@ -0,0 +1,23 @@
> > +# Enable PV shim mode
> > +CONFIG_PV=y
> > +CONFIG_XEN_GUEST=y
> > +CONFIG_PVH_GUEST=y
> > +CONFIG_PV_SHIM=y
> > +CONFIG_PV_SHIM_EXCLUSIVE=y
> > +# Disable features not used by the PV shim
> > +CONFIG_NR_CPUS=32
> > +CONFIG_SHADOW_PAGING=n
> > +CONFIG_BIGMEM=n
> > +CONFIG_HVM_FEP=n
> > +CONFIG_TBOOT=n
> > +CONFIG_KEXEC=n
> > +CONFIG_TMEM=n
> > +CONFIG_XENOPROF=n
> > +CONFIG_XSM=n
> > +CONFIG_SCHED_CREDIT2=n
> > +CONFIG_SCHED_RTDS=n
> > +CONFIG_SCHED_ARINC653=n
> > +CONFIG_SCHED_NULL=n
> > +CONFIG_LIVEPATCH=n
> > +CONFIG_SUPPRESS_DUPLICATE_SYMBOL_WARNINGS=n
> > +CONFIG_DEBUG=n
> 
> Since the *defconfig-s we have so far are all empty, and since the
> Linux x86 ones aren't written this way I wonder: Is there a reason
> you use "=n" instead of the "# CONFIG_... is not set" form?

My personal preference is to explicitly set them to =n, I think it's
clearer. Using "# CONFIG_FOO is not set" looks to me like "CONFIG_FOO
will be using the default value". In any case, I've changed this to
use the 'is not set' form and will resend shortly.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-03 13:49 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-22 10:36 [PATCH] pvshim: introduce a PV shim defconfig Roger Pau Monne
2018-08-22 11:40 ` Ian Jackson
2018-08-22 13:47 ` Wei Liu
2018-08-22 16:29 ` Wei Liu
2018-08-27  9:46 ` Jan Beulich
2018-09-03 13:49   ` Roger Pau Monné

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.