request for 4.14-stable: c82b7623edd7 ("gcc-plugins: Add include required by GCC release 8")

request for 4.14-stable: c82b7623edd7 ("gcc-plugins: Add include required by GCC release 8")

[Lance Albertson]

Hi Greg,

I was trying to compile 4.14.67 using GCC 8.2.0 with gcc-plugins enabled 
and ran into this issue [1]. If I applied both of the commits mentioned, 
it resolved the problem so I think it should be included in 4.14.

Thanks!

[1] 
https://groups.google.com/forum/#!msg/qubes-devel/Q3cdQKQS4Tk/gKr4F52HAAAJ

-- 
Lance Albertson
Director
Oregon State University | Open Source Lab

---

 From c82b7623edd74a57fffd69dbab25d180c3b16c6f Mon Sep 17 00:00:00 2001
From: "valdis.kletnieks@vt.edu" <valdis.kletnieks@vt.edu>
Date: Sun, 4 Feb 2018 12:01:43 -0500
Subject: [PATCH 2/2] gcc-plugins: Add include required by GCC release 8

GCC requires another #include to get the gcc-plugins to build cleanly.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Signed-off-by: Kees Cook <keescook@chromium.org>
---
  scripts/gcc-plugins/gcc-common.h | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/scripts/gcc-plugins/gcc-common.h 
b/scripts/gcc-plugins/gcc-common.h
index ffd1dfaa1cc1..f46750053377 100644
--- a/scripts/gcc-plugins/gcc-common.h
+++ b/scripts/gcc-plugins/gcc-common.h
@@ -97,6 +97,10 @@
  #include "predict.h"
  #include "ipa-utils.h"

+#if BUILDING_GCC_VERSION >= 8000
+#include "stringpool.h"
+#endif
+
  #if BUILDING_GCC_VERSION >= 4009
  #include "attribs.h"
  #include "varasm.h"

-- 
Lance Albertson
Director
Oregon State University | Open Source Lab

Re: request for 4.14-stable: c82b7623edd7 ("gcc-plugins: Add include required by GCC release 8")

[Greg KH]

On Sun, Sep 02, 2018 at 08:36:22PM -0700, Lance Albertson wrote:
> Hi Greg,
> 
> I was trying to compile 4.14.67 using GCC 8.2.0 with gcc-plugins enabled and
> ran into this issue [1]. If I applied both of the commits mentioned, it
> resolved the problem so I think it should be included in 4.14.
> 
> Thanks!
> 
> [1]
> https://groups.google.com/forum/#!msg/qubes-devel/Q3cdQKQS4Tk/gKr4F52HAAAJ
> 
> -- 
> Lance Albertson
> Director
> Oregon State University | Open Source Lab
> 
> ---
> 
> From c82b7623edd74a57fffd69dbab25d180c3b16c6f Mon Sep 17 00:00:00 2001

This should be commit 80d172431696 ("gcc-plugins: Add include required
by GCC release 8"), right?

Where did this other id come from?

thanks,

greg k-h

Re: request for 4.14-stable: c82b7623edd7 ("gcc-plugins: Add include required by GCC release 8")

[Lance Albertson]

On 9/3/18 9:25 AM, Greg KH wrote:
> On Sun, Sep 02, 2018 at 08:36:22PM -0700, Lance Albertson wrote:
>> Hi Greg,
>>
>> I was trying to compile 4.14.67 using GCC 8.2.0 with gcc-plugins enabled and
>> ran into this issue [1]. If I applied both of the commits mentioned, it
>> resolved the problem so I think it should be included in 4.14.
>>
>> Thanks!
>>
>> [1]
>> https://groups.google.com/forum/#!msg/qubes-devel/Q3cdQKQS4Tk/gKr4F52HAAAJ
>>
>> -- 
>> Lance Albertson
>> Director
>> Oregon State University | Open Source Lab
>>
>> ---
>>
>>  From c82b7623edd74a57fffd69dbab25d180c3b16c6f Mon Sep 17 00:00:00 2001
> 
> This should be commit 80d172431696 ("gcc-plugins: Add include required
> by GCC release 8"), right?
> 
> Where did this other id come from?

That is correct. Looks like I accidentally used the sha I had with my 
test branch with that cherry-picked. Apologies for the oversight.

-- 
Lance Albertson
Director
Oregon State University | Open Source Lab