* [PATCH] video/fbdev: Warn when we try to free a registered framebuffer @ 2018-09-03 16:51 Chris Wilson 2018-09-03 17:02 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2018-09-03 17:22 ` ✗ Fi.CI.BAT: failure " Patchwork 0 siblings, 2 replies; 3+ messages in thread From: Chris Wilson @ 2018-09-03 16:51 UTC (permalink / raw) To: intel-gfx; +Cc: Daniel Vetter Just a tool for CI to emit the stacktrace of who is lost track of their framebuffers and tried to free it before unregistering it. References: https://bugs.freedesktop.org/show_bug.cgi?id=107712 Cc: Daniel Vetter <daniel.vetter@ffwll.ch> --- Would be useful to keep in core-for-CI as a debug aide. --- drivers/video/fbdev/core/fbsysfs.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/video/fbdev/core/fbsysfs.c b/drivers/video/fbdev/core/fbsysfs.c index e31a182b42bf..de3afba984c7 100644 --- a/drivers/video/fbdev/core/fbsysfs.c +++ b/drivers/video/fbdev/core/fbsysfs.c @@ -83,6 +83,11 @@ void framebuffer_release(struct fb_info *info) { if (!info) return; + + if (WARN(atomic_read(&info->count), + "framebuffer is still registered, leaking fb_info!\n")) + return; + kfree(info->apertures); kfree(info); } -- 2.19.0.rc1 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply related [flat|nested] 3+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for video/fbdev: Warn when we try to free a registered framebuffer 2018-09-03 16:51 [PATCH] video/fbdev: Warn when we try to free a registered framebuffer Chris Wilson @ 2018-09-03 17:02 ` Patchwork 2018-09-03 17:22 ` ✗ Fi.CI.BAT: failure " Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-09-03 17:02 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: video/fbdev: Warn when we try to free a registered framebuffer URL : https://patchwork.freedesktop.org/series/49088/ State : warning == Summary == $ dim checkpatch origin/drm-tip 19ba7c0f116f video/fbdev: Warn when we try to free a registered framebuffer -:28: ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s) total: 1 errors, 0 warnings, 0 checks, 11 lines checked _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
* ✗ Fi.CI.BAT: failure for video/fbdev: Warn when we try to free a registered framebuffer 2018-09-03 16:51 [PATCH] video/fbdev: Warn when we try to free a registered framebuffer Chris Wilson 2018-09-03 17:02 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork @ 2018-09-03 17:22 ` Patchwork 1 sibling, 0 replies; 3+ messages in thread From: Patchwork @ 2018-09-03 17:22 UTC (permalink / raw) To: Chris Wilson; +Cc: intel-gfx == Series Details == Series: video/fbdev: Warn when we try to free a registered framebuffer URL : https://patchwork.freedesktop.org/series/49088/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4757 -> Patchwork_10075 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10075 absolutely need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in Patchwork_10075, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://patchwork.freedesktop.org/api/1.0/series/49088/revisions/1/mbox/ == Possible new issues == Here are the unknown changes that may have been introduced in Patchwork_10075: === IGT changes === ==== Possible regressions ==== igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b: fi-icl-u: PASS -> INCOMPLETE == Known issues == Here are the changes found in Patchwork_10075 that come from known issues: === IGT changes === ==== Issues hit ==== igt@kms_pipe_crc_basic@nonblocking-crc-pipe-a-frame-sequence: fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) ==== Possible fixes ==== igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b-frame-sequence: fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c: fi-bxt-dsi: INCOMPLETE (fdo#103927) -> PASS fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191 fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927 fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362 == Participating hosts (53 -> 48) == Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u == Build changes == * Linux: CI_DRM_4757 -> Patchwork_10075 CI_DRM_4757: 1465de895e2b5d9e74e9a85189c9075155efa30d @ git://anongit.freedesktop.org/gfx-ci/linux IGT_4621: 125eee6e981eac0a004aeb4f327439a132ceac5c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools Patchwork_10075: 19ba7c0f116fd5ec8f0e0a77b13ea3f9ae3c67a5 @ git://anongit.freedesktop.org/gfx-ci/linux == Linux commits == 19ba7c0f116f video/fbdev: Warn when we try to free a registered framebuffer == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10075/issues.html _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-03 17:22 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-03 16:51 [PATCH] video/fbdev: Warn when we try to free a registered framebuffer Chris Wilson 2018-09-03 17:02 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork 2018-09-03 17:22 ` ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.