All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexandru Gagniuc <mr.nuke.me@gmail.com>
To: linux-pci@vger.kernel.org, bhelgaas@google.com
Cc: keith.busch@intel.com, alex_gagniuc@dellteam.com,
	austin_bolen@dell.com, shyam_iyer@dell.com,
	Alexandru Gagniuc <mr.nuke.me@gmail.com>,
	Ariel Elior <ariel.elior@cavium.com>,
	everest-linux-l2@cavium.com,
	"David S. Miller" <davem@davemloft.net>,
	Michael Chan <michael.chan@broadcom.com>,
	Ganesh Goudar <ganeshgr@chelsio.com>,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
	Tariq Toukan <tariqt@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Leon Romanovsky <leon@kernel.org>,
	Jakub Kicinski <jakub.kicinski@netronome.com>,
	Dirk van der Merwe <dirk.vandermerwe@netronome.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, linux-rdma@vger.kernel.org,
	oss-drivers@netronome.com
Subject: [PATCH 6/9] ixgbe: Do not call pcie_print_link_status()
Date: Mon,  3 Sep 2018 13:02:33 -0500	[thread overview]
Message-ID: <20180903180242.14504-7-mr.nuke.me@gmail.com> (raw)
In-Reply-To: <20180903180242.14504-1-mr.nuke.me@gmail.com>

This is now done by the PCI core to warn of sub-optimal bandwidth.

Signed-off-by: Alexandru Gagniuc <mr.nuke.me@gmail.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 26 -------------------
 1 file changed, 26 deletions(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 9a23d33a47ed..9663419e0ceb 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -241,28 +241,6 @@ static inline bool ixgbe_pcie_from_parent(struct ixgbe_hw *hw)
 	}
 }
 
-static void ixgbe_check_minimum_link(struct ixgbe_adapter *adapter,
-				     int expected_gts)
-{
-	struct ixgbe_hw *hw = &adapter->hw;
-	struct pci_dev *pdev;
-
-	/* Some devices are not connected over PCIe and thus do not negotiate
-	 * speed. These devices do not have valid bus info, and thus any report
-	 * we generate may not be correct.
-	 */
-	if (hw->bus.type == ixgbe_bus_type_internal)
-		return;
-
-	/* determine whether to use the parent device */
-	if (ixgbe_pcie_from_parent(&adapter->hw))
-		pdev = adapter->pdev->bus->parent->self;
-	else
-		pdev = adapter->pdev;
-
-	pcie_print_link_status(pdev);
-}
-
 static void ixgbe_service_event_schedule(struct ixgbe_adapter *adapter)
 {
 	if (!test_bit(__IXGBE_DOWN, &adapter->state) &&
@@ -10792,10 +10770,6 @@ static int ixgbe_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
 		break;
 	}
 
-	/* don't check link if we failed to enumerate functions */
-	if (expected_gts > 0)
-		ixgbe_check_minimum_link(adapter, expected_gts);
-
 	err = ixgbe_read_pba_string_generic(hw, part_str, sizeof(part_str));
 	if (err)
 		strlcpy(part_str, "Unknown", sizeof(part_str));
-- 
2.17.1

  parent reply	other threads:[~2018-09-03 18:02 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-03 18:02 [PATCH 0/9] Export PCIe bandwidth via sysfs Alexandru Gagniuc
2018-09-03 18:02 ` Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 1/9] PCI: sysfs: Export available PCIe bandwidth Alexandru Gagniuc
2018-09-05  7:26   ` Stephen Hemminger
2018-09-05  7:26     ` [Intel-wired-lan] " Stephen Hemminger
2018-09-05 13:52     ` Alex G.
2018-10-03 21:30   ` Bjorn Helgaas
2018-10-03 21:30     ` [Intel-wired-lan] " Bjorn Helgaas
2018-10-03 21:30     ` Bjorn Helgaas
2018-10-03 21:30     ` Bjorn Helgaas
2018-10-03 22:00     ` Alex_Gagniuc
2018-10-03 22:00       ` [Intel-wired-lan] " Alex_Gagniuc
2018-10-03 22:00       ` Alex_Gagniuc
2018-10-04 20:45       ` Bjorn Helgaas
2018-10-04 20:45         ` [Intel-wired-lan] " Bjorn Helgaas
2018-10-08 21:09         ` Alex_Gagniuc
2018-10-08 21:09           ` [Intel-wired-lan] " Alex_Gagniuc
2018-10-08 21:09           ` Alex_Gagniuc
2018-09-03 18:02 ` [PATCH 2/9] bnx2x: Do not call pcie_print_link_status() Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 3/9] bnxt_en: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 4/9] cxgb4: " Alexandru Gagniuc
2018-09-03 18:02 ` [PATCH 5/9] fm10k: " Alexandru Gagniuc
2018-09-03 18:02 ` Alexandru Gagniuc [this message]
2018-09-03 18:02 ` [PATCH 7/9] net/mlx4: " Alexandru Gagniuc
2018-09-04 12:51   ` Leon Romanovsky
2018-09-04 12:51     ` [Intel-wired-lan] " Leon Romanovsky
2018-09-03 18:02 ` [PATCH 8/9] net/mlx5: " Alexandru Gagniuc
2018-09-04 12:51   ` Leon Romanovsky
2018-09-04 12:51     ` [Intel-wired-lan] " Leon Romanovsky
2018-09-03 18:02 ` [PATCH 9/9] nfp: " Alexandru Gagniuc

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180903180242.14504-7-mr.nuke.me@gmail.com \
    --to=mr.nuke.me@gmail.com \
    --cc=alex_gagniuc@dellteam.com \
    --cc=ariel.elior@cavium.com \
    --cc=austin_bolen@dell.com \
    --cc=bhelgaas@google.com \
    --cc=davem@davemloft.net \
    --cc=dirk.vandermerwe@netronome.com \
    --cc=everest-linux-l2@cavium.com \
    --cc=ganeshgr@chelsio.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jakub.kicinski@netronome.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=keith.busch@intel.com \
    --cc=leon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=oss-drivers@netronome.com \
    --cc=saeedm@mellanox.com \
    --cc=shyam_iyer@dell.com \
    --cc=tariqt@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.