[PATCH] Document/gpu: Use new vm_fault_t type

[PATCH] Document/gpu: Use new vm_fault_t type

[Souptick Joarder]

We have introduce new return type vm_fault_t for
fault handler. Update the document for the same.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
v2: Revert spaces added in v1

 Documentation/gpu/drm-mm.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
index 21b6b72..c3ae888 100644
--- a/Documentation/gpu/drm-mm.rst
+++ b/Documentation/gpu/drm-mm.rst
@@ -297,7 +297,7 @@ made up of several fields, the more interesting ones being:
 	struct vm_operations_struct {
 		void (*open)(struct vm_area_struct * area);
 		void (*close)(struct vm_area_struct * area);
-		int (*fault)(struct vm_fault *vmf);
+		vm_fault_t (*fault)(struct vm_fault *vmf);
 	};
 
 
-- 
1.9.1

Re: [PATCH] Document/gpu: Use new vm_fault_t type

[Daniel Vetter]

On Tue, Sep 04, 2018 at 09:45:05AM +0530, Souptick Joarder wrote:
> We have introduce new return type vm_fault_t for
> fault handler. Update the document for the same.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> ---
> v2: Revert spaces added in v1

Thanks, applied to drm-misc-next.
-Daniel

> 
>  Documentation/gpu/drm-mm.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
> index 21b6b72..c3ae888 100644
> --- a/Documentation/gpu/drm-mm.rst
> +++ b/Documentation/gpu/drm-mm.rst
> @@ -297,7 +297,7 @@ made up of several fields, the more interesting ones being:
>  	struct vm_operations_struct {
>  		void (*open)(struct vm_area_struct * area);
>  		void (*close)(struct vm_area_struct * area);
> -		int (*fault)(struct vm_fault *vmf);
> +		vm_fault_t (*fault)(struct vm_fault *vmf);
>  	};
>  
>  
> -- 
> 1.9.1
> 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

Re: [PATCH] Document/gpu: Use new vm_fault_t type

[Souptick Joarder]

[-- Attachment #1.1: Type: text/plain, Size: 435 bytes --]

On 29-Aug-2018 3:36 AM, "Matthew Wilcox" <willy@infradead.org> wrote:
>
> On Tue, Aug 28, 2018 at 10:44:43PM +0530, Souptick Joarder wrote:
> > We have introduce a new return type vm_fault_t for
> > fault handler. Update the document for the same.
>
> Have you built the documentation and checked the html looks better with
> the changed spacing?

Is there any separate way to build document folders other than "make" ?
I will verify.

[-- Attachment #1.2: Type: text/html, Size: 649 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH] Document/gpu: Use new vm_fault_t type

[Matthew Wilcox]

On Tue, Aug 28, 2018 at 10:44:43PM +0530, Souptick Joarder wrote:
> We have introduce a new return type vm_fault_t for
> fault handler. Update the document for the same.

Have you built the documentation and checked the html looks better with
the changed spacing?  rst can be a bit weird about some of these things.

[PATCH] Document/gpu: Use new vm_fault_t type

[Souptick Joarder]

We have introduce a new return type vm_fault_t for
fault handler. Update the document for the same.

Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
---
 Documentation/gpu/drm-mm.rst | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/gpu/drm-mm.rst b/Documentation/gpu/drm-mm.rst
index 21b6b72..23ae261 100644
--- a/Documentation/gpu/drm-mm.rst
+++ b/Documentation/gpu/drm-mm.rst
@@ -295,9 +295,9 @@ made up of several fields, the more interesting ones being:
 .. code-block:: c
 
 	struct vm_operations_struct {
-		void (*open)(struct vm_area_struct * area);
-		void (*close)(struct vm_area_struct * area);
-		int (*fault)(struct vm_fault *vmf);
+		void       (*open)(struct vm_area_struct * area);
+		void       (*close)(struct vm_area_struct * area);
+		vm_fault_t (*fault)(struct vm_fault *vmf);
 	};
 
 
-- 
1.9.1