All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean-Noel Avila <jn.avila@free.fr>
To: git@vger.kernel.org
Cc: Jean-Noel Avila <jn.avila@free.fr>
Subject: [PATCH] i18n: fix dangling dot in die() messages
Date: Tue,  4 Sep 2018 16:18:16 +0200	[thread overview]
Message-ID: <20180904141816.26398-1-jn.avila@free.fr> (raw)
In-Reply-To: <CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com>

Signed-off-by: Jean-Noël Avila <jn.avila@free.fr>
---

It is not clear what the style guide for messages is.

 builtin/submodule--helper.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index b56028ba9d..a011abfd7c 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -521,7 +521,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
 		printf(_("Entering '%s'\n"), displaypath);
 
 	if (info->argv[0] && run_command(&cp))
-		die(_("run_command returned non-zero status for %s\n."),
+		die(_("run_command returned non-zero status for %s"),
 			displaypath);
 
 	if (info->recursive) {
@@ -543,7 +543,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
 
 		if (run_command(&cpr))
 			die(_("run_command returned non-zero status while "
-				"recursing in the nested submodules of %s\n."),
+				"recursing in the nested submodules of %s"),
 				displaypath);
 	}
 
-- 
2.18.0


  reply	other threads:[~2018-09-04 14:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano
2018-09-03 17:52   ` Jean-Noël AVILA
2018-09-04  1:01     ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04  1:52 ` [PATCH] i18n: fix mistakes in translated strings Jiang Xin
2018-09-04 14:18   ` Jean-Noel Avila [this message]
2018-09-04 15:05     ` [PATCH] i18n: fix dangling dot in die() messages Ævar Arnfjörð Bjarmason
2018-09-04 15:13       ` Jean-Noël Avila
2018-09-04 19:47         ` Junio C Hamano
2018-09-04 15:16       ` Duy Nguyen
2018-09-04 19:32   ` [PATCH] i18n: fix mistakes in translated strings Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180904141816.26398-1-jn.avila@free.fr \
    --to=jn.avila@free.fr \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.