All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiang Xin <worldhello.net@gmail.com>
To: Jean-Noel Avila <jn.avila@free.fr>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] i18n: fix mistakes in translated strings
Date: Tue, 4 Sep 2018 09:52:07 +0800	[thread overview]
Message-ID: <CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com> (raw)
In-Reply-To: <20180823210056.27489-1-jn.avila@free.fr>

Jean-Noël Avila <jn.avila@free.fr> 于2018年8月24日周五 上午5:02写道：
> diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
> index 2bcc70fdfe..b56028ba9d 100644
> --- a/builtin/submodule--helper.c
> +++ b/builtin/submodule--helper.c
> @@ -542,7 +542,7 @@ static void runcommand_in_submodule_cb(const struct cache_entry *list_item,
>                 argv_array_pushv(&cpr.args, info->argv);
>
>                 if (run_command(&cpr))
> -                       die(_("run_command returned non-zero status while"
> +                       die(_("run_command returned non-zero status while "
>                                 "recursing in the nested submodules of %s\n."),

Any specific reason to put a period after newline?
And there is another mistake just above this one:

    "run_command returned non-zero status for %s\n."

-- 
Jiang Xin

  parent reply	other threads:[~2018-09-04  1:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-23 21:00 [PATCH] i18n: fix mistakes in translated strings Jean-Noël Avila
2018-08-23 21:28 ` Junio C Hamano
2018-09-03 17:52   ` Jean-Noël AVILA
2018-09-04  1:01     ` [L10N] Kickoff for Git 2.19.0 round 2 Jiang Xin
2018-09-04  1:52 ` Jiang Xin [this message]
2018-09-04 14:18   ` [PATCH] i18n: fix dangling dot in die() messages Jean-Noel Avila
2018-09-04 15:05     ` Ævar Arnfjörð Bjarmason
2018-09-04 15:13       ` Jean-Noël Avila
2018-09-04 19:47         ` Junio C Hamano
2018-09-04 15:16       ` Duy Nguyen
2018-09-04 19:32   ` [PATCH] i18n: fix mistakes in translated strings Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANYiYbHmU=j+MwLTumJ+BK_0msyPBeux92wF8VqL9J04VOc-FQ@mail.gmail.com' \
    --to=worldhello.net@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=jn.avila@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.