* [PATCH v3] zbd: Fix test scripts
@ 2018-09-05 8:02 Damien Le Moal
2018-09-05 14:21 ` Bart Van Assche
2018-09-05 14:36 ` Jens Axboe
0 siblings, 2 replies; 6+ messages in thread
From: Damien Le Moal @ 2018-09-05 8:02 UTC (permalink / raw)
To: fio, Jens Axboe; +Cc: Bart Van Assche
Fix handling of the path to the test-zbd-support script to avoid an
error when the tests are run directly when in fio/t/zbd using the
command "./run-against...".
Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
---
Changes from v2:
* Avoid shellcheck warnings as suggested by Bart.
Changes from v1:
* Use a scriptdir variable as suggested by Bart.
t/zbd/run-tests-against-regular-nullb | 4 +++-
t/zbd/run-tests-against-zoned-nullb | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/t/zbd/run-tests-against-regular-nullb b/t/zbd/run-tests-against-regular-nullb
index 133c7c41..0f6e4b66 100755
--- a/t/zbd/run-tests-against-regular-nullb
+++ b/t/zbd/run-tests-against-regular-nullb
@@ -4,6 +4,8 @@
#
# This file is released under the GPL.
+scriptdir="$(cd "$(dirname "$0")" && pwd)"
+
for d in /sys/kernel/config/nullb/*; do [ -d "$d" ] && rmdir "$d"; done
modprobe -r null_blk
modprobe null_blk nr_devices=0 || return $?
@@ -22,4 +24,4 @@ modprobe null_blk nr_devices=0 &&
echo 1 > memory_backed &&
echo 1 > power
-"$(dirname "$0")"/test-zbd-support "$@" /dev/nullb0
+"${scriptdir}"/test-zbd-support "$@" /dev/nullb0
diff --git a/t/zbd/run-tests-against-zoned-nullb b/t/zbd/run-tests-against-zoned-nullb
index 7d9eb439..9336716d 100755
--- a/t/zbd/run-tests-against-zoned-nullb
+++ b/t/zbd/run-tests-against-zoned-nullb
@@ -4,6 +4,8 @@
#
# This file is released under the GPL.
+scriptdir="$(cd "$(dirname "$0")" && pwd)"
+
for d in /sys/kernel/config/nullb/*; do [ -d "$d" ] && rmdir "$d"; done
modprobe -r null_blk
modprobe null_blk nr_devices=0 || return $?
@@ -24,4 +26,4 @@ modprobe null_blk nr_devices=0 &&
echo 1 > memory_backed &&
echo 1 > power
-"$(dirname "$0")"/test-zbd-support "$@" /dev/nullb0
+"${scriptdir}"/test-zbd-support "$@" /dev/nullb0
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH v3] zbd: Fix test scripts
2018-09-05 8:02 [PATCH v3] zbd: Fix test scripts Damien Le Moal
@ 2018-09-05 14:21 ` Bart Van Assche
2018-09-05 14:36 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Bart Van Assche @ 2018-09-05 14:21 UTC (permalink / raw)
To: Damien Le Moal, fio, Jens Axboe
On 09/05/18 01:02, Damien Le Moal wrote:
> Fix handling of the path to the test-zbd-support script to avoid an
> error when the tests are run directly when in fio/t/zbd using the
> command "./run-against...".
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] zbd: Fix test scripts
2018-09-05 8:02 [PATCH v3] zbd: Fix test scripts Damien Le Moal
2018-09-05 14:21 ` Bart Van Assche
@ 2018-09-05 14:36 ` Jens Axboe
2018-09-06 1:08 ` Damien Le Moal
1 sibling, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2018-09-05 14:36 UTC (permalink / raw)
To: Damien Le Moal, fio; +Cc: Bart Van Assche
On 9/5/18 2:02 AM, Damien Le Moal wrote:
> Fix handling of the path to the test-zbd-support script to avoid an
> error when the tests are run directly when in fio/t/zbd using the
> command "./run-against...".
Thanks, applied.
Where are we on the other zbd fixes? I want to cut a new version
fairly soon, but I don't want to do that with fixes still pending.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] zbd: Fix test scripts
2018-09-05 14:36 ` Jens Axboe
@ 2018-09-06 1:08 ` Damien Le Moal
2018-09-06 1:12 ` Damien Le Moal
0 siblings, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2018-09-06 1:08 UTC (permalink / raw)
To: fio, axboe; +Cc: bvanassche
Jens,
On Wed, 2018-09-05 at 08:36 -0600, Jens Axboe wrote:
> On 9/5/18 2:02 AM, Damien Le Moal wrote:
> > Fix handling of the path to the test-zbd-support script to avoid an
> > error when the tests are run directly when in fio/t/zbd using the
> > command "./run-against...".
>
> Thanks, applied.
>
> Where are we on the other zbd fixes? I want to cut a new version
> fairly soon, but I don't want to do that with fixes still pending.
The v3 of the 3 patch series I sent was heavily tested and reviewed by Bart.
So I think the changes are OK to go.
I updated my pull request in github with the latest version of all patches:
* The 3 patches of the v3 "ZBD support improvements and cleanup":
[PATCH v3 1/3] zbd: Improve read randomness
[PATCH v3 2/3] zbd: Remove inexistent functions declaration
[PATCH v3 3/3] zbd: Fix zbd_zone_idx()
* This test script fix patch
* A patch that cleans up the code using the fio regular byte unit for zone
information:
[PATCH] zbd: Use bytes unit
Thanks !
--
Damien Le Moal
Western Digital
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] zbd: Fix test scripts
2018-09-06 1:08 ` Damien Le Moal
@ 2018-09-06 1:12 ` Damien Le Moal
2018-09-06 1:26 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Damien Le Moal @ 2018-09-06 1:12 UTC (permalink / raw)
To: fio, axboe; +Cc: bvanassche
On Thu, 2018-09-06 at 01:08 +0000, Damien Le Moal wrote:
> Jens,
>
> On Wed, 2018-09-05 at 08:36 -0600, Jens Axboe wrote:
> > On 9/5/18 2:02 AM, Damien Le Moal wrote:
> > > Fix handling of the path to the test-zbd-support script to avoid an
> > > error when the tests are run directly when in fio/t/zbd using the
> > > command "./run-against...".
> >
> > Thanks, applied.
> >
> > Where are we on the other zbd fixes? I want to cut a new version
> > fairly soon, but I don't want to do that with fixes still pending.
>
> The v3 of the 3 patch series I sent was heavily tested and reviewed by Bart.
> So I think the changes are OK to go.
>
> I updated my pull request in github with the latest version of all patches:
> * The 3 patches of the v3 "ZBD support improvements and cleanup":
> [PATCH v3 1/3] zbd: Improve read randomness
> [PATCH v3 2/3] zbd: Remove inexistent functions declaration
> [PATCH v3 3/3] zbd: Fix zbd_zone_idx()
> * This test script fix patch
> * A patch that cleans up the code using the fio regular byte unit for zone
> information:
> [PATCH] zbd: Use bytes unit
Correction: I rebased the pull request. Since the test script patch was
applied, only 4 patches in the pull request now.
Thanks !
--
Damien Le Moal
Western Digital
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v3] zbd: Fix test scripts
2018-09-06 1:12 ` Damien Le Moal
@ 2018-09-06 1:26 ` Jens Axboe
0 siblings, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2018-09-06 1:26 UTC (permalink / raw)
To: Damien Le Moal, fio; +Cc: bvanassche
On 9/5/18 7:12 PM, Damien Le Moal wrote:
> On Thu, 2018-09-06 at 01:08 +0000, Damien Le Moal wrote:
>> Jens,
>>
>> On Wed, 2018-09-05 at 08:36 -0600, Jens Axboe wrote:
>>> On 9/5/18 2:02 AM, Damien Le Moal wrote:
>>>> Fix handling of the path to the test-zbd-support script to avoid an
>>>> error when the tests are run directly when in fio/t/zbd using the
>>>> command "./run-against...".
>>>
>>> Thanks, applied.
>>>
>>> Where are we on the other zbd fixes? I want to cut a new version
>>> fairly soon, but I don't want to do that with fixes still pending.
>>
>> The v3 of the 3 patch series I sent was heavily tested and reviewed by Bart.
>> So I think the changes are OK to go.
>>
>> I updated my pull request in github with the latest version of all patches:
>> * The 3 patches of the v3 "ZBD support improvements and cleanup":
>> [PATCH v3 1/3] zbd: Improve read randomness
>> [PATCH v3 2/3] zbd: Remove inexistent functions declaration
>> [PATCH v3 3/3] zbd: Fix zbd_zone_idx()
>> * This test script fix patch
>> * A patch that cleans up the code using the fio regular byte unit for zone
>> information:
>> [PATCH] zbd: Use bytes unit
>
> Correction: I rebased the pull request. Since the test script patch was
> applied, only 4 patches in the pull request now.
Great thanks, I'll pull them in.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-06 1:26 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 8:02 [PATCH v3] zbd: Fix test scripts Damien Le Moal
2018-09-05 14:21 ` Bart Van Assche
2018-09-05 14:36 ` Jens Axboe
2018-09-06 1:08 ` Damien Le Moal
2018-09-06 1:12 ` Damien Le Moal
2018-09-06 1:26 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.