[igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Chris Wilson]

We report the failure from igt_setup_runtime_pm() so that the caller can
decide how they may proceed, so replace the hard assert with the error
propagation.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Imre Deak <imre.deak@intel.com>
---
 lib/igt_pm.c | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index 615463a08..49027238b 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -511,12 +511,16 @@ bool igt_setup_runtime_pm(void)
 
 	igt_pm_enable_audio_runtime_pm();
 
-	/* Our implementation uses autosuspend. Try to set it to 0ms so the test
-	 * suite goes faster and we have a higher probability of triggering race
-	 * conditions. */
+	/*
+	 * Our implementation uses autosuspend. Try to set it to 0ms so the
+	 * test suite goes faster and we have a higher probability of
+	 * triggering race conditions.
+	 */
 	fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR);
-	igt_assert_f(fd >= 0,
-		     "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
+	if (fd < 0) {
+		igt_pm_audio_restore_runtime_pm();
+		return false;
+	}
 
 	/*
 	 * Save previous values to be able to  install exit handler to restore
@@ -531,6 +535,7 @@ bool igt_setup_runtime_pm(void)
 	 */
 	if (size <= 0) {
 		close(fd);
+		igt_pm_audio_restore_runtime_pm();
 		return false;
 	}
 
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Patchwork]

== Series Details ==

Series: lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel
URL   : https://patchwork.freedesktop.org/series/49169/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4770 -> IGTPW_1788 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1788 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1788, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49169/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1788:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@module-reload:
      fi-hsw-4770r:       SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1788 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@amdgpu/amd_basic@userptr:
      fi-kbl-8809g:       PASS -> INCOMPLETE (fdo#107402)

    igt@gem_exec_suspend@basic-s3:
      fi-skl-caroline:    NOTRUN -> INCOMPLETE (fdo#104108, fdo#107556)

    igt@kms_psr@primary_page_flip:
      fi-icl-u:           NOTRUN -> FAIL (fdo#107383) +3

    
    ==== Possible fixes ====

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       DMESG-WARN (fdo#107425) -> PASS

    igt@gem_exec_suspend@basic-s4-devices:
      fi-kbl-7500u:       DMESG-WARN (fdo#105128, fdo#107139) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     FAIL (fdo#103167) -> PASS

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
  fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
  fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
  fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
  fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
  fdo#107402 https://bugs.freedesktop.org/show_bug.cgi?id=107402
  fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556


== Participating hosts (50 -> 49) ==

  Additional (4): fi-glk-j4005 fi-skl-caroline fi-icl-u fi-elk-e7500 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4627 -> IGTPW_1788

  CI_DRM_4770: 0c3535cf60140d017a5df73d84d06e8b1a5b5d3b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1788: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1788/
  IGT_4627: e0c3033a57d85c0d2eb33af0451afa16edc79f10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1788/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Tvrtko Ursulin]

On 05/09/2018 10:07, Chris Wilson wrote:
> We report the failure from igt_setup_runtime_pm() so that the caller can
> decide how they may proceed, so replace the hard assert with the error
> propagation.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Imre Deak <imre.deak@intel.com>
> ---
>   lib/igt_pm.c | 15 ++++++++++-----
>   1 file changed, 10 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index 615463a08..49027238b 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -511,12 +511,16 @@ bool igt_setup_runtime_pm(void)
>   
>   	igt_pm_enable_audio_runtime_pm();
>   
> -	/* Our implementation uses autosuspend. Try to set it to 0ms so the test
> -	 * suite goes faster and we have a higher probability of triggering race
> -	 * conditions. */
> +	/*
> +	 * Our implementation uses autosuspend. Try to set it to 0ms so the
> +	 * test suite goes faster and we have a higher probability of
> +	 * triggering race conditions.
> +	 */
>   	fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR);
> -	igt_assert_f(fd >= 0,
> -		     "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
> +	if (fd < 0) {
> +		igt_pm_audio_restore_runtime_pm();
> +		return false;

Worth robustifying with an igt_assert_eq(errno, ENOENT) ?

Anyway a stretched concern:

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Regards,

Tvrtko

> +	}
>   
>   	/*
>   	 * Save previous values to be able to  install exit handler to restore
> @@ -531,6 +535,7 @@ bool igt_setup_runtime_pm(void)
>   	 */
>   	if (size <= 0) {
>   		close(fd);
> +		igt_pm_audio_restore_runtime_pm();
>   		return false;
>   	}
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-09-05 16:01:04)
> 
> On 05/09/2018 10:07, Chris Wilson wrote:
> > We report the failure from igt_setup_runtime_pm() so that the caller can
> > decide how they may proceed, so replace the hard assert with the error
> > propagation.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Imre Deak <imre.deak@intel.com>
> > ---
> >   lib/igt_pm.c | 15 ++++++++++-----
> >   1 file changed, 10 insertions(+), 5 deletions(-)
> > 
> > diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> > index 615463a08..49027238b 100644
> > --- a/lib/igt_pm.c
> > +++ b/lib/igt_pm.c
> > @@ -511,12 +511,16 @@ bool igt_setup_runtime_pm(void)
> >   
> >       igt_pm_enable_audio_runtime_pm();
> >   
> > -     /* Our implementation uses autosuspend. Try to set it to 0ms so the test
> > -      * suite goes faster and we have a higher probability of triggering race
> > -      * conditions. */
> > +     /*
> > +      * Our implementation uses autosuspend. Try to set it to 0ms so the
> > +      * test suite goes faster and we have a higher probability of
> > +      * triggering race conditions.
> > +      */
> >       fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR);
> > -     igt_assert_f(fd >= 0,
> > -                  "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
> > +     if (fd < 0) {
> > +             igt_pm_audio_restore_runtime_pm();
> > +             return false;
> 
> Worth robustifying with an igt_assert_eq(errno, ENOENT) ?

You are just dying to debug all the transient ENOMEM and EMFILE aren't
you! :)
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Patchwork]

== Series Details ==

Series: lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel
URL   : https://patchwork.freedesktop.org/series/49169/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4627_full -> IGTPW_1788_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1788_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1788_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49169/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1788_full:

  === IGT changes ===

    ==== Warnings ====

    igt@perf_pmu@rc6:
      shard-kbl:          PASS -> SKIP

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1788_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-hsw:          PASS -> INCOMPLETE (fdo#106886, fdo#103540)

    igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-a:
      shard-snb:          PASS -> INCOMPLETE (fdo#105411)

    igt@kms_cursor_legacy@2x-long-nonblocking-modeset-vs-cursor-atomic:
      shard-glk:          NOTRUN -> FAIL (fdo#106509, fdo#107409)

    igt@kms_flip@2x-flip-vs-expired-vblank:
      shard-glk:          PASS -> FAIL (fdo#105363)

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@testdisplay:
      shard-glk:          PASS -> INCOMPLETE (fdo#107093, k.org#198133, fdo#103359)

    
    ==== Possible fixes ====

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749) -> PASS

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          FAIL (fdo#103166) -> PASS

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@perf@buffer-fill:
      shard-kbl:          INCOMPLETE (fdo#103665) -> PASS

    igt@prime_vgem@basic-write:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#106509 https://bugs.freedesktop.org/show_bug.cgi?id=106509
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107093 https://bugs.freedesktop.org/show_bug.cgi?id=107093
  fdo#107409 https://bugs.freedesktop.org/show_bug.cgi?id=107409
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4627 -> IGTPW_1788
    * Linux: CI_DRM_4767 -> CI_DRM_4770

  CI_DRM_4767: e9b69bafd3c2c13a8b9fa8e7a410f5d5ef32e328 @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4770: 0c3535cf60140d017a5df73d84d06e8b1a5b5d3b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1788: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1788/
  IGT_4627: e0c3033a57d85c0d2eb33af0451afa16edc79f10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1788/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Tvrtko Ursulin]

On 05/09/2018 16:13, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-09-05 16:01:04)
>>
>> On 05/09/2018 10:07, Chris Wilson wrote:
>>> We report the failure from igt_setup_runtime_pm() so that the caller can
>>> decide how they may proceed, so replace the hard assert with the error
>>> propagation.
>>>
>>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>> Cc: Imre Deak <imre.deak@intel.com>
>>> ---
>>>    lib/igt_pm.c | 15 ++++++++++-----
>>>    1 file changed, 10 insertions(+), 5 deletions(-)
>>>
>>> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
>>> index 615463a08..49027238b 100644
>>> --- a/lib/igt_pm.c
>>> +++ b/lib/igt_pm.c
>>> @@ -511,12 +511,16 @@ bool igt_setup_runtime_pm(void)
>>>    
>>>        igt_pm_enable_audio_runtime_pm();
>>>    
>>> -     /* Our implementation uses autosuspend. Try to set it to 0ms so the test
>>> -      * suite goes faster and we have a higher probability of triggering race
>>> -      * conditions. */
>>> +     /*
>>> +      * Our implementation uses autosuspend. Try to set it to 0ms so the
>>> +      * test suite goes faster and we have a higher probability of
>>> +      * triggering race conditions.
>>> +      */
>>>        fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR);
>>> -     igt_assert_f(fd >= 0,
>>> -                  "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
>>> +     if (fd < 0) {
>>> +             igt_pm_audio_restore_runtime_pm();
>>> +             return false;
>>
>> Worth robustifying with an igt_assert_eq(errno, ENOENT) ?
> 
> You are just dying to debug all the transient ENOMEM and EMFILE aren't
> you! :)

Out of memory or file descriptors during test start really? We are in 
terrible state then..

Regards,

Tvrtko
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm: Fail gracefully if CONFIG_PM is not built into the kernel

[Chris Wilson]

Quoting Tvrtko Ursulin (2018-09-06 09:51:00)
> 
> On 05/09/2018 16:13, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-09-05 16:01:04)
> >>
> >> On 05/09/2018 10:07, Chris Wilson wrote:
> >>> We report the failure from igt_setup_runtime_pm() so that the caller can
> >>> decide how they may proceed, so replace the hard assert with the error
> >>> propagation.
> >>>
> >>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> >>> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >>> Cc: Imre Deak <imre.deak@intel.com>
> >>> ---
> >>>    lib/igt_pm.c | 15 ++++++++++-----
> >>>    1 file changed, 10 insertions(+), 5 deletions(-)
> >>>
> >>> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> >>> index 615463a08..49027238b 100644
> >>> --- a/lib/igt_pm.c
> >>> +++ b/lib/igt_pm.c
> >>> @@ -511,12 +511,16 @@ bool igt_setup_runtime_pm(void)
> >>>    
> >>>        igt_pm_enable_audio_runtime_pm();
> >>>    
> >>> -     /* Our implementation uses autosuspend. Try to set it to 0ms so the test
> >>> -      * suite goes faster and we have a higher probability of triggering race
> >>> -      * conditions. */
> >>> +     /*
> >>> +      * Our implementation uses autosuspend. Try to set it to 0ms so the
> >>> +      * test suite goes faster and we have a higher probability of
> >>> +      * triggering race conditions.
> >>> +      */
> >>>        fd = open(POWER_DIR "/autosuspend_delay_ms", O_RDWR);
> >>> -     igt_assert_f(fd >= 0,
> >>> -                  "Can't open " POWER_DIR "/autosuspend_delay_ms\n");
> >>> +     if (fd < 0) {
> >>> +             igt_pm_audio_restore_runtime_pm();
> >>> +             return false;
> >>
> >> Worth robustifying with an igt_assert_eq(errno, ENOENT) ?
> > 
> > You are just dying to debug all the transient ENOMEM and EMFILE aren't
> > you! :)
> 
> Out of memory or file descriptors during test start really? We are in 
> terrible state then..

Definitely don't want to run the test under those conditions, right. And
I certainly don't want a misleading failure report as to why an
unrelated test failed. Having the skip highlighted is enough without
causing a freakout. And as always if it is reproducible, it can jolly
well get its own test.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev