* [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms
@ 2018-09-05 10:00 Imre Deak
2018-09-05 10:26 ` Ville Syrjälä
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Imre Deak @ 2018-09-05 10:00 UTC (permalink / raw)
To: intel-gfx; +Cc: Diego Viola, stable
During IPS disabling the current 42ms timeout value leads to occasional
timeouts, increase it to 100ms which seems to get rid of the problem.
References: https://bugs.freedesktop.org/show_bug.cgi?id=107494
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107562
Reported-by: Diego Viola <diego.viola@gmail.com>
Tested-by: Diego Viola <diego.viola@gmail.com>
Cc: Diego Viola <diego.viola@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Imre Deak <imre.deak@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index a85a83f31979..1bd14c61dab5 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -5082,10 +5082,14 @@ void hsw_disable_ips(const struct intel_crtc_state *crtc_state)
mutex_lock(&dev_priv->pcu_lock);
WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0));
mutex_unlock(&dev_priv->pcu_lock);
- /* wait for pcode to finish disabling IPS, which may take up to 42ms */
+ /*
+ * Wait for PCODE to finish disabling IPS. The BSpec specified
+ * 42ms timeout value leads to occasional timeouts so use 100ms
+ * instead.
+ */
if (intel_wait_for_register(dev_priv,
IPS_CTL, IPS_ENABLE, 0,
- 42))
+ 100))
DRM_ERROR("Timed out waiting for IPS disable\n");
} else {
I915_WRITE(IPS_CTL, 0);
--
2.13.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms
2018-09-05 10:00 [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms Imre Deak
@ 2018-09-05 10:26 ` Ville Syrjälä
2018-09-05 10:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-05 12:44 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2018-09-05 10:26 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, stable, Diego Viola
On Wed, Sep 05, 2018 at 01:00:05PM +0300, Imre Deak wrote:
> During IPS disabling the current 42ms timeout value leads to occasional
> timeouts, increase it to 100ms which seems to get rid of the problem.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=107494
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107562
> Reported-by: Diego Viola <diego.viola@gmail.com>
> Tested-by: Diego Viola <diego.viola@gmail.com>
> Cc: Diego Viola <diego.viola@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrj�l� <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a85a83f31979..1bd14c61dab5 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5082,10 +5082,14 @@ void hsw_disable_ips(const struct intel_crtc_state *crtc_state)
> mutex_lock(&dev_priv->pcu_lock);
> WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0));
> mutex_unlock(&dev_priv->pcu_lock);
> - /* wait for pcode to finish disabling IPS, which may take up to 42ms */
> + /*
> + * Wait for PCODE to finish disabling IPS. The BSpec specified
> + * 42ms timeout value leads to occasional timeouts so use 100ms
> + * instead.
> + */
> if (intel_wait_for_register(dev_priv,
> IPS_CTL, IPS_ENABLE, 0,
> - 42))
> + 100))
> DRM_ERROR("Timed out waiting for IPS disable\n");
> } else {
> I915_WRITE(IPS_CTL, 0);
> --
> 2.13.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrj�l�
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms
@ 2018-09-05 10:26 ` Ville Syrjälä
0 siblings, 0 replies; 6+ messages in thread
From: Ville Syrjälä @ 2018-09-05 10:26 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx, stable, Diego Viola
On Wed, Sep 05, 2018 at 01:00:05PM +0300, Imre Deak wrote:
> During IPS disabling the current 42ms timeout value leads to occasional
> timeouts, increase it to 100ms which seems to get rid of the problem.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=107494
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107562
> Reported-by: Diego Viola <diego.viola@gmail.com>
> Tested-by: Diego Viola <diego.viola@gmail.com>
> Cc: Diego Viola <diego.viola@gmail.com>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Imre Deak <imre.deak@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index a85a83f31979..1bd14c61dab5 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -5082,10 +5082,14 @@ void hsw_disable_ips(const struct intel_crtc_state *crtc_state)
> mutex_lock(&dev_priv->pcu_lock);
> WARN_ON(sandybridge_pcode_write(dev_priv, DISPLAY_IPS_CONTROL, 0));
> mutex_unlock(&dev_priv->pcu_lock);
> - /* wait for pcode to finish disabling IPS, which may take up to 42ms */
> + /*
> + * Wait for PCODE to finish disabling IPS. The BSpec specified
> + * 42ms timeout value leads to occasional timeouts so use 100ms
> + * instead.
> + */
> if (intel_wait_for_register(dev_priv,
> IPS_CTL, IPS_ENABLE, 0,
> - 42))
> + 100))
> DRM_ERROR("Timed out waiting for IPS disable\n");
> } else {
> I915_WRITE(IPS_CTL, 0);
> --
> 2.13.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/bdw: Increase IPS disable timeout to 100ms
2018-09-05 10:00 [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms Imre Deak
2018-09-05 10:26 ` Ville Syrjälä
@ 2018-09-05 10:50 ` Patchwork
2018-09-05 12:44 ` ✓ Fi.CI.IGT: " Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-09-05 10:50 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bdw: Increase IPS disable timeout to 100ms
URL : https://patchwork.freedesktop.org/series/49175/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4770 -> Patchwork_10091 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10091 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10091, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49175/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10091:
=== IGT changes ===
==== Warnings ====
igt@pm_rpm@module-reload:
fi-hsw-4770r: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10091 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-skl-caroline: NOTRUN -> INCOMPLETE (fdo#104108, fdo#107556)
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191) +1
igt@kms_psr@primary_page_flip:
fi-icl-u: NOTRUN -> FAIL (fdo#107383) +3
==== Possible fixes ====
igt@drv_module_reload@basic-reload-inject:
fi-hsw-4770r: DMESG-WARN (fdo#107425) -> PASS
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: DMESG-WARN (fdo#107139, fdo#105128) -> PASS
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: FAIL (fdo#104008) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107383 https://bugs.freedesktop.org/show_bug.cgi?id=107383
fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (50 -> 48) ==
Additional (4): fi-glk-j4005 fi-skl-caroline fi-icl-u fi-elk-e7500
Missing (6): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4770 -> Patchwork_10091
CI_DRM_4770: 0c3535cf60140d017a5df73d84d06e8b1a5b5d3b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4627: e0c3033a57d85c0d2eb33af0451afa16edc79f10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10091: 6745896fef66c4282e347efd2270d6c0d5739ed3 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
6745896fef66 drm/i915/bdw: Increase IPS disable timeout to 100ms
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10091/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/bdw: Increase IPS disable timeout to 100ms
2018-09-05 10:00 [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms Imre Deak
2018-09-05 10:26 ` Ville Syrjälä
2018-09-05 10:50 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-05 12:44 ` Patchwork
2018-09-05 17:27 ` Imre Deak
2 siblings, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-09-05 12:44 UTC (permalink / raw)
To: Imre Deak; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bdw: Increase IPS disable timeout to 100ms
URL : https://patchwork.freedesktop.org/series/49175/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4770_full -> Patchwork_10091_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10091_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_big:
shard-hsw: PASS -> INCOMPLETE (fdo#103540)
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_flip@2x-flip-vs-expired-vblank:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
shard-glk: PASS -> FAIL (fdo#103167)
igt@perf@blocking:
shard-hsw: PASS -> FAIL (fdo#102252)
==== Possible fixes ====
igt@drv_suspend@shrink:
shard-snb: FAIL (fdo#106886) -> PASS
igt@kms_busy@extended-modeset-hang-newfb-render-b:
shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
igt@kms_flip@flip-vs-expired-vblank:
shard-glk: FAIL (fdo#105363) -> PASS
fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4770 -> Patchwork_10091
CI_DRM_4770: 0c3535cf60140d017a5df73d84d06e8b1a5b5d3b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4627: e0c3033a57d85c0d2eb33af0451afa16edc79f10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10091: 6745896fef66c4282e347efd2270d6c0d5739ed3 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10091/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: ✓ Fi.CI.IGT: success for drm/i915/bdw: Increase IPS disable timeout to 100ms
2018-09-05 12:44 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-05 17:27 ` Imre Deak
0 siblings, 0 replies; 6+ messages in thread
From: Imre Deak @ 2018-09-05 17:27 UTC (permalink / raw)
To: intel-gfx, Ville Syrjälä
On Wed, Sep 05, 2018 at 12:44:37PM +0000, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/bdw: Increase IPS disable timeout to 100ms
> URL : https://patchwork.freedesktop.org/series/49175/
> State : success
Pushed, thanks for the review.
>
> == Summary ==
>
> = CI Bug Log - changes from CI_DRM_4770_full -> Patchwork_10091_full =
>
> == Summary - SUCCESS ==
>
> No regressions found.
>
>
>
> == Known issues ==
>
> Here are the changes found in Patchwork_10091_full that come from known issues:
>
> === IGT changes ===
>
> ==== Issues hit ====
>
> igt@gem_exec_big:
> shard-hsw: PASS -> INCOMPLETE (fdo#103540)
>
> igt@kms_cursor_legacy@cursor-vs-flip-toggle:
> shard-hsw: PASS -> FAIL (fdo#103355)
>
> igt@kms_flip@2x-flip-vs-expired-vblank:
> shard-glk: PASS -> FAIL (fdo#105363)
>
> igt@kms_frontbuffer_tracking@fbc-rgb565-draw-mmap-gtt:
> shard-glk: PASS -> FAIL (fdo#103167)
>
> igt@perf@blocking:
> shard-hsw: PASS -> FAIL (fdo#102252)
>
>
> ==== Possible fixes ====
>
> igt@drv_suspend@shrink:
> shard-snb: FAIL (fdo#106886) -> PASS
>
> igt@kms_busy@extended-modeset-hang-newfb-render-b:
> shard-glk: INCOMPLETE (k.org#198133, fdo#103359) -> PASS
>
> igt@kms_flip@flip-vs-expired-vblank:
> shard-glk: FAIL (fdo#105363) -> PASS
>
>
> fdo#102252 https://bugs.freedesktop.org/show_bug.cgi?id=102252
> fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
> fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
> fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
> fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
> fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
> fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
> k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
>
>
> == Participating hosts (5 -> 5) ==
>
> No changes in participating hosts
>
>
> == Build changes ==
>
> * Linux: CI_DRM_4770 -> Patchwork_10091
>
> CI_DRM_4770: 0c3535cf60140d017a5df73d84d06e8b1a5b5d3b @ git://anongit.freedesktop.org/gfx-ci/linux
> IGT_4627: e0c3033a57d85c0d2eb33af0451afa16edc79f10 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
> Patchwork_10091: 6745896fef66c4282e347efd2270d6c0d5739ed3 @ git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10091/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-05 17:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 10:00 [PATCH] drm/i915/bdw: Increase IPS disable timeout to 100ms Imre Deak
2018-09-05 10:26 ` [Intel-gfx] " Ville Syrjälä
2018-09-05 10:26 ` Ville Syrjälä
2018-09-05 10:50 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-05 12:44 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-05 17:27 ` Imre Deak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.