* [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal
@ 2018-09-05 15:19 Eduardo Habkost
2018-09-11 14:33 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Eduardo Habkost @ 2018-09-05 15:19 UTC (permalink / raw)
To: qemu-devel
Cc: Philippe Mathieu-Daudé, Danilo C. L. de Paula, Richard Henderson
Currently there's no way to make configure not try to use the
system-provided capstone library using pkgconfig.
Add support to --enable-capstone=internal option to make QEMU not
use the system-provided library automatically.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
configure | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/configure b/configure
index 58862d2ae8..34ed00f6d9 100755
--- a/configure
+++ b/configure
@@ -1431,6 +1431,8 @@ for opt do
;;
--enable-capstone=system) capstone="system"
;;
+ --enable-capstone=internal) capstone="internal"
+ ;;
--with-git=*) git="$optarg"
;;
--enable-git-update) git_update=yes
@@ -1635,6 +1637,9 @@ Advanced options (experts only):
xen pv domain builder
--enable-debug-stack-usage
track the maximum stack usage of stacks created by qemu_alloc_stack
+ --enable-capstone[=LOCATION]
+ Where to look for capstone library.
+ Supported options: internal, git, system
Optional features, enabled with --enable-FEATURE and
disabled with --disable-FEATURE, default is enabled if available:
--
2.18.0.rc1.1.g3f1ff2140
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal
2018-09-05 15:19 [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal Eduardo Habkost
@ 2018-09-11 14:33 ` Richard Henderson
2018-09-11 15:31 ` Eduardo Habkost
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2018-09-11 14:33 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel
Cc: Philippe Mathieu-Daudé, Danilo C. L. de Paula
On 09/05/2018 08:19 AM, Eduardo Habkost wrote:
> Currently there's no way to make configure not try to use the
> system-provided capstone library using pkgconfig.
Certainly there is.
>
> Add support to --enable-capstone=internal option to make QEMU not
> use the system-provided library automatically.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> configure | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/configure b/configure
> index 58862d2ae8..34ed00f6d9 100755
> --- a/configure
> +++ b/configure
> @@ -1431,6 +1431,8 @@ for opt do
> + --enable-capstone[=LOCATION]
> + Where to look for capstone library.
> + Supported options: internal, git, system
That's what "git" means here.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal
2018-09-11 14:33 ` Richard Henderson
@ 2018-09-11 15:31 ` Eduardo Habkost
0 siblings, 0 replies; 3+ messages in thread
From: Eduardo Habkost @ 2018-09-11 15:31 UTC (permalink / raw)
To: Richard Henderson
Cc: qemu-devel, Philippe Mathieu-Daudé, Danilo C. L. de Paula
On Tue, Sep 11, 2018 at 07:33:08AM -0700, Richard Henderson wrote:
> On 09/05/2018 08:19 AM, Eduardo Habkost wrote:
> > Currently there's no way to make configure not try to use the
> > system-provided capstone library using pkgconfig.
>
> Certainly there is.
>
> >
> > Add support to --enable-capstone=internal option to make QEMU not
> > use the system-provided library automatically.
Oops, the commit message is inaccurate: we can prevent
./configure from trying the system library, but there's no way to
make it avoid using git submodule at the same time.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > configure | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/configure b/configure
> > index 58862d2ae8..34ed00f6d9 100755
> > --- a/configure
> > +++ b/configure
> > @@ -1431,6 +1431,8 @@ for opt do
> > + --enable-capstone[=LOCATION]
> > + Where to look for capstone library.
> > + Supported options: internal, git, system
>
> That's what "git" means here.
"git" makes ./configure add capstone to GIT_SUBMODULES, and I'm
pretty sure we don't want that if we're not building from a git
tree.
--
Eduardo
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-11 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 15:19 [Qemu-devel] [PATCH] configure: Support --enable-capstone=internal Eduardo Habkost
2018-09-11 14:33 ` Richard Henderson
2018-09-11 15:31 ` Eduardo Habkost
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.