All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: enable CMT/TMU support for Renesas SoC
@ 2018-08-31 19:54 ` Sergei Shtylyov
  0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-08-31 19:54 UTC (permalink / raw)
  To: Catalin Marinas, Will Deacon, linux-arm-kernel
  Cc: linux-renesas-soc, Simon Horman

Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
building them in Kconfig.platforms (as they don't normally have the prompts
in Kconfig).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the ARM64 repo's 'for-next/core' branch.

 arch/arm64/Kconfig.platforms |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/arch/arm64/Kconfig.platforms
===================================================================
--- linux.orig/arch/arm64/Kconfig.platforms
+++ linux/arch/arm64/Kconfig.platforms
@@ -175,6 +175,8 @@ config ARCH_RENESAS
 	select PM_GENERIC_DOMAINS
 	select RENESAS_IRQC
 	select SOC_BUS
+	select SYS_SUPPORTS_SH_CMT
+	select SYS_SUPPORTS_SH_TMU
 	help
 	  This enables support for the ARMv8 based Renesas SoCs.
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: enable CMT/TMU support for Renesas SoC
@ 2018-08-31 19:54 ` Sergei Shtylyov
  0 siblings, 0 replies; 8+ messages in thread
From: Sergei Shtylyov @ 2018-08-31 19:54 UTC (permalink / raw)
  To: linux-arm-kernel

Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
building them in Kconfig.platforms (as they don't normally have the prompts
in Kconfig).

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the ARM64 repo's 'for-next/core' branch.

 arch/arm64/Kconfig.platforms |    2 ++
 1 file changed, 2 insertions(+)

Index: linux/arch/arm64/Kconfig.platforms
===================================================================
--- linux.orig/arch/arm64/Kconfig.platforms
+++ linux/arch/arm64/Kconfig.platforms
@@ -175,6 +175,8 @@ config ARCH_RENESAS
 	select PM_GENERIC_DOMAINS
 	select RENESAS_IRQC
 	select SOC_BUS
+	select SYS_SUPPORTS_SH_CMT
+	select SYS_SUPPORTS_SH_TMU
 	help
 	  This enables support for the ARMv8 based Renesas SoCs.
 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable CMT/TMU support for Renesas SoC
  2018-08-31 19:54 ` Sergei Shtylyov
@ 2018-09-03  7:17   ` Simon Horman
  -1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-09-03  7:17 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-renesas-soc

On Fri, Aug 31, 2018 at 10:54:42PM +0300, Sergei Shtylyov wrote:
> Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> building them in Kconfig.platforms (as they don't normally have the prompts
> in Kconfig).
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thank Sergei,

this looks fine to me and I'd be happy to take it through the renesas tree,
after others have been given time for review, if that is the appropriate
path for this patch.

> 
> ---
> The patch is against the ARM64 repo's 'for-next/core' branch.
> 
>  arch/arm64/Kconfig.platforms |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux/arch/arm64/Kconfig.platforms
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig.platforms
> +++ linux/arch/arm64/Kconfig.platforms
> @@ -175,6 +175,8 @@ config ARCH_RENESAS
>  	select PM_GENERIC_DOMAINS
>  	select RENESAS_IRQC
>  	select SOC_BUS
> +	select SYS_SUPPORTS_SH_CMT
> +	select SYS_SUPPORTS_SH_TMU
>  	help
>  	  This enables support for the ARMv8 based Renesas SoCs.
>  
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: enable CMT/TMU support for Renesas SoC
@ 2018-09-03  7:17   ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-09-03  7:17 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Aug 31, 2018 at 10:54:42PM +0300, Sergei Shtylyov wrote:
> Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> building them in Kconfig.platforms (as they don't normally have the prompts
> in Kconfig).
> 
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

Thank Sergei,

this looks fine to me and I'd be happy to take it through the renesas tree,
after others have been given time for review, if that is the appropriate
path for this patch.

> 
> ---
> The patch is against the ARM64 repo's 'for-next/core' branch.
> 
>  arch/arm64/Kconfig.platforms |    2 ++
>  1 file changed, 2 insertions(+)
> 
> Index: linux/arch/arm64/Kconfig.platforms
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig.platforms
> +++ linux/arch/arm64/Kconfig.platforms
> @@ -175,6 +175,8 @@ config ARCH_RENESAS
>  	select PM_GENERIC_DOMAINS
>  	select RENESAS_IRQC
>  	select SOC_BUS
> +	select SYS_SUPPORTS_SH_CMT
> +	select SYS_SUPPORTS_SH_TMU
>  	help
>  	  This enables support for the ARMv8 based Renesas SoCs.
>  
> 

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable CMT/TMU support for Renesas SoC
  2018-09-03  7:17   ` Simon Horman
@ 2018-09-06  9:28     ` Simon Horman
  -1 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-09-06  9:28 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Catalin Marinas, Will Deacon, linux-arm-kernel, linux-renesas-soc

On Mon, Sep 03, 2018 at 09:17:15AM +0200, Simon Horman wrote:
> On Fri, Aug 31, 2018 at 10:54:42PM +0300, Sergei Shtylyov wrote:
> > Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> > building them in Kconfig.platforms (as they don't normally have the prompts
> > in Kconfig).
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thank Sergei,
> 
> this looks fine to me and I'd be happy to take it through the renesas tree,
> after others have been given time for review, if that is the appropriate
> path for this patch.

Thanks again, I have applied this to the renesas tree for v4.20.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: enable CMT/TMU support for Renesas SoC
@ 2018-09-06  9:28     ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2018-09-06  9:28 UTC (permalink / raw)
  To: linux-arm-kernel

On Mon, Sep 03, 2018 at 09:17:15AM +0200, Simon Horman wrote:
> On Fri, Aug 31, 2018 at 10:54:42PM +0300, Sergei Shtylyov wrote:
> > Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> > building them in Kconfig.platforms (as they don't normally have the prompts
> > in Kconfig).
> > 
> > Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> 
> Thank Sergei,
> 
> this looks fine to me and I'd be happy to take it through the renesas tree,
> after others have been given time for review, if that is the appropriate
> path for this patch.

Thanks again, I have applied this to the renesas tree for v4.20.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH] arm64: enable CMT/TMU support for Renesas SoC
  2018-08-31 19:54 ` Sergei Shtylyov
@ 2018-09-06  9:47   ` Geert Uytterhoeven
  -1 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-09-06  9:47 UTC (permalink / raw)
  To: Sergei Shtylyov
  Cc: Catalin Marinas, Will Deacon, Linux ARM, Linux-Renesas, Simon Horman

Hi Sergei,

On Fri, Aug 31, 2018 at 9:54 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> building them in Kconfig.platforms (as they don't normally have the prompts
> in Kconfig).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against the ARM64 repo's 'for-next/core' branch.
>
>  arch/arm64/Kconfig.platforms |    2 ++
>  1 file changed, 2 insertions(+)
>
> Index: linux/arch/arm64/Kconfig.platforms
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig.platforms
> +++ linux/arch/arm64/Kconfig.platforms
> @@ -175,6 +175,8 @@ config ARCH_RENESAS
>         select PM_GENERIC_DOMAINS
>         select RENESAS_IRQC
>         select SOC_BUS
> +       select SYS_SUPPORTS_SH_CMT
> +       select SYS_SUPPORTS_SH_TMU

Perhaps the CONFIG_SH_TIMER_CMT and _TMU logic should be reworked instead,
to allow the user to choose if he wants to enable the driver or not on platforms
that do not select these two symbls?

Hardcoding this to y depending on SYS_SUPPORTS_SH_* may be needed on
SuperH and older Renesas ARM SoCs, but R-Car Gen2+ and RZ/G now use the
ARM architectured timer by default.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH] arm64: enable CMT/TMU support for Renesas SoC
@ 2018-09-06  9:47   ` Geert Uytterhoeven
  0 siblings, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2018-09-06  9:47 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Sergei,

On Fri, Aug 31, 2018 at 9:54 PM Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Renesas R-Car gen3 SoCs have both CMT and TMU timers, so we have to enable
> building them in Kconfig.platforms (as they don't normally have the prompts
> in Kconfig).
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> The patch is against the ARM64 repo's 'for-next/core' branch.
>
>  arch/arm64/Kconfig.platforms |    2 ++
>  1 file changed, 2 insertions(+)
>
> Index: linux/arch/arm64/Kconfig.platforms
> ===================================================================
> --- linux.orig/arch/arm64/Kconfig.platforms
> +++ linux/arch/arm64/Kconfig.platforms
> @@ -175,6 +175,8 @@ config ARCH_RENESAS
>         select PM_GENERIC_DOMAINS
>         select RENESAS_IRQC
>         select SOC_BUS
> +       select SYS_SUPPORTS_SH_CMT
> +       select SYS_SUPPORTS_SH_TMU

Perhaps the CONFIG_SH_TIMER_CMT and _TMU logic should be reworked instead,
to allow the user to choose if he wants to enable the driver or not on platforms
that do not select these two symbls?

Hardcoding this to y depending on SYS_SUPPORTS_SH_* may be needed on
SuperH and older Renesas ARM SoCs, but R-Car Gen2+ and RZ/G now use the
ARM architectured timer by default.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2018-09-06 14:21 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-31 19:54 [PATCH] arm64: enable CMT/TMU support for Renesas SoC Sergei Shtylyov
2018-08-31 19:54 ` Sergei Shtylyov
2018-09-03  7:17 ` Simon Horman
2018-09-03  7:17   ` Simon Horman
2018-09-06  9:28   ` Simon Horman
2018-09-06  9:28     ` Simon Horman
2018-09-06  9:47 ` Geert Uytterhoeven
2018-09-06  9:47   ` Geert Uytterhoeven

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.