From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> To: Bjorn Helgaas <helgaas@kernel.org> Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, devicetree@vger.kernel.org, Masami Hiramatsu <masami.hiramatsu@linaro.org>, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Jassi Brar <jaswinder.singh@linaro.org>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/2] dt-bindings: pci: add UniPhier PCIe host controller description Date: Thu, 06 Sep 2018 10:38:08 +0900 [thread overview] Message-ID: <20180906103808.2529.4A936039@socionext.com> (raw) In-Reply-To: <20180905172118.GN107892@bhelgaas-glaptop.roam.corp.google.com> Hi Bjorn, Thank you for reviewing. On Wed, 5 Sep 2018 12:21:18 -0500 <helgaas@kernel.org> wrote: > > Please follow the capitalization convention, i.e., > > $ git log --oneline --no-merges Documentaon/devicetree/bindings/pci/ | grep -i pci > 82dfbd27c837 dt-bindings: PCI: cadence: Add DT bindings for optional PHYs > 92f9ccca4c08 PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver DT bindings > 71918e24cb49 dt-bindings: PCI: designware: Add support for EP in DesignWare driver > 467c7a737642 dt-bindings: PCI: designware: Example update > 1dca7a636933 dt-bindings: PCI: rockchip: Add DT bindings for Rockchip PCIe EP driver > 2ca25bd7472f dt-bindings: PCI: rockchip: Rename rockchip-pcie.txt to rockchip-pcie-host.txt > > On Wed, Sep 05, 2018 at 11:32:10AM +0900, Kunihiko Hayashi wrote: > > Add DT bindings for PCIe controller implemented in UniPhier SoCs when > > configured in Root Complex (host) mode. This controller is based on > > the Designware PCIe Core. > > s/Designware/DesignWare/ > s/Core/core/ Okay, I'll fix capitalization conventions in all the descriptions according to the previous commits. > > > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > > --- > > .../devicetree/bindings/pci/uniphier-pcie.txt | 78 ++++++++++++++++++++++ > > 1 file changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > > > diff --git a/Documentation/devicetree/bindings/pci/uniphier-pcie.txt b/Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > new file mode 100644 > > index 0000000..ea63f78 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > @@ -0,0 +1,78 @@ > > +Socionext UniPhier PCI-express host controller bindings > > s/PCI-express/PCIe/ (also in other occurrences below) > > > + > > +This describes the devicetree bindings for PCI-express host controller > > +implemented on Socionext UniPhier SoCs. > > + > > +UniPhier PCI-express host controller is based on the Synopsys DesignWare > > +PCI core. It shares common functions with the PCIe DesignWare core driver > > +and inherits common properties defined in > > +Documentation/devicetree/bindings/pci/designware-pcie.txt. Indeed, there are descriptions of inconsistency. I'll fix them. Thank you, --- Best Regards, Kunihiko Hayashi
WARNING: multiple messages have this Message-ID (diff)
From: hayashi.kunihiko@socionext.com (Kunihiko Hayashi) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] dt-bindings: pci: add UniPhier PCIe host controller description Date: Thu, 06 Sep 2018 10:38:08 +0900 [thread overview] Message-ID: <20180906103808.2529.4A936039@socionext.com> (raw) In-Reply-To: <20180905172118.GN107892@bhelgaas-glaptop.roam.corp.google.com> Hi Bjorn, Thank you for reviewing. On Wed, 5 Sep 2018 12:21:18 -0500 <helgaas@kernel.org> wrote: > > Please follow the capitalization convention, i.e., > > $ git log --oneline --no-merges Documentaon/devicetree/bindings/pci/ | grep -i pci > 82dfbd27c837 dt-bindings: PCI: cadence: Add DT bindings for optional PHYs > 92f9ccca4c08 PCI: mobiveil: Add Mobiveil PCIe Host Bridge IP driver DT bindings > 71918e24cb49 dt-bindings: PCI: designware: Add support for EP in DesignWare driver > 467c7a737642 dt-bindings: PCI: designware: Example update > 1dca7a636933 dt-bindings: PCI: rockchip: Add DT bindings for Rockchip PCIe EP driver > 2ca25bd7472f dt-bindings: PCI: rockchip: Rename rockchip-pcie.txt to rockchip-pcie-host.txt > > On Wed, Sep 05, 2018 at 11:32:10AM +0900, Kunihiko Hayashi wrote: > > Add DT bindings for PCIe controller implemented in UniPhier SoCs when > > configured in Root Complex (host) mode. This controller is based on > > the Designware PCIe Core. > > s/Designware/DesignWare/ > s/Core/core/ Okay, I'll fix capitalization conventions in all the descriptions according to the previous commits. > > > > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com> > > --- > > .../devicetree/bindings/pci/uniphier-pcie.txt | 78 ++++++++++++++++++++++ > > 1 file changed, 78 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > > > diff --git a/Documentation/devicetree/bindings/pci/uniphier-pcie.txt b/Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > new file mode 100644 > > index 0000000..ea63f78 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/pci/uniphier-pcie.txt > > @@ -0,0 +1,78 @@ > > +Socionext UniPhier PCI-express host controller bindings > > s/PCI-express/PCIe/ (also in other occurrences below) > > > + > > +This describes the devicetree bindings for PCI-express host controller > > +implemented on Socionext UniPhier SoCs. > > + > > +UniPhier PCI-express host controller is based on the Synopsys DesignWare > > +PCI core. It shares common functions with the PCIe DesignWare core driver > > +and inherits common properties defined in > > +Documentation/devicetree/bindings/pci/designware-pcie.txt. Indeed, there are descriptions of inconsistency. I'll fix them. Thank you, --- Best Regards, Kunihiko Hayashi
next prev parent reply other threads:[~2018-09-06 1:38 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-05 2:32 [PATCH 0/2] add new UniPhier PCIe host driver Kunihiko Hayashi 2018-09-05 2:32 ` Kunihiko Hayashi 2018-09-05 2:32 ` Kunihiko Hayashi 2018-09-05 2:32 ` [PATCH 1/2] dt-bindings: pci: add UniPhier PCIe host controller description Kunihiko Hayashi 2018-09-05 2:32 ` Kunihiko Hayashi 2018-09-05 2:32 ` Kunihiko Hayashi 2018-09-05 17:21 ` Bjorn Helgaas 2018-09-05 17:21 ` Bjorn Helgaas 2018-09-05 17:21 ` Bjorn Helgaas 2018-09-06 1:38 ` Kunihiko Hayashi [this message] 2018-09-06 1:38 ` Kunihiko Hayashi 2018-09-05 2:32 ` [PATCH 2/2] pci: dwc: add UniPhier PCIe host controller support Kunihiko Hayashi 2018-09-05 2:32 ` Kunihiko Hayashi 2018-09-05 17:25 ` Bjorn Helgaas 2018-09-05 17:25 ` Bjorn Helgaas 2018-09-05 17:25 ` Bjorn Helgaas 2018-09-06 1:38 ` Kunihiko Hayashi 2018-09-06 1:38 ` Kunihiko Hayashi 2018-09-06 14:09 ` Bjorn Helgaas 2018-09-06 14:09 ` Bjorn Helgaas 2018-09-06 14:09 ` Bjorn Helgaas 2018-09-07 4:11 ` Kunihiko Hayashi 2018-09-07 4:11 ` Kunihiko Hayashi 2018-09-07 4:11 ` Kunihiko Hayashi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180906103808.2529.4A936039@socionext.com \ --to=hayashi.kunihiko@socionext.com \ --cc=bhelgaas@google.com \ --cc=devicetree@vger.kernel.org \ --cc=helgaas@kernel.org \ --cc=jaswinder.singh@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=lorenzo.pieralisi@arm.com \ --cc=mark.rutland@arm.com \ --cc=masami.hiramatsu@linaro.org \ --cc=robh+dt@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.