From: David Miller <davem@davemloft.net>
To: jacob.e.keller@intel.com
Cc: jeffrey.t.kirsher@intel.com, netdev@vger.kernel.org,
dongsheng.wang@hxt-semitech.com,
intel-wired-lan@lists.osuosl.org, aaron.f.brown@intel.com
Subject: Re: [net-next] i40e(vf): remove i40e_ethtool_stats.h header file
Date: Fri, 07 Sep 2018 15:02:02 -0700 (PDT) [thread overview]
Message-ID: <20180907.150202.635126554624052715.davem@davemloft.net> (raw)
In-Reply-To: <20180907215544.5957-1-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Fri, 7 Sep 2018 14:55:44 -0700
> Essentially reverts commit 8fd75c58a09a ("i40e: move ethtool
> stats boiler plate code to i40e_ethtool_stats.h", 2018-08-30), and
> additionally moves the similar code in i40evf into i40evf_ethtool.c.
>
> The code was intially moved from i40e_ethtool.c into i40e_ethtool_stats.h
> as a way of better logically organizing the code. This has two problems.
> First, we can't have an inline function with variadic arguments on all
> platforms. Second, it gave the appearance that we had plans to share
> code between the i40e and i40evf drivers, due to having a near copy of
> the contents in the i40evf/i40e_ethtool_stats.h file.
>
> Patches which actually attempt to combine or share code between the i40e
> and i40evf drivers have not materialized, and are likely a ways off.
>
> Rather than fixing the one function which causes build issues, just move
> this code back into the i40e_ethtool.c and i40evf_ethtool.c files. Note
> that we also change these functions back from static inlines to just
> statics, since they're no longer in a header file.
>
> We can revisit this if/when work is done to actually attempt to share
> code between drivers. Alternatively, this stats code could be made more
> generic so that it can be shared across drivers as part of ethtool
> kernel work.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Applied and after the build checks out will be pushed to net-next.
Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [net-next] i40e(vf): remove i40e_ethtool_stats.h header file
Date: Fri, 07 Sep 2018 15:02:02 -0700 (PDT) [thread overview]
Message-ID: <20180907.150202.635126554624052715.davem@davemloft.net> (raw)
In-Reply-To: <20180907215544.5957-1-jacob.e.keller@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
Date: Fri, 7 Sep 2018 14:55:44 -0700
> Essentially reverts commit 8fd75c58a09a ("i40e: move ethtool
> stats boiler plate code to i40e_ethtool_stats.h", 2018-08-30), and
> additionally moves the similar code in i40evf into i40evf_ethtool.c.
>
> The code was intially moved from i40e_ethtool.c into i40e_ethtool_stats.h
> as a way of better logically organizing the code. This has two problems.
> First, we can't have an inline function with variadic arguments on all
> platforms. Second, it gave the appearance that we had plans to share
> code between the i40e and i40evf drivers, due to having a near copy of
> the contents in the i40evf/i40e_ethtool_stats.h file.
>
> Patches which actually attempt to combine or share code between the i40e
> and i40evf drivers have not materialized, and are likely a ways off.
>
> Rather than fixing the one function which causes build issues, just move
> this code back into the i40e_ethtool.c and i40evf_ethtool.c files. Note
> that we also change these functions back from static inlines to just
> statics, since they're no longer in a header file.
>
> We can revisit this if/when work is done to actually attempt to share
> code between drivers. Alternatively, this stats code could be made more
> generic so that it can be shared across drivers as part of ethtool
> kernel work.
>
> Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Applied and after the build checks out will be pushed to net-next.
Thanks.
next prev parent reply other threads:[~2018-09-08 2:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 21:55 [net-next] i40e(vf): remove i40e_ethtool_stats.h header file Jacob Keller
2018-09-07 21:55 ` [Intel-wired-lan] " Jacob Keller
2018-09-07 22:02 ` David Miller [this message]
2018-09-07 22:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907.150202.635126554624052715.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=aaron.f.brown@intel.com \
--cc=dongsheng.wang@hxt-semitech.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.