* [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback
@ 2018-09-07 17:01 jun qian
2018-09-07 17:42 ` Jakub Kicinski
2018-09-08 5:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: jun qian @ 2018-09-07 17:01 UTC (permalink / raw)
To: Jakub Kicinski, Dirk van der Merwe, Daniel Borkmann, Quentin Monnet
Cc: oss-drivers, netdev, linux-kernel, jun qian
As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: jun qian <hangdianqj@163.com>
---
drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
index a8b9fbab5f73..084c983ec3c2 100644
--- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
+++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
@@ -2075,10 +2075,10 @@ static void nfp_ctrl_poll(unsigned long arg)
{
struct nfp_net_r_vector *r_vec = (void *)arg;
- spin_lock_bh(&r_vec->lock);
+ spin_lock(&r_vec->lock);
nfp_net_tx_complete(r_vec->tx_ring, 0);
__nfp_ctrl_tx_queued(r_vec);
- spin_unlock_bh(&r_vec->lock);
+ spin_unlock(&r_vec->lock);
nfp_ctrl_rx(r_vec);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback
2018-09-07 17:01 [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback jun qian
@ 2018-09-07 17:42 ` Jakub Kicinski
2018-09-08 5:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2018-09-07 17:42 UTC (permalink / raw)
To: jun qian
Cc: Dirk van der Merwe, Daniel Borkmann, Quentin Monnet, oss-drivers,
netdev, linux-kernel
On Fri, 7 Sep 2018 10:01:09 -0700, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
Acked-by: Jakub Kicinski <jakub.kicinski@netronome.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback
2018-09-07 17:01 [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback jun qian
2018-09-07 17:42 ` Jakub Kicinski
@ 2018-09-08 5:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-09-08 5:56 UTC (permalink / raw)
To: hangdianqj
Cc: jakub.kicinski, dirk.vandermerwe, daniel, quentin.monnet,
oss-drivers, netdev, linux-kernel
From: jun qian <hangdianqj@163.com>
Date: Fri, 7 Sep 2018 10:01:09 -0700
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
>
> Signed-off-by: jun qian <hangdianqj@163.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-08 5:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 17:01 [PATCH] nfp: replace spin_lock_bh with spin_lock in tasklet callback jun qian
2018-09-07 17:42 ` Jakub Kicinski
2018-09-08 5:56 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.