* [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask
@ 2018-09-07 12:40 Mahesh Kumar
2018-09-07 12:45 ` Chris Wilson
` (7 more replies)
0 siblings, 8 replies; 21+ messages in thread
From: Mahesh Kumar @ 2018-09-07 12:40 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
This cleanup patch makes changes to use for_each_pipe loop
during bit-mask assignment of allowed crtc with encoder.
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Mahesh Kumar <mahesh1.sh.kumar@gmail.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..692dcc6ede30 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
+ u8 i;
init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
@@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_encoder->type = INTEL_OUTPUT_DDI;
intel_encoder->power_domain = intel_port_to_power_domain(port);
intel_encoder->port = port;
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
intel_encoder->cloneable = 0;
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= (1 << i);
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 436c22de33b6..908af128d81d 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ u8 i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= (1 << i);
}
intel_encoder->cloneable = 0;
intel_encoder->port = port;
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index a2dab0b6bde6..0cbc83cdbd89 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ u8 i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= (1 << i);
}
intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
/*
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
@ 2018-09-07 12:45 ` Chris Wilson
2018-09-07 12:59 ` [PATCH v2] " Mahesh Kumar
2018-09-07 13:25 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev2) Patchwork
` (6 subsequent siblings)
7 siblings, 1 reply; 21+ messages in thread
From: Chris Wilson @ 2018-09-07 12:45 UTC (permalink / raw)
To: Mahesh Kumar, intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Quoting Mahesh Kumar (2018-09-07 13:40:35)
> This cleanup patch makes changes to use for_each_pipe loop
> during bit-mask assignment of allowed crtc with encoder.
mask |= BIT(i) ?
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 12:45 ` Chris Wilson
@ 2018-09-07 12:59 ` Mahesh Kumar
2018-09-07 13:04 ` Jani Nikula
0 siblings, 1 reply; 21+ messages in thread
From: Mahesh Kumar @ 2018-09-07 12:59 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
This cleanup patch makes changes to use for_each_pipe loop
during bit-mask assignment of allowed crtc with encoder.
changes:
- use BIT(i) macro instead of (1 << i) (Chris)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..88dfca245099 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
+ u8 i;
init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
@@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_encoder->type = INTEL_OUTPUT_DDI;
intel_encoder->power_domain = intel_port_to_power_domain(port);
intel_encoder->port = port;
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
intel_encoder->cloneable = 0;
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 436c22de33b6..1f954debdc55 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ u8 i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
}
intel_encoder->cloneable = 0;
intel_encoder->port = port;
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index a2dab0b6bde6..647e38de7980 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ u8 i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
}
intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
/*
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* Re: [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 12:59 ` [PATCH v2] " Mahesh Kumar
@ 2018-09-07 13:04 ` Jani Nikula
2018-09-07 13:11 ` Kumar, Mahesh
2018-09-07 14:49 ` [PATCH v2] " Ville Syrjälä
0 siblings, 2 replies; 21+ messages in thread
From: Jani Nikula @ 2018-09-07 13:04 UTC (permalink / raw)
To: Mahesh Kumar, intel-gfx; +Cc: Rodrigo Vivi
On Fri, 07 Sep 2018, Mahesh Kumar <mahesh1.kumar@intel.com> wrote:
> This cleanup patch makes changes to use for_each_pipe loop
> during bit-mask assignment of allowed crtc with encoder.
>
> changes:
> - use BIT(i) macro instead of (1 << i) (Chris)
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
> drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
> drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
> 3 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..88dfca245099 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct intel_encoder *intel_encoder;
> struct drm_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> + u8 i;
Please use int instead of u8 throughout. u8 only makes sense when you
actually need the specific size, or need to be concerned about the size.
BR,
Jani.
>
>
> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> intel_encoder->type = INTEL_OUTPUT_DDI;
> intel_encoder->power_domain = intel_port_to_power_domain(port);
> intel_encoder->port = port;
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
> + for_each_pipe(dev_priv, i)
> + intel_encoder->crtc_mask |= BIT(i);
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 436c22de33b6..1f954debdc55 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + u8 i;
> +
> + for_each_pipe(dev_priv, i)
> + intel_encoder->crtc_mask |= BIT(i);
> }
> intel_encoder->cloneable = 0;
> intel_encoder->port = port;
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index a2dab0b6bde6..647e38de7980 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + u8 i;
> +
> + for_each_pipe(dev_priv, i)
> + intel_encoder->crtc_mask |= BIT(i);
> }
> intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
> /*
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 13:04 ` Jani Nikula
@ 2018-09-07 13:11 ` Kumar, Mahesh
2018-09-07 13:34 ` [PATCH v3] " Mahesh Kumar
2018-09-07 14:49 ` [PATCH v2] " Ville Syrjälä
1 sibling, 1 reply; 21+ messages in thread
From: Kumar, Mahesh @ 2018-09-07 13:11 UTC (permalink / raw)
To: Jani Nikula, intel-gfx; +Cc: Rodrigo Vivi
Hi,
I used u8 because internally num_pipes variable used by for_each_pipe
macro is of u8 type.
If you think it's good to have int for consistency I can update the patch.
Regards,
-Mahesh
On 9/7/2018 6:34 PM, Jani Nikula wrote:
> On Fri, 07 Sep 2018, Mahesh Kumar <mahesh1.kumar@intel.com> wrote:
>> This cleanup patch makes changes to use for_each_pipe loop
>> during bit-mask assignment of allowed crtc with encoder.
>>
>> changes:
>> - use BIT(i) macro instead of (1 << i) (Chris)
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
>> ---
>> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
>> drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
>> drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
>> 3 files changed, 11 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
>> index cd01a09c5e0f..88dfca245099 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> struct intel_encoder *intel_encoder;
>> struct drm_encoder *encoder;
>> bool init_hdmi, init_dp, init_lspcon = false;
>> + u8 i;
> Please use int instead of u8 throughout. u8 only makes sense when you
> actually need the specific size, or need to be concerned about the size.
>
> BR,
> Jani.
>
>>
>>
>> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
>> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> intel_encoder->type = INTEL_OUTPUT_DDI;
>> intel_encoder->power_domain = intel_port_to_power_domain(port);
>> intel_encoder->port = port;
>> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> intel_encoder->cloneable = 0;
>> + for_each_pipe(dev_priv, i)
>> + intel_encoder->crtc_mask |= BIT(i);
>>
>> if (INTEL_GEN(dev_priv) >= 11)
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> index 436c22de33b6..1f954debdc55 100644
>> --- a/drivers/gpu/drm/i915/intel_dp.c
>> +++ b/drivers/gpu/drm/i915/intel_dp.c
>> @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
>> else
>> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
>> } else {
>> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> + u8 i;
>> +
>> + for_each_pipe(dev_priv, i)
>> + intel_encoder->crtc_mask |= BIT(i);
>> }
>> intel_encoder->cloneable = 0;
>> intel_encoder->port = port;
>> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>> index a2dab0b6bde6..647e38de7980 100644
>> --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
>> else
>> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
>> } else {
>> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> + u8 i;
>> +
>> + for_each_pipe(dev_priv, i)
>> + intel_encoder->crtc_mask |= BIT(i);
>> }
>> intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
>> /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev2)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
2018-09-07 12:45 ` Chris Wilson
@ 2018-09-07 13:25 ` Patchwork
2018-09-07 14:03 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev3) Patchwork
` (5 subsequent siblings)
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-07 13:25 UTC (permalink / raw)
To: Kumar, Mahesh; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev2)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4786 -> Patchwork_10127 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49341/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10127 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_psr@primary_page_flip:
fi-cnl-psr: PASS -> FAIL (fdo#107336)
igt@pm_backlight@basic-brightness:
fi-glk-dsi: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
igt@kms_psr@primary_page_flip:
fi-kbl-r: FAIL (fdo#107336) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (54 -> 48) ==
Missing (6): fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4786 -> Patchwork_10127
CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10127: c7acf4be464bb4c4fecc202d80799b337cbb7a51 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c7acf4be464b drm/i915: use for_each_pipe loop to assign crtc_mask
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10127/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v3] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 13:11 ` Kumar, Mahesh
@ 2018-09-07 13:34 ` Mahesh Kumar
0 siblings, 0 replies; 21+ messages in thread
From: Mahesh Kumar @ 2018-09-07 13:34 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
This cleanup patch makes changes to use for_each_pipe loop
during bit-mask assignment of allowed crtc with encoder.
changes:
- use BIT(i) macro instead of (1 << i) (Chris)
changes from V2:
- use int for consistency (Jani)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..6faf36b5623d 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
+ int i;
init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
@@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_encoder->type = INTEL_OUTPUT_DDI;
intel_encoder->power_domain = intel_port_to_power_domain(port);
intel_encoder->port = port;
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
intel_encoder->cloneable = 0;
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 436c22de33b6..ffa12cdab522 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ int i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
}
intel_encoder->cloneable = 0;
intel_encoder->port = port;
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index a2dab0b6bde6..f778840464b5 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ int i;
+
+ for_each_pipe(dev_priv, i)
+ intel_encoder->crtc_mask |= BIT(i);
}
intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
/*
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev3)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
2018-09-07 12:45 ` Chris Wilson
2018-09-07 13:25 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev2) Patchwork
@ 2018-09-07 14:03 ` Patchwork
2018-09-07 15:50 ` ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-07 14:03 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev3)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4786 -> Patchwork_10128 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49341/revisions/3/mbox/
== Known issues ==
Here are the changes found in Patchwork_10128 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@live_hangcheck:
fi-kbl-guc: PASS -> DMESG-FAIL (fdo#107837, fdo#107710, fdo#106560)
igt@gem_exec_suspend@basic-s4-devices:
fi-kbl-7500u: PASS -> DMESG-WARN (fdo#105128, fdo#107139)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
==== Possible fixes ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#107362, fdo#103191) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-snb-2520m: INCOMPLETE (fdo#103713) -> PASS
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#105128 https://bugs.freedesktop.org/show_bug.cgi?id=105128
fdo#106560 https://bugs.freedesktop.org/show_bug.cgi?id=106560
fdo#107139 https://bugs.freedesktop.org/show_bug.cgi?id=107139
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107710 https://bugs.freedesktop.org/show_bug.cgi?id=107710
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107837 https://bugs.freedesktop.org/show_bug.cgi?id=107837
== Participating hosts (54 -> 47) ==
Missing (7): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-hsw-peppy fi-byt-squawks fi-bsw-cyan fi-ctg-p8600
== Build changes ==
* Linux: CI_DRM_4786 -> Patchwork_10128
CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10128: 8e1ce7a3df19d22ca1f9ccdcc779a72e101af15f @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
8e1ce7a3df19 drm/i915: use for_each_pipe loop to assign crtc_mask
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10128/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 13:04 ` Jani Nikula
2018-09-07 13:11 ` Kumar, Mahesh
@ 2018-09-07 14:49 ` Ville Syrjälä
2018-09-08 6:10 ` [PATCH v4] " Mahesh Kumar
2018-09-10 9:04 ` [PATCH v2] " Jani Nikula
1 sibling, 2 replies; 21+ messages in thread
From: Ville Syrjälä @ 2018-09-07 14:49 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, Rodrigo Vivi
On Fri, Sep 07, 2018 at 04:04:03PM +0300, Jani Nikula wrote:
> On Fri, 07 Sep 2018, Mahesh Kumar <mahesh1.kumar@intel.com> wrote:
> > This cleanup patch makes changes to use for_each_pipe loop
> > during bit-mask assignment of allowed crtc with encoder.
> >
> > changes:
> > - use BIT(i) macro instead of (1 << i) (Chris)
> >
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
> > drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
> > drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
> > 3 files changed, 11 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> > index cd01a09c5e0f..88dfca245099 100644
> > --- a/drivers/gpu/drm/i915/intel_ddi.c
> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
> > @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> > struct intel_encoder *intel_encoder;
> > struct drm_encoder *encoder;
> > bool init_hdmi, init_dp, init_lspcon = false;
> > + u8 i;
>
> Please use int instead of u8 throughout. u8 only makes sense when you
> actually need the specific size, or need to be concerned about the size.
Actually please use 'enum pipe pipe'.
>
> BR,
> Jani.
>
> >
> >
> > init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
> > @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> > intel_encoder->type = INTEL_OUTPUT_DDI;
> > intel_encoder->power_domain = intel_port_to_power_domain(port);
> > intel_encoder->port = port;
> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> > intel_encoder->cloneable = 0;
> > + for_each_pipe(dev_priv, i)
> > + intel_encoder->crtc_mask |= BIT(i);
> >
> > if (INTEL_GEN(dev_priv) >= 11)
> > intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> > index 436c22de33b6..1f954debdc55 100644
> > --- a/drivers/gpu/drm/i915/intel_dp.c
> > +++ b/drivers/gpu/drm/i915/intel_dp.c
> > @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
> > else
> > intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> > } else {
> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> > + u8 i;
> > +
> > + for_each_pipe(dev_priv, i)
> > + intel_encoder->crtc_mask |= BIT(i);
> > }
> > intel_encoder->cloneable = 0;
> > intel_encoder->port = port;
> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> > index a2dab0b6bde6..647e38de7980 100644
> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> > @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
> > else
> > intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> > } else {
> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> > + u8 i;
> > +
> > + for_each_pipe(dev_priv, i)
> > + intel_encoder->crtc_mask |= BIT(i);
> > }
> > intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
> > /*
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev3)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
` (2 preceding siblings ...)
2018-09-07 14:03 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev3) Patchwork
@ 2018-09-07 15:50 ` Patchwork
2018-09-08 6:43 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev4) Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-07 15:50 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev3)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4786_full -> Patchwork_10128_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10128_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10128_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10128_full:
=== IGT changes ===
==== Warnings ====
igt@kms_cursor_legacy@cursora-vs-flipb-toggle:
shard-hsw: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10128_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-snb: PASS -> INCOMPLETE (fdo#106886, fdo#105411)
shard-hsw: PASS -> INCOMPLETE (fdo#106886, fdo#103540)
shard-kbl: PASS -> FAIL (fdo#106886)
igt@gem_workarounds@suspend-resume-context:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-pwrite:
shard-glk: PASS -> FAIL (fdo#103167)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-a-ts-continuation-suspend:
shard-kbl: PASS -> INCOMPLETE (fdo#107556, fdo#103665)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
shard-apl: FAIL (fdo#103167) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4786 -> Patchwork_10128
CI_DRM_4786: d28dcb05a3c33df6fcb0828d81fa0bb6591a97be @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10128: 8e1ce7a3df19d22ca1f9ccdcc779a72e101af15f @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10128/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v4] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 14:49 ` [PATCH v2] " Ville Syrjälä
@ 2018-09-08 6:10 ` Mahesh Kumar
2018-09-14 6:28 ` Kumar, Mahesh
2018-09-14 12:38 ` Ville Syrjälä
2018-09-10 9:04 ` [PATCH v2] " Jani Nikula
1 sibling, 2 replies; 21+ messages in thread
From: Mahesh Kumar @ 2018-09-08 6:10 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
This cleanup patch makes changes to use for_each_pipe loop
during bit-mask assignment of allowed crtc with encoder.
changes:
- use BIT(i) macro instead of (1 << i) (Chris)
changes from V2:
- use int for consistency (Jani)
changes from V3:
- instead use enum pipe (Ville)
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
3 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..0ef2448fd350 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
+ enum pipe pipe;
init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
@@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_encoder->type = INTEL_OUTPUT_DDI;
intel_encoder->power_domain = intel_port_to_power_domain(port);
intel_encoder->port = port;
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
intel_encoder->cloneable = 0;
+ for_each_pipe(dev_priv, pipe)
+ intel_encoder->crtc_mask |= BIT(pipe);
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index 436c22de33b6..7302b5807884 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ enum pipe pipe;
+
+ for_each_pipe(dev_priv, pipe)
+ intel_encoder->crtc_mask |= BIT(pipe);
}
intel_encoder->cloneable = 0;
intel_encoder->port = port;
diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
index a2dab0b6bde6..0d4c6f565d65 100644
--- a/drivers/gpu/drm/i915/intel_hdmi.c
+++ b/drivers/gpu/drm/i915/intel_hdmi.c
@@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
else
intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
} else {
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
+ enum pipe pipe;
+
+ for_each_pipe(dev_priv, pipe)
+ intel_encoder->crtc_mask |= BIT(pipe);
}
intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
/*
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev4)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
` (3 preceding siblings ...)
2018-09-07 15:50 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-08 6:43 ` Patchwork
2018-09-08 7:32 ` ✓ Fi.CI.IGT: " Patchwork
` (2 subsequent siblings)
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-08 6:43 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev4)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4787 -> Patchwork_10130 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49341/revisions/4/mbox/
== Known issues ==
Here are the changes found in Patchwork_10130 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: NOTRUN -> FAIL (fdo#107336)
==== Possible fixes ====
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: FAIL (fdo#103167) -> PASS
igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
fi-byt-clapper: FAIL (fdo#103191, fdo#107362) -> PASS
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-blb-e6850: INCOMPLETE (fdo#107718) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (52 -> 48) ==
Additional (1): fi-kbl-7560u
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4787 -> Patchwork_10130
CI_DRM_4787: 6dc8457a2f2093eecb9c6cbb7306fd25bb1664e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10130: 9a3b5e768fd3e133037c9a07e407d0f9051e7e7c @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
9a3b5e768fd3 drm/i915: use for_each_pipe loop to assign crtc_mask
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10130/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev4)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
` (4 preceding siblings ...)
2018-09-08 6:43 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev4) Patchwork
@ 2018-09-08 7:32 ` Patchwork
2018-09-19 9:36 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev5) Patchwork
2018-09-19 11:55 ` ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-08 7:32 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev4)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4787_full -> Patchwork_10130_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10130_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_caching@read-writes:
shard-glk: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-shrfb-draw-mmap-gtt:
shard-glk: PASS -> FAIL (fdo#103167) +1
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103313, fdo#103558)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
shard-kbl: PASS -> DMESG-WARN (fdo#105079, fdo#105602, fdo#103841, fdo#103558)
igt@kms_plane@plane-panning-bottom-right-pipe-c-planes:
shard-kbl: PASS -> DMESG-WARN (fdo#105602, fdo#103558)
==== Possible fixes ====
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103313 https://bugs.freedesktop.org/show_bug.cgi?id=103313
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#103841 https://bugs.freedesktop.org/show_bug.cgi?id=103841
fdo#105079 https://bugs.freedesktop.org/show_bug.cgi?id=105079
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4787 -> Patchwork_10130
CI_DRM_4787: 6dc8457a2f2093eecb9c6cbb7306fd25bb1664e6 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4634: 7d89cc39dde3b4881d85ace45d504cc098fa3684 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10130: 9a3b5e768fd3e133037c9a07e407d0f9051e7e7c @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10130/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-07 14:49 ` [PATCH v2] " Ville Syrjälä
2018-09-08 6:10 ` [PATCH v4] " Mahesh Kumar
@ 2018-09-10 9:04 ` Jani Nikula
1 sibling, 0 replies; 21+ messages in thread
From: Jani Nikula @ 2018-09-10 9:04 UTC (permalink / raw)
To: Ville Syrjälä; +Cc: intel-gfx, Rodrigo Vivi
On Fri, 07 Sep 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Sep 07, 2018 at 04:04:03PM +0300, Jani Nikula wrote:
>> On Fri, 07 Sep 2018, Mahesh Kumar <mahesh1.kumar@intel.com> wrote:
>> > This cleanup patch makes changes to use for_each_pipe loop
>> > during bit-mask assignment of allowed crtc with encoder.
>> >
>> > changes:
>> > - use BIT(i) macro instead of (1 << i) (Chris)
>> >
>> > Cc: Jani Nikula <jani.nikula@intel.com>
>> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> > Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
>> > ---
>> > drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
>> > drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
>> > drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
>> > 3 files changed, 11 insertions(+), 3 deletions(-)
>> >
>> > diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
>> > index cd01a09c5e0f..88dfca245099 100644
>> > --- a/drivers/gpu/drm/i915/intel_ddi.c
>> > +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> > @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> > struct intel_encoder *intel_encoder;
>> > struct drm_encoder *encoder;
>> > bool init_hdmi, init_dp, init_lspcon = false;
>> > + u8 i;
>>
>> Please use int instead of u8 throughout. u8 only makes sense when you
>> actually need the specific size, or need to be concerned about the size.
>
> Actually please use 'enum pipe pipe'.
D'oh, of course.
BR,
Jani.
>
>>
>> BR,
>> Jani.
>>
>> >
>> >
>> > init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
>> > @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> > intel_encoder->type = INTEL_OUTPUT_DDI;
>> > intel_encoder->power_domain = intel_port_to_power_domain(port);
>> > intel_encoder->port = port;
>> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> > intel_encoder->cloneable = 0;
>> > + for_each_pipe(dev_priv, i)
>> > + intel_encoder->crtc_mask |= BIT(i);
>> >
>> > if (INTEL_GEN(dev_priv) >= 11)
>> > intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> > diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
>> > index 436c22de33b6..1f954debdc55 100644
>> > --- a/drivers/gpu/drm/i915/intel_dp.c
>> > +++ b/drivers/gpu/drm/i915/intel_dp.c
>> > @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
>> > else
>> > intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
>> > } else {
>> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> > + u8 i;
>> > +
>> > + for_each_pipe(dev_priv, i)
>> > + intel_encoder->crtc_mask |= BIT(i);
>> > }
>> > intel_encoder->cloneable = 0;
>> > intel_encoder->port = port;
>> > diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
>> > index a2dab0b6bde6..647e38de7980 100644
>> > --- a/drivers/gpu/drm/i915/intel_hdmi.c
>> > +++ b/drivers/gpu/drm/i915/intel_hdmi.c
>> > @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
>> > else
>> > intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
>> > } else {
>> > - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> > + u8 i;
>> > +
>> > + for_each_pipe(dev_priv, i)
>> > + intel_encoder->crtc_mask |= BIT(i);
>> > }
>> > intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
>> > /*
>>
>> --
>> Jani Nikula, Intel Open Source Graphics Center
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-08 6:10 ` [PATCH v4] " Mahesh Kumar
@ 2018-09-14 6:28 ` Kumar, Mahesh
2018-09-14 12:38 ` Ville Syrjälä
1 sibling, 0 replies; 21+ messages in thread
From: Kumar, Mahesh @ 2018-09-14 6:28 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
Hi,
just a ping for review :)
-Mahesh
On 9/8/2018 11:40 AM, Mahesh Kumar wrote:
> This cleanup patch makes changes to use for_each_pipe loop
> during bit-mask assignment of allowed crtc with encoder.
>
> changes:
> - use BIT(i) macro instead of (1 << i) (Chris)
> changes from V2:
> - use int for consistency (Jani)
> changes from V3:
> - instead use enum pipe (Ville)
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
> drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
> drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
> 3 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..0ef2448fd350 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct intel_encoder *intel_encoder;
> struct drm_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> + enum pipe pipe;
>
>
> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> intel_encoder->type = INTEL_OUTPUT_DDI;
> intel_encoder->power_domain = intel_port_to_power_domain(port);
> intel_encoder->port = port;
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 436c22de33b6..7302b5807884 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + enum pipe pipe;
> +
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
> }
> intel_encoder->cloneable = 0;
> intel_encoder->port = port;
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index a2dab0b6bde6..0d4c6f565d65 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + enum pipe pipe;
> +
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
> }
> intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
> /*
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v4] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-08 6:10 ` [PATCH v4] " Mahesh Kumar
2018-09-14 6:28 ` Kumar, Mahesh
@ 2018-09-14 12:38 ` Ville Syrjälä
2018-09-19 8:31 ` [PATCH v5] " Mahesh Kumar
1 sibling, 1 reply; 21+ messages in thread
From: Ville Syrjälä @ 2018-09-14 12:38 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: Jani Nikula, intel-gfx, Rodrigo Vivi
On Sat, Sep 08, 2018 at 11:40:48AM +0530, Mahesh Kumar wrote:
> This cleanup patch makes changes to use for_each_pipe loop
> during bit-mask assignment of allowed crtc with encoder.
>
> changes:
> - use BIT(i) macro instead of (1 << i) (Chris)
> changes from V2:
> - use int for consistency (Jani)
> changes from V3:
> - instead use enum pipe (Ville)
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
> drivers/gpu/drm/i915/intel_dp.c | 5 ++++-
> drivers/gpu/drm/i915/intel_hdmi.c | 5 ++++-
> 3 files changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..0ef2448fd350 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct intel_encoder *intel_encoder;
> struct drm_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> + enum pipe pipe;
>
>
> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> intel_encoder->type = INTEL_OUTPUT_DDI;
> intel_encoder->power_domain = intel_port_to_power_domain(port);
> intel_encoder->port = port;
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
This makes sense.
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index 436c22de33b6..7302b5807884 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -6709,7 +6709,10 @@ bool intel_dp_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + enum pipe pipe;
> +
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
These I'm not so sure. Why only DP and HDMI and not the rest?
Considering everything !ddi is legacy I don't think there's any
real point in future proofing them agaisnt pipe D+.
And why do I now have a feeling someone sent a patch earlier to fix
these all up to use BIT(). Where did that patch go? Ah, it was me :)
https://lists.freedesktop.org/archives/dri-devel/2018-June/180155.html
And I guess I never pushed it.
OK, so I'd say drop the dp/hdmi changes and this is
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
I can then rebase my stuff on top and resend it.
> }
> intel_encoder->cloneable = 0;
> intel_encoder->port = port;
> diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c
> index a2dab0b6bde6..0d4c6f565d65 100644
> --- a/drivers/gpu/drm/i915/intel_hdmi.c
> +++ b/drivers/gpu/drm/i915/intel_hdmi.c
> @@ -2468,7 +2468,10 @@ void intel_hdmi_init(struct drm_i915_private *dev_priv,
> else
> intel_encoder->crtc_mask = (1 << 0) | (1 << 1);
> } else {
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> + enum pipe pipe;
> +
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
> }
> intel_encoder->cloneable = 1 << INTEL_OUTPUT_ANALOG;
> /*
> --
> 2.16.2
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v5] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-14 12:38 ` Ville Syrjälä
@ 2018-09-19 8:31 ` Mahesh Kumar
2018-09-21 19:14 ` Lucas De Marchi
0 siblings, 1 reply; 21+ messages in thread
From: Mahesh Kumar @ 2018-09-19 8:31 UTC (permalink / raw)
To: intel-gfx; +Cc: Jani Nikula, Rodrigo Vivi
This cleanup patch makes changes to use for_each_pipe loop
during bit-mask assignment of allowed crtc with encoder.
changes:
- use BIT(i) macro instead of (1 << i) (Chris)
changes from V2:
- use int for consistency (Jani)
changes from V3:
- instead use enum pipe (Ville)
changes from V4:
- drop DP/HDMI changes, as already part of patch from ville
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..0ef2448fd350 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
struct intel_encoder *intel_encoder;
struct drm_encoder *encoder;
bool init_hdmi, init_dp, init_lspcon = false;
+ enum pipe pipe;
init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
@@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
intel_encoder->type = INTEL_OUTPUT_DDI;
intel_encoder->power_domain = intel_port_to_power_domain(port);
intel_encoder->port = port;
- intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
intel_encoder->cloneable = 0;
+ for_each_pipe(dev_priv, pipe)
+ intel_encoder->crtc_mask |= BIT(pipe);
if (INTEL_GEN(dev_priv) >= 11)
intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
--
2.16.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 21+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev5)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
` (5 preceding siblings ...)
2018-09-08 7:32 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-19 9:36 ` Patchwork
2018-09-19 11:55 ` ✓ Fi.CI.IGT: " Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-19 9:36 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev5)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4841 -> Patchwork_10222 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49341/revisions/5/mbox/
== Known issues ==
Here are the changes found in Patchwork_10222 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_selftest@mock_sanitycheck:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#107344)
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: PASS -> DMESG-WARN (fdo#107345) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
fi-cfl-8109u: PASS -> INCOMPLETE (fdo#106070)
igt@pm_rpm@module-reload:
fi-glk-j4005: PASS -> DMESG-FAIL (fdo#104767)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@mock_hugepages:
fi-bwr-2160: DMESG-FAIL (fdo#107930) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
fdo#104767 https://bugs.freedesktop.org/show_bug.cgi?id=104767
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107344 https://bugs.freedesktop.org/show_bug.cgi?id=107344
fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107930 https://bugs.freedesktop.org/show_bug.cgi?id=107930
== Participating hosts (52 -> 46) ==
Additional (1): fi-icl-u
Missing (7): fi-cnl-u fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-skl-6700hq
== Build changes ==
* Linux: CI_DRM_4841 -> Patchwork_10222
CI_DRM_4841: 4a03aefd83495146beca5f593558343aca40eb51 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10222: 0b7f908261397034a0d58c7d3f3fcd851913f781 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
0b7f90826139 drm/i915: use for_each_pipe loop to assign crtc_mask
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10222/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev5)
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
` (6 preceding siblings ...)
2018-09-19 9:36 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev5) Patchwork
@ 2018-09-19 11:55 ` Patchwork
7 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2018-09-19 11:55 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: use for_each_pipe loop to assign crtc_mask (rev5)
URL : https://patchwork.freedesktop.org/series/49341/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4841_full -> Patchwork_10222_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10222_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10222_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10222_full:
=== IGT changes ===
==== Warnings ====
igt@kms_vblank@pipe-a-query-idle:
shard-snb: SKIP -> PASS
== Known issues ==
Here are the changes found in Patchwork_10222_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-hsw: PASS -> INCOMPLETE (fdo#106886, fdo#103540)
igt@gem_exec_await@wide-contexts:
shard-glk: PASS -> FAIL (fdo#106680)
igt@kms_busy@extended-pageflip-hang-newfb-render-a:
shard-apl: PASS -> DMESG-WARN (fdo#107956)
igt@kms_flip@2x-plain-flip-ts-check:
shard-glk: PASS -> FAIL (fdo#100368)
igt@kms_setmode@basic:
shard-kbl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-a-ts-continuation-dpms-suspend:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
==== Possible fixes ====
igt@kms_busy@extended-modeset-hang-newfb-render-c:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@kms_cursor_crc@cursor-128x128-onscreen:
shard-apl: DMESG-WARN (fdo#103558, fdo#105602) -> PASS +3
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-apl: FAIL (fdo#103232, fdo#103191) -> PASS
igt@kms_draw_crc@draw-method-rgb565-render-untiled:
shard-apl: DMESG-FAIL (fdo#103558, fdo#105602) -> SKIP
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4841 -> Patchwork_10222
CI_DRM_4841: 4a03aefd83495146beca5f593558343aca40eb51 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10222: 0b7f908261397034a0d58c7d3f3fcd851913f781 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10222/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-19 8:31 ` [PATCH v5] " Mahesh Kumar
@ 2018-09-21 19:14 ` Lucas De Marchi
2018-09-25 9:21 ` Jani Nikula
0 siblings, 1 reply; 21+ messages in thread
From: Lucas De Marchi @ 2018-09-21 19:14 UTC (permalink / raw)
To: Mahesh Kumar; +Cc: Jani Nikula, intel-gfx, Rodrigo Vivi
On Wed, Sep 19, 2018 at 02:01:26PM +0530, Mahesh Kumar wrote:
> This cleanup patch makes changes to use for_each_pipe loop
> during bit-mask assignment of allowed crtc with encoder.
>
> changes:
> - use BIT(i) macro instead of (1 << i) (Chris)
> changes from V2:
> - use int for consistency (Jani)
> changes from V3:
> - instead use enum pipe (Ville)
> changes from V4:
> - drop DP/HDMI changes, as already part of patch from ville
>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Lucas De Marchi
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..0ef2448fd350 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> struct intel_encoder *intel_encoder;
> struct drm_encoder *encoder;
> bool init_hdmi, init_dp, init_lspcon = false;
> + enum pipe pipe;
>
>
> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
> intel_encoder->type = INTEL_OUTPUT_DDI;
> intel_encoder->power_domain = intel_port_to_power_domain(port);
> intel_encoder->port = port;
> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
> intel_encoder->cloneable = 0;
> + for_each_pipe(dev_priv, pipe)
> + intel_encoder->crtc_mask |= BIT(pipe);
>
> if (INTEL_GEN(dev_priv) >= 11)
> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
> --
> 2.16.2
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v5] drm/i915: use for_each_pipe loop to assign crtc_mask
2018-09-21 19:14 ` Lucas De Marchi
@ 2018-09-25 9:21 ` Jani Nikula
0 siblings, 0 replies; 21+ messages in thread
From: Jani Nikula @ 2018-09-25 9:21 UTC (permalink / raw)
To: Lucas De Marchi, Mahesh Kumar; +Cc: intel-gfx, Rodrigo Vivi
On Fri, 21 Sep 2018, Lucas De Marchi <lucas.de.marchi@gmail.com> wrote:
> On Wed, Sep 19, 2018 at 02:01:26PM +0530, Mahesh Kumar wrote:
>> This cleanup patch makes changes to use for_each_pipe loop
>> during bit-mask assignment of allowed crtc with encoder.
>>
>> changes:
>> - use BIT(i) macro instead of (1 << i) (Chris)
>> changes from V2:
>> - use int for consistency (Jani)
>> changes from V3:
>> - instead use enum pipe (Ville)
>> changes from V4:
>> - drop DP/HDMI changes, as already part of patch from ville
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> Signed-off-by: Mahesh Kumar <mahesh1.kumar@intel.com>
>> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Pushed, thanks for the patch and review.
BR,
Jani.
>
>
> Lucas De Marchi
>
>> ---
>> drivers/gpu/drm/i915/intel_ddi.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
>> index cd01a09c5e0f..0ef2448fd350 100644
>> --- a/drivers/gpu/drm/i915/intel_ddi.c
>> +++ b/drivers/gpu/drm/i915/intel_ddi.c
>> @@ -3751,6 +3751,7 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> struct intel_encoder *intel_encoder;
>> struct drm_encoder *encoder;
>> bool init_hdmi, init_dp, init_lspcon = false;
>> + enum pipe pipe;
>>
>>
>> init_hdmi = (dev_priv->vbt.ddi_port_info[port].supports_dvi ||
>> @@ -3801,8 +3802,9 @@ void intel_ddi_init(struct drm_i915_private *dev_priv, enum port port)
>> intel_encoder->type = INTEL_OUTPUT_DDI;
>> intel_encoder->power_domain = intel_port_to_power_domain(port);
>> intel_encoder->port = port;
>> - intel_encoder->crtc_mask = (1 << 0) | (1 << 1) | (1 << 2);
>> intel_encoder->cloneable = 0;
>> + for_each_pipe(dev_priv, pipe)
>> + intel_encoder->crtc_mask |= BIT(pipe);
>>
>> if (INTEL_GEN(dev_priv) >= 11)
>> intel_dig_port->saved_port_bits = I915_READ(DDI_BUF_CTL(port)) &
>> --
>> 2.16.2
>>
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2018-09-25 9:21 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 12:40 [PATCH] drm/i915: use for_each_pipe loop to assign crtc_mask Mahesh Kumar
2018-09-07 12:45 ` Chris Wilson
2018-09-07 12:59 ` [PATCH v2] " Mahesh Kumar
2018-09-07 13:04 ` Jani Nikula
2018-09-07 13:11 ` Kumar, Mahesh
2018-09-07 13:34 ` [PATCH v3] " Mahesh Kumar
2018-09-07 14:49 ` [PATCH v2] " Ville Syrjälä
2018-09-08 6:10 ` [PATCH v4] " Mahesh Kumar
2018-09-14 6:28 ` Kumar, Mahesh
2018-09-14 12:38 ` Ville Syrjälä
2018-09-19 8:31 ` [PATCH v5] " Mahesh Kumar
2018-09-21 19:14 ` Lucas De Marchi
2018-09-25 9:21 ` Jani Nikula
2018-09-10 9:04 ` [PATCH v2] " Jani Nikula
2018-09-07 13:25 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev2) Patchwork
2018-09-07 14:03 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev3) Patchwork
2018-09-07 15:50 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-08 6:43 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev4) Patchwork
2018-09-08 7:32 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-19 9:36 ` ✓ Fi.CI.BAT: success for drm/i915: use for_each_pipe loop to assign crtc_mask (rev5) Patchwork
2018-09-19 11:55 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.