From: Roman Gushchin <guro@fb.com>
To: <jgkamat@fb.com>
Cc: <shuah@kernel.org>, <linux-kselftest@vger.kernel.org>,
Tejun Heo <tj@kernel.org>, <kernel-team@fb.com>,
<linux-kernel@vger.kernel.org>, <jaygkamat@gmail.com>
Subject: Re: [PATCH 1/2] Fix cg_read_strcmp()
Date: Fri, 7 Sep 2018 09:56:44 -0700 [thread overview]
Message-ID: <20180907165642.GA572@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20180907164924.13789-2-jgkamat@fb.com>
On Fri, Sep 07, 2018 at 09:49:23AM -0700, jgkamat@fb.com wrote:
> From: Jay Kamat <jgkamat@fb.com>
>
> Fix a couple issues with cg_read_strcmp(), to improve correctness of
> cgroup tests
> - Fix cg_read_strcmp() always returning 0 for empty "needle" strings
> - Fix a memory leak in cg_read_strcmp()
>
> Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
Hi Jay!
Thank you for working on this!
Acked-by: Roman Gushchin <guro@fb.com>
WARNING: multiple messages have this Message-ID (diff)
From: guro at fb.com (Roman Gushchin)
Subject: [PATCH 1/2] Fix cg_read_strcmp()
Date: Fri, 7 Sep 2018 09:56:44 -0700 [thread overview]
Message-ID: <20180907165642.GA572@tower.DHCP.thefacebook.com> (raw)
In-Reply-To: <20180907164924.13789-2-jgkamat@fb.com>
On Fri, Sep 07, 2018 at 09:49:23AM -0700, jgkamat at fb.com wrote:
> From: Jay Kamat <jgkamat at fb.com>
>
> Fix a couple issues with cg_read_strcmp(), to improve correctness of
> cgroup tests
> - Fix cg_read_strcmp() always returning 0 for empty "needle" strings
> - Fix a memory leak in cg_read_strcmp()
>
> Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
Hi Jay!
Thank you for working on this!
Acked-by: Roman Gushchin <guro at fb.com>
WARNING: multiple messages have this Message-ID (diff)
From: guro@fb.com (Roman Gushchin)
Subject: [PATCH 1/2] Fix cg_read_strcmp()
Date: Fri, 7 Sep 2018 09:56:44 -0700 [thread overview]
Message-ID: <20180907165642.GA572@tower.DHCP.thefacebook.com> (raw)
Message-ID: <20180907165644.w-oZ6YR2uM7Qu3yR-YCpV_4AaE04SA7ROp2fzDaLeXs@z> (raw)
In-Reply-To: <20180907164924.13789-2-jgkamat@fb.com>
On Fri, Sep 07, 2018@09:49:23AM -0700, jgkamat@fb.com wrote:
> From: Jay Kamat <jgkamat at fb.com>
>
> Fix a couple issues with cg_read_strcmp(), to improve correctness of
> cgroup tests
> - Fix cg_read_strcmp() always returning 0 for empty "needle" strings
> - Fix a memory leak in cg_read_strcmp()
>
> Fixes: 84092dbcf901 ("selftests: cgroup: add memory controller self-tests")
Hi Jay!
Thank you for working on this!
Acked-by: Roman Gushchin <guro at fb.com>
next prev parent reply other threads:[~2018-09-07 16:59 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 1:08 kselftests for memory.oom.group jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 1:08 ` [PATCH 1/2] Fix cg_read_strcmp() jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 14:43 ` Shuah Khan
2018-09-05 14:43 ` Shuah Khan
2018-09-05 14:43 ` shuah
2018-09-05 1:08 ` [PATCH 2/2] Add tests for memory.oom.group jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 1:08 ` jgkamat
2018-09-05 15:21 ` Shuah Khan
2018-09-05 15:21 ` Shuah Khan
2018-09-05 15:21 ` shuah
2018-09-07 16:49 ` kselftests " jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:49 ` [PATCH 1/2] Fix cg_read_strcmp() jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:56 ` Roman Gushchin [this message]
2018-09-07 16:56 ` Roman Gushchin
2018-09-07 16:56 ` guro
2018-09-07 17:06 ` Shuah Khan
2018-09-07 17:06 ` Shuah Khan
2018-09-07 17:06 ` shuah
2018-09-07 18:28 ` Jay Kamat
2018-09-07 18:28 ` Jay Kamat
2018-09-07 18:28 ` jgkamat
2018-09-07 18:53 ` Shuah Khan
2018-09-07 18:53 ` Shuah Khan
2018-09-07 18:53 ` shuah
2018-09-07 16:49 ` [PATCH 2/2] Add tests for memory.oom.group jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:49 ` jgkamat
2018-09-07 16:57 ` Roman Gushchin
2018-09-07 16:57 ` Roman Gushchin
2018-09-07 16:57 ` guro
2018-09-07 21:34 ` kselftests " jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 21:34 ` [PATCH v3 1/2] Fix cg_read_strcmp() jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 21:34 ` [PATCH v3 2/2] Add tests for memory.oom.group jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 21:34 ` jgkamat
2018-09-07 22:53 ` kselftests " Shuah Khan
2018-09-07 22:53 ` Shuah Khan
2018-09-07 22:53 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907165642.GA572@tower.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=jaygkamat@gmail.com \
--cc=jgkamat@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.