* [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback
@ 2018-09-07 17:27 jun qian
2018-09-07 17:34 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: jun qian @ 2018-09-07 17:27 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, linux-kernel, jun qian
As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Signed-off-by: jun qian <hangdianqj@163.com>
---
drivers/block/umem.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/umem.c b/drivers/block/umem.c
index 5c7fb8cc4149..9094ca60949c 100644
--- a/drivers/block/umem.c
+++ b/drivers/block/umem.c
@@ -421,7 +421,7 @@ static void process_page(unsigned long data)
struct cardinfo *card = (struct cardinfo *)data;
unsigned int dma_status = card->dma_status;
- spin_lock_bh(&card->lock);
+ spin_lock(&card->lock);
if (card->Active < 0)
goto out_unlock;
page = &card->mm_pages[card->Active];
@@ -496,7 +496,7 @@ static void process_page(unsigned long data)
mm_start_io(card);
}
out_unlock:
- spin_unlock_bh(&card->lock);
+ spin_unlock(&card->lock);
while (return_bio) {
struct bio *bio = return_bio;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback
2018-09-07 17:27 [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback jun qian
@ 2018-09-07 17:34 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-09-07 17:34 UTC (permalink / raw)
To: jun qian; +Cc: linux-block, linux-kernel
On 9/7/18 11:27 AM, jun qian wrote:
> As you are already in a tasklet, it is unnecessary to call spin_lock_bh.
Looks good to me, applied.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-07 17:34 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 17:27 [PATCH] block: umem: replace spin_lock_bh with spin_lock in tasklet callback jun qian
2018-09-07 17:34 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.