* Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree
[not found] <20180906224849.1JOWr%akpm@linux-foundation.org>
@ 2018-09-07 19:58 ` Alexey Dobriyan
2018-09-08 14:03 ` Johannes Weiner
0 siblings, 1 reply; 5+ messages in thread
From: Alexey Dobriyan @ 2018-09-07 19:58 UTC (permalink / raw)
To: linux-kernel
Cc: linux-kernel, willy, vjitta, sumit.semwal, rientjes, mhocko,
mgorman, labbott, iamjoonsoo.kim, hannes, guro, cl, vbabka
On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote:
> - {"kmalloc-1024", 1024}, {"kmalloc-2048", 2048},
> - {"kmalloc-4096", 4096}, {"kmalloc-8192", 8192},
> - {"kmalloc-16384", 16384}, {"kmalloc-32768", 32768},
> - {"kmalloc-65536", 65536}, {"kmalloc-131072", 131072},
> - {"kmalloc-262144", 262144}, {"kmalloc-524288", 524288},
> - {"kmalloc-1048576", 1048576}, {"kmalloc-2097152", 2097152},
> - {"kmalloc-4194304", 4194304}, {"kmalloc-8388608", 8388608},
> - {"kmalloc-16777216", 16777216}, {"kmalloc-33554432", 33554432},
> - {"kmalloc-67108864", 67108864}
> + {"kmalloc-1k", 1024}, {"kmalloc-2k", 2048},
> + {"kmalloc-4k", 4096}, {"kmalloc-8k", 8192},
> + {"kmalloc-16k", 16384}, {"kmalloc-32k", 32768},
> + {"kmalloc-64k", 65536}, {"kmalloc-128k", 131072},
> + {"kmalloc-256k", 262144}, {"kmalloc-512k", 524288},
> + {"kmalloc-1M", 1048576}, {"kmalloc-2M", 2097152},
> + {"kmalloc-4M", 4194304}, {"kmalloc-8M", 8388608},
> + {"kmalloc-16M", 16777216}, {"kmalloc-32M", 33554432},
> + {"kmalloc-64M", 67108864}
I'd rather use KB and MB suffixes or at least capital 'K'.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree
2018-09-07 19:58 ` + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree Alexey Dobriyan
@ 2018-09-08 14:03 ` Johannes Weiner
2018-09-08 15:54 ` Matthew Wilcox
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Weiner @ 2018-09-08 14:03 UTC (permalink / raw)
To: Alexey Dobriyan
Cc: linux-kernel, willy, vjitta, sumit.semwal, rientjes, mhocko,
mgorman, labbott, iamjoonsoo.kim, guro, cl, vbabka
On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote:
> On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote:
> > - {"kmalloc-1024", 1024}, {"kmalloc-2048", 2048},
> > - {"kmalloc-4096", 4096}, {"kmalloc-8192", 8192},
> > - {"kmalloc-16384", 16384}, {"kmalloc-32768", 32768},
> > - {"kmalloc-65536", 65536}, {"kmalloc-131072", 131072},
> > - {"kmalloc-262144", 262144}, {"kmalloc-524288", 524288},
> > - {"kmalloc-1048576", 1048576}, {"kmalloc-2097152", 2097152},
> > - {"kmalloc-4194304", 4194304}, {"kmalloc-8388608", 8388608},
> > - {"kmalloc-16777216", 16777216}, {"kmalloc-33554432", 33554432},
> > - {"kmalloc-67108864", 67108864}
> > + {"kmalloc-1k", 1024}, {"kmalloc-2k", 2048},
> > + {"kmalloc-4k", 4096}, {"kmalloc-8k", 8192},
> > + {"kmalloc-16k", 16384}, {"kmalloc-32k", 32768},
> > + {"kmalloc-64k", 65536}, {"kmalloc-128k", 131072},
> > + {"kmalloc-256k", 262144}, {"kmalloc-512k", 524288},
> > + {"kmalloc-1M", 1048576}, {"kmalloc-2M", 2097152},
> > + {"kmalloc-4M", 4194304}, {"kmalloc-8M", 8388608},
> > + {"kmalloc-16M", 16777216}, {"kmalloc-32M", 33554432},
> > + {"kmalloc-64M", 67108864}
>
> I'd rather use KB and MB suffixes or at least capital 'K'.
I like k and M better.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree
2018-09-08 14:03 ` Johannes Weiner
@ 2018-09-08 15:54 ` Matthew Wilcox
2018-09-08 16:10 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Matthew Wilcox @ 2018-09-08 15:54 UTC (permalink / raw)
To: Johannes Weiner
Cc: Alexey Dobriyan, linux-kernel, vjitta, sumit.semwal, rientjes,
mhocko, mgorman, labbott, iamjoonsoo.kim, guro, cl, vbabka
On Sat, Sep 08, 2018 at 10:03:06AM -0400, Johannes Weiner wrote:
> On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote:
> > On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote:
> > > - {"kmalloc-1024", 1024}, {"kmalloc-2048", 2048},
> > > - {"kmalloc-4096", 4096}, {"kmalloc-8192", 8192},
> > > - {"kmalloc-16384", 16384}, {"kmalloc-32768", 32768},
> > > - {"kmalloc-65536", 65536}, {"kmalloc-131072", 131072},
> > > - {"kmalloc-262144", 262144}, {"kmalloc-524288", 524288},
> > > - {"kmalloc-1048576", 1048576}, {"kmalloc-2097152", 2097152},
> > > - {"kmalloc-4194304", 4194304}, {"kmalloc-8388608", 8388608},
> > > - {"kmalloc-16777216", 16777216}, {"kmalloc-33554432", 33554432},
> > > - {"kmalloc-67108864", 67108864}
> > > + {"kmalloc-1k", 1024}, {"kmalloc-2k", 2048},
> > > + {"kmalloc-4k", 4096}, {"kmalloc-8k", 8192},
> > > + {"kmalloc-16k", 16384}, {"kmalloc-32k", 32768},
> > > + {"kmalloc-64k", 65536}, {"kmalloc-128k", 131072},
> > > + {"kmalloc-256k", 262144}, {"kmalloc-512k", 524288},
> > > + {"kmalloc-1M", 1048576}, {"kmalloc-2M", 2097152},
> > > + {"kmalloc-4M", 4194304}, {"kmalloc-8M", 8388608},
> > > + {"kmalloc-16M", 16777216}, {"kmalloc-32M", 33554432},
> > > + {"kmalloc-64M", 67108864}
> >
> > I'd rather use KB and MB suffixes or at least capital 'K'.
>
> I like k and M better.
k and M work for me too. It we were going to be anal then we should
go with the IEC standard of KiB and MiB, but we're trying to make
/proc/slabinfo a little less ugly, and so we have 16 characters to work
with. "dma-kmalloc-256KiB" is 18 characters. The obvious place to lose
two characters is the "iB" which are implicit; we know we're measuring
bytes and the binary nature is assumed in this context of memory bytes
(not storage bytes). "dma-kmalloc-256k" is better.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree
2018-09-08 15:54 ` Matthew Wilcox
@ 2018-09-08 16:10 ` Randy Dunlap
2018-09-08 20:56 ` Matthew Wilcox
0 siblings, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2018-09-08 16:10 UTC (permalink / raw)
To: Matthew Wilcox, Johannes Weiner
Cc: Alexey Dobriyan, linux-kernel, vjitta, sumit.semwal, rientjes,
mhocko, mgorman, labbott, iamjoonsoo.kim, guro, cl, vbabka
On 09/08/2018 08:54 AM, Matthew Wilcox wrote:
> On Sat, Sep 08, 2018 at 10:03:06AM -0400, Johannes Weiner wrote:
>> On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote:
>>> On Thu, Sep 06, 2018 at 03:48:49PM -0700, akpm@linux-foundation.org wrote:
>>>> - {"kmalloc-1024", 1024}, {"kmalloc-2048", 2048},
>>>> - {"kmalloc-4096", 4096}, {"kmalloc-8192", 8192},
>>>> - {"kmalloc-16384", 16384}, {"kmalloc-32768", 32768},
>>>> - {"kmalloc-65536", 65536}, {"kmalloc-131072", 131072},
>>>> - {"kmalloc-262144", 262144}, {"kmalloc-524288", 524288},
>>>> - {"kmalloc-1048576", 1048576}, {"kmalloc-2097152", 2097152},
>>>> - {"kmalloc-4194304", 4194304}, {"kmalloc-8388608", 8388608},
>>>> - {"kmalloc-16777216", 16777216}, {"kmalloc-33554432", 33554432},
>>>> - {"kmalloc-67108864", 67108864}
>>>> + {"kmalloc-1k", 1024}, {"kmalloc-2k", 2048},
>>>> + {"kmalloc-4k", 4096}, {"kmalloc-8k", 8192},
>>>> + {"kmalloc-16k", 16384}, {"kmalloc-32k", 32768},
>>>> + {"kmalloc-64k", 65536}, {"kmalloc-128k", 131072},
>>>> + {"kmalloc-256k", 262144}, {"kmalloc-512k", 524288},
>>>> + {"kmalloc-1M", 1048576}, {"kmalloc-2M", 2097152},
>>>> + {"kmalloc-4M", 4194304}, {"kmalloc-8M", 8388608},
>>>> + {"kmalloc-16M", 16777216}, {"kmalloc-32M", 33554432},
>>>> + {"kmalloc-64M", 67108864}
>>>
>>> I'd rather use KB and MB suffixes or at least capital 'K'.
>>
>> I like k and M better.
>
> k and M work for me too. It we were going to be anal then we should
> go with the IEC standard of KiB and MiB, but we're trying to make
But ^K and ^M.
Small 'k' .. I don't know what that is.
> /proc/slabinfo a little less ugly, and so we have 16 characters to work
> with. "dma-kmalloc-256KiB" is 18 characters. The obvious place to lose
> two characters is the "iB" which are implicit; we know we're measuring
> bytes and the binary nature is assumed in this context of memory bytes
> (not storage bytes). "dma-kmalloc-256k" is better.
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree
2018-09-08 16:10 ` Randy Dunlap
@ 2018-09-08 20:56 ` Matthew Wilcox
0 siblings, 0 replies; 5+ messages in thread
From: Matthew Wilcox @ 2018-09-08 20:56 UTC (permalink / raw)
To: Randy Dunlap
Cc: Johannes Weiner, Alexey Dobriyan, linux-kernel, vjitta,
sumit.semwal, rientjes, mhocko, mgorman, labbott, iamjoonsoo.kim,
guro, cl, vbabka
On Sat, Sep 08, 2018 at 09:10:46AM -0700, Randy Dunlap wrote:
> On 09/08/2018 08:54 AM, Matthew Wilcox wrote:
> > On Sat, Sep 08, 2018 at 10:03:06AM -0400, Johannes Weiner wrote:
> >> On Fri, Sep 07, 2018 at 10:58:16PM +0300, Alexey Dobriyan wrote:
> >>> I'd rather use KB and MB suffixes or at least capital 'K'.
> >> I like k and M better.
> > k and M work for me too. It we were going to be anal then we should
> > go with the IEC standard of KiB and MiB, but we're trying to make
>
> But ^K and ^M.
>
> Small 'k' .. I don't know what that is.
SI uses 'k' for kilo and 'K' for Kelvin. It's an anomaly because all
the other magnifying prefixes use capital letters, but it's km, not Km;
kg, kV, kJ, kN, kW and kΩ.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-08 20:56 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20180906224849.1JOWr%akpm@linux-foundation.org>
2018-09-07 19:58 ` + mm-slab-shorten-kmalloc-cache-names-for-large-sizes.patch added to -mm tree Alexey Dobriyan
2018-09-08 14:03 ` Johannes Weiner
2018-09-08 15:54 ` Matthew Wilcox
2018-09-08 16:10 ` Randy Dunlap
2018-09-08 20:56 ` Matthew Wilcox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.