* [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception
@ 2018-08-24 20:01 Bernd Kuhls
2018-09-03 13:50 ` Giulio Benetti
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Bernd Kuhls @ 2018-08-24 20:01 UTC (permalink / raw)
To: buildroot
Fixes build error
TextException.cc: In function 'std::ostream& CurrentException(std::ostream&)':
TextException.cc:64:9: error: 'current_exception' is not a member of 'std'
if (std::current_exception()) {
using this defconfig
BR2_arm=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/armv5-ctng-linux-gnueabi.tar.xz"
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="armv5-ctng-linux-gnueabi"
BR2_TOOLCHAIN_EXTERNAL_GCC_4_8=y
BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_12=y
BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
BR2_TOOLCHAIN_EXTERNAL_CXX=y
BR2_PACKAGE_GNUTLS=y
BR2_PACKAGE_OPENSSL=y
BR2_PACKAGE_LIBKRB5=y
According to http://www.squid-cache.org/Versions/v4/RELEASENOTES.html#ss1.1
squid-4.2 depends on C++11, but adding -std=c++11 did not fix the build
error.
Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
package/squid/Config.in | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/package/squid/Config.in b/package/squid/Config.in
index c1eb25c6b9..aeffbc6579 100644
--- a/package/squid/Config.in
+++ b/package/squid/Config.in
@@ -1,10 +1,12 @@
-comment "squid needs a toolchain w/ C++"
+comment "squid needs a toolchain w/ C++ not affected by GCC bug 64735"
depends on BR2_USE_MMU
- depends on !BR2_INSTALL_LIBSTDCPP
+ depends on BR2_TOOLCHAIN_HAS_GCC_BUG_64735 || \
+ !BR2_INSTALL_LIBSTDCPP
config BR2_PACKAGE_SQUID
bool "squid"
depends on BR2_INSTALL_LIBSTDCPP
+ depends on !BR2_TOOLCHAIN_HAS_GCC_BUG_64735 # std::current_exception
# needs fork()
depends on BR2_USE_MMU
select BR2_PACKAGE_LIBCAP
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception
2018-08-24 20:01 [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception Bernd Kuhls
@ 2018-09-03 13:50 ` Giulio Benetti
2018-09-06 21:27 ` Thomas Petazzoni
2018-09-08 21:39 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: Giulio Benetti @ 2018-09-03 13:50 UTC (permalink / raw)
To: buildroot
Il 24/08/2018 22:01, bernd.kuhls at t-online.de (Bernd Kuhls) ha scritto:
> Fixes build error
>
> TextException.cc: In function 'std::ostream& CurrentException(std::ostream&)':
> TextException.cc:64:9: error: 'current_exception' is not a member of 'std'
> if (std::current_exception()) {
>
> using this defconfig
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/armv5-ctng-linux-gnueabi.tar.xz"
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="armv5-ctng-linux-gnueabi"
> BR2_TOOLCHAIN_EXTERNAL_GCC_4_8=y
> BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_12=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
> BR2_TOOLCHAIN_EXTERNAL_CXX=y
> BR2_PACKAGE_GNUTLS=y
> BR2_PACKAGE_OPENSSL=y
> BR2_PACKAGE_LIBKRB5=y
>
> According to http://www.squid-cache.org/Versions/v4/RELEASENOTES.html#ss1.1
> squid-4.2 depends on C++11, but adding -std=c++11 did not fix the build
> error.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Tested-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
Fixes:
http://autobuild.buildroot.net/results/273/273556771e957f109a1fbf446a5193aac49b72af/
http://autobuild.buildroot.net/results/9d2/9d2cde8494f69fedf0afc460d8e540d769a79212/
http://autobuild.buildroot.net/results/a71/a71db790ae3a3ea1836760edad504a92ea005cf7/
http://autobuild.buildroot.net/results/6fc/6fc05e2bb90120f43b19aace436837aafd82d999/
Best regards.
Giulio Benetti
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception
2018-08-24 20:01 [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception Bernd Kuhls
2018-09-03 13:50 ` Giulio Benetti
@ 2018-09-06 21:27 ` Thomas Petazzoni
2018-09-08 21:39 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-09-06 21:27 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 24 Aug 2018 22:01:07 +0200, Bernd Kuhls wrote:
> Fixes build error
>
> TextException.cc: In function 'std::ostream& CurrentException(std::ostream&)':
> TextException.cc:64:9: error: 'current_exception' is not a member of 'std'
> if (std::current_exception()) {
>
> using this defconfig
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/armv5-ctng-linux-gnueabi.tar.xz"
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="armv5-ctng-linux-gnueabi"
> BR2_TOOLCHAIN_EXTERNAL_GCC_4_8=y
> BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_12=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
> BR2_TOOLCHAIN_EXTERNAL_CXX=y
> BR2_PACKAGE_GNUTLS=y
> BR2_PACKAGE_OPENSSL=y
> BR2_PACKAGE_LIBKRB5=y
>
> According to http://www.squid-cache.org/Versions/v4/RELEASENOTES.html#ss1.1
> squid-4.2 depends on C++11, but adding -std=c++11 did not fix the build
> error.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
I have indeed verified that std::current_exception() is made available
to all platforms when the bug 64375 is fixed in gcc.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception
2018-08-24 20:01 [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception Bernd Kuhls
2018-09-03 13:50 ` Giulio Benetti
2018-09-06 21:27 ` Thomas Petazzoni
@ 2018-09-08 21:39 ` Thomas Petazzoni
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2018-09-08 21:39 UTC (permalink / raw)
To: buildroot
Hello,
On Fri, 24 Aug 2018 22:01:07 +0200, Bernd Kuhls wrote:
> Fixes build error
>
> TextException.cc: In function 'std::ostream& CurrentException(std::ostream&)':
> TextException.cc:64:9: error: 'current_exception' is not a member of 'std'
> if (std::current_exception()) {
>
> using this defconfig
>
> BR2_arm=y
> BR2_TOOLCHAIN_EXTERNAL=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM=y
> BR2_TOOLCHAIN_EXTERNAL_DOWNLOAD=y
> BR2_TOOLCHAIN_EXTERNAL_URL="http://autobuild.buildroot.org/toolchains/tarballs/armv5-ctng-linux-gnueabi.tar.xz"
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_PREFIX="armv5-ctng-linux-gnueabi"
> BR2_TOOLCHAIN_EXTERNAL_GCC_4_8=y
> BR2_TOOLCHAIN_EXTERNAL_HEADERS_3_12=y
> BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC=y
> BR2_TOOLCHAIN_EXTERNAL_CXX=y
> BR2_PACKAGE_GNUTLS=y
> BR2_PACKAGE_OPENSSL=y
> BR2_PACKAGE_LIBKRB5=y
>
> According to http://www.squid-cache.org/Versions/v4/RELEASENOTES.html#ss1.1
> squid-4.2 depends on C++11, but adding -std=c++11 did not fix the build
> error.
>
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> package/squid/Config.in | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-08 21:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 20:01 [Buildroot] [PATCH/next 1/1] package/squid: depends on current_exception Bernd Kuhls
2018-09-03 13:50 ` Giulio Benetti
2018-09-06 21:27 ` Thomas Petazzoni
2018-09-08 21:39 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.