* [PATCH] tmpfs: don't require TEST_DEV @ 2018-09-03 12:27 Miklos Szeredi 2018-09-09 14:56 ` Eryu Guan 0 siblings, 1 reply; 4+ messages in thread From: Miklos Szeredi @ 2018-09-03 12:27 UTC (permalink / raw) To: Eryu Guan; +Cc: fstests tmpfs doesn't require a device and the source argument of the mount is ignored. If TEST_DEV is not given then set it to "none". Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> --- common/config | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/common/config b/common/config index 2f1f27206776..40c2b399a3c7 100644 --- a/common/config +++ b/common/config @@ -456,8 +456,9 @@ _check_device() fi case "$FSTYP" in - 9p) + 9p|tmpfs) # 9p mount tags are just plain strings, so anything is allowed + # tmpfs doesn't use mount source, ignore ;; overlay) if [ ! -d "$dev" ]; then @@ -657,6 +658,10 @@ get_next_config() { export RESULT_BASE="$here/results/" fi + if [ "$FSTYP" == tmpfs -a -z "$TEST_DEV" ]; then + export TEST_DEV=none + fi + # Mandatory Config values. MC="" [ -z "$EMAIL" ] && MC="$MC EMAIL" -- 2.14.3 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tmpfs: don't require TEST_DEV 2018-09-03 12:27 [PATCH] tmpfs: don't require TEST_DEV Miklos Szeredi @ 2018-09-09 14:56 ` Eryu Guan 2018-09-09 19:07 ` Miklos Szeredi 0 siblings, 1 reply; 4+ messages in thread From: Eryu Guan @ 2018-09-09 14:56 UTC (permalink / raw) To: Miklos Szeredi; +Cc: fstests On Mon, Sep 03, 2018 at 02:27:28PM +0200, Miklos Szeredi wrote: > tmpfs doesn't require a device and the source argument of the mount is ignored. > If TEST_DEV is not given then set it to "none". > > Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> > --- > common/config | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/common/config b/common/config > index 2f1f27206776..40c2b399a3c7 100644 > --- a/common/config > +++ b/common/config > @@ -456,8 +456,9 @@ _check_device() > fi > > case "$FSTYP" in > - 9p) > + 9p|tmpfs) > # 9p mount tags are just plain strings, so anything is allowed > + # tmpfs doesn't use mount source, ignore > ;; > overlay) > if [ ! -d "$dev" ]; then > @@ -657,6 +658,10 @@ get_next_config() { > export RESULT_BASE="$here/results/" > fi > > + if [ "$FSTYP" == tmpfs -a -z "$TEST_DEV" ]; then > + export TEST_DEV=none > + fi > + Looks like we could ignore SCRATCH_DEV as well, just set it to a different name. I'll just update it on commit. Thanks, Eryu > # Mandatory Config values. > MC="" > [ -z "$EMAIL" ] && MC="$MC EMAIL" > -- > 2.14.3 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tmpfs: don't require TEST_DEV 2018-09-09 14:56 ` Eryu Guan @ 2018-09-09 19:07 ` Miklos Szeredi 2018-09-10 4:32 ` Eryu Guan 0 siblings, 1 reply; 4+ messages in thread From: Miklos Szeredi @ 2018-09-09 19:07 UTC (permalink / raw) To: Eryu Guan; +Cc: fstests On Sun, Sep 9, 2018 at 4:56 PM, Eryu Guan <guaneryu@gmail.com> wrote: > On Mon, Sep 03, 2018 at 02:27:28PM +0200, Miklos Szeredi wrote: >> tmpfs doesn't require a device and the source argument of the mount is ignored. >> If TEST_DEV is not given then set it to "none". >> >> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> >> --- >> common/config | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/common/config b/common/config >> index 2f1f27206776..40c2b399a3c7 100644 >> --- a/common/config >> +++ b/common/config >> @@ -456,8 +456,9 @@ _check_device() >> fi >> >> case "$FSTYP" in >> - 9p) >> + 9p|tmpfs) >> # 9p mount tags are just plain strings, so anything is allowed >> + # tmpfs doesn't use mount source, ignore >> ;; >> overlay) >> if [ ! -d "$dev" ]; then >> @@ -657,6 +658,10 @@ get_next_config() { >> export RESULT_BASE="$here/results/" >> fi >> >> + if [ "$FSTYP" == tmpfs -a -z "$TEST_DEV" ]; then >> + export TEST_DEV=none >> + fi >> + > > Looks like we could ignore SCRATCH_DEV as well, just set it to a > different name. I'll just update it on commit. Actually, no need to set it to a different name, since the $DEV argument of tmpfs is completely ignored (just like proc, sys, etc). Thanks, Miklos ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tmpfs: don't require TEST_DEV 2018-09-09 19:07 ` Miklos Szeredi @ 2018-09-10 4:32 ` Eryu Guan 0 siblings, 0 replies; 4+ messages in thread From: Eryu Guan @ 2018-09-10 4:32 UTC (permalink / raw) To: Miklos Szeredi; +Cc: fstests On Sun, Sep 09, 2018 at 09:07:52PM +0200, Miklos Szeredi wrote: > On Sun, Sep 9, 2018 at 4:56 PM, Eryu Guan <guaneryu@gmail.com> wrote: > > On Mon, Sep 03, 2018 at 02:27:28PM +0200, Miklos Szeredi wrote: > >> tmpfs doesn't require a device and the source argument of the mount is ignored. > >> If TEST_DEV is not given then set it to "none". > >> > >> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com> > >> --- > >> common/config | 7 ++++++- > >> 1 file changed, 6 insertions(+), 1 deletion(-) > >> > >> diff --git a/common/config b/common/config > >> index 2f1f27206776..40c2b399a3c7 100644 > >> --- a/common/config > >> +++ b/common/config > >> @@ -456,8 +456,9 @@ _check_device() > >> fi > >> > >> case "$FSTYP" in > >> - 9p) > >> + 9p|tmpfs) > >> # 9p mount tags are just plain strings, so anything is allowed > >> + # tmpfs doesn't use mount source, ignore > >> ;; > >> overlay) > >> if [ ! -d "$dev" ]; then > >> @@ -657,6 +658,10 @@ get_next_config() { > >> export RESULT_BASE="$here/results/" > >> fi > >> > >> + if [ "$FSTYP" == tmpfs -a -z "$TEST_DEV" ]; then > >> + export TEST_DEV=none > >> + fi > >> + > > > > Looks like we could ignore SCRATCH_DEV as well, just set it to a > > different name. I'll just update it on commit. > > Actually, no need to set it to a different name, since the $DEV > argument of tmpfs is completely ignored (just like proc, sys, etc). That's true. But fstests will check if the device is mounted or not based on the device name, so if TEST_DEV is already mounted with "none" and SCRATCH_DEV shares the same name, fstests will find SCRATCH_DEV already mounted at a wrong path and exit. Thanks, Eryu ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-10 9:24 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2018-09-03 12:27 [PATCH] tmpfs: don't require TEST_DEV Miklos Szeredi 2018-09-09 14:56 ` Eryu Guan 2018-09-09 19:07 ` Miklos Szeredi 2018-09-10 4:32 ` Eryu Guan
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.