* [PATCH] drm/amdgpu: move PSP init prior to IH in gpu reset
@ 2018-09-10 6:13 Emily Deng
[not found] ` <1536559989-19549-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Emily Deng @ 2018-09-10 6:13 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Emily Deng, Monk Liu
since we use PSP to program IH regs now
Signed-off-by: Monk Liu <Monk.Liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 93476b8..acfc63e 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -1957,6 +1957,7 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
static enum amd_ip_block_type ip_order[] = {
AMD_IP_BLOCK_TYPE_GMC,
AMD_IP_BLOCK_TYPE_COMMON,
+ AMD_IP_BLOCK_TYPE_PSP,
AMD_IP_BLOCK_TYPE_IH,
};
@@ -1987,7 +1988,6 @@ static int amdgpu_device_ip_reinit_late_sriov(struct amdgpu_device *adev)
static enum amd_ip_block_type ip_order[] = {
AMD_IP_BLOCK_TYPE_SMC,
- AMD_IP_BLOCK_TYPE_PSP,
AMD_IP_BLOCK_TYPE_DCE,
AMD_IP_BLOCK_TYPE_GFX,
AMD_IP_BLOCK_TYPE_SDMA,
--
2.7.4
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: move PSP init prior to IH in gpu reset
[not found] ` <1536559989-19549-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
@ 2018-09-10 7:07 ` Christian König
2018-09-10 9:46 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2018-09-10 7:07 UTC (permalink / raw)
To: Emily Deng, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Monk Liu
Am 10.09.2018 um 08:13 schrieb Emily Deng:
> since we use PSP to program IH regs now
>
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 93476b8..acfc63e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1957,6 +1957,7 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
> static enum amd_ip_block_type ip_order[] = {
> AMD_IP_BLOCK_TYPE_GMC,
> AMD_IP_BLOCK_TYPE_COMMON,
> + AMD_IP_BLOCK_TYPE_PSP,
> AMD_IP_BLOCK_TYPE_IH,
> };
>
> @@ -1987,7 +1988,6 @@ static int amdgpu_device_ip_reinit_late_sriov(struct amdgpu_device *adev)
>
> static enum amd_ip_block_type ip_order[] = {
> AMD_IP_BLOCK_TYPE_SMC,
> - AMD_IP_BLOCK_TYPE_PSP,
> AMD_IP_BLOCK_TYPE_DCE,
> AMD_IP_BLOCK_TYPE_GFX,
> AMD_IP_BLOCK_TYPE_SDMA,
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: move PSP init prior to IH in gpu reset
[not found] ` <1536559989-19549-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2018-09-10 7:07 ` Christian König
@ 2018-09-10 9:46 ` Huang Rui
1 sibling, 0 replies; 3+ messages in thread
From: Huang Rui @ 2018-09-10 9:46 UTC (permalink / raw)
To: Emily Deng; +Cc: Monk Liu, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
On Mon, Sep 10, 2018 at 02:13:09PM +0800, Emily Deng wrote:
> since we use PSP to program IH regs now
>
> Signed-off-by: Monk Liu <Monk.Liu@amd.com>
Reviewed-by: Huang Rui <ray.huang@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 93476b8..acfc63e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1957,6 +1957,7 @@ static int amdgpu_device_ip_reinit_early_sriov(struct amdgpu_device *adev)
> static enum amd_ip_block_type ip_order[] = {
> AMD_IP_BLOCK_TYPE_GMC,
> AMD_IP_BLOCK_TYPE_COMMON,
> + AMD_IP_BLOCK_TYPE_PSP,
> AMD_IP_BLOCK_TYPE_IH,
> };
>
> @@ -1987,7 +1988,6 @@ static int amdgpu_device_ip_reinit_late_sriov(struct amdgpu_device *adev)
>
> static enum amd_ip_block_type ip_order[] = {
> AMD_IP_BLOCK_TYPE_SMC,
> - AMD_IP_BLOCK_TYPE_PSP,
> AMD_IP_BLOCK_TYPE_DCE,
> AMD_IP_BLOCK_TYPE_GFX,
> AMD_IP_BLOCK_TYPE_SDMA,
BTW, PSP should be loaded before SMC, because SMC ucode needs to be loaded
by PSP.
Thanks,
Ray
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-09-10 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-10 6:13 [PATCH] drm/amdgpu: move PSP init prior to IH in gpu reset Emily Deng
[not found] ` <1536559989-19549-1-git-send-email-Emily.Deng-5C7GfCeVMHo@public.gmane.org>
2018-09-10 7:07 ` Christian König
2018-09-10 9:46 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.