All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: open sets ext4_da_aops for DAX existing files
Date: Mon, 10 Sep 2018 16:29:02 +0200	[thread overview]
Message-ID: <20180910142902.GA30197@quack2.suse.cz> (raw)
In-Reply-To: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com>

On Fri 07-09-18 21:23:19, Kani, Toshi wrote:
> I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX
> mounted ext4 files.  Looking at open() path:
> 
> New file
> --------
>   lookup_open
>     ext4_create
>       __ext4_new_inode
>         ext4_set_inode_flags   // Set S_DAX flag
>       ext4_set_aops            // Set aops to ext4_dax_aops
> 
> Existing file
> -------------
>   lookup_open
>     ext4_lookup
>       ext4_iget
>         ext4_set_aops          // Set aops to ext4_da_aops
>         ext4_set_inode_flags   // Set S_DAX flag
> 
> So, we set ext4_da_aops for existing files since S_DAX flag is set after
> ext4_set_aops().

Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier
in the ext4_iget()? Did this bug have any user visible manifestations?
Please also add:

Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086

so that stable automation picks this up. Thanks!

								Honza
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: "Kani, Toshi" <toshi.kani@hpe.com>
Cc: "linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: open sets ext4_da_aops for DAX existing files
Date: Mon, 10 Sep 2018 16:29:02 +0200	[thread overview]
Message-ID: <20180910142902.GA30197@quack2.suse.cz> (raw)
In-Reply-To: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com>

On Fri 07-09-18 21:23:19, Kani, Toshi wrote:
> I noticed that both ext4_da_aops and ext4_dax_aops are used on DAX
> mounted ext4 files.  Looking at open() path:
> 
> New file
> --------
>   lookup_open
>     ext4_create
>       __ext4_new_inode
>         ext4_set_inode_flags   // Set S_DAX flag
>       ext4_set_aops            // Set aops to ext4_dax_aops
> 
> Existing file
> -------------
>   lookup_open
>     ext4_lookup
>       ext4_iget
>         ext4_set_aops          // Set aops to ext4_da_aops
>         ext4_set_inode_flags   // Set S_DAX flag
> 
> So, we set ext4_da_aops for existing files since S_DAX flag is set after
> ext4_set_aops().

Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier
in the ext4_iget()? Did this bug have any user visible manifestations?
Please also add:

Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086

so that stable automation picks this up. Thanks!

								Honza

  parent reply	other threads:[~2018-09-10 14:29 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 21:23 open sets ext4_da_aops for DAX existing files Kani, Toshi
2018-09-07 21:23 ` Kani, Toshi
2018-09-10 12:54 ` Jeff Moyer
2018-09-10 12:54   ` Jeff Moyer
2018-09-10 14:21   ` Kani, Toshi
2018-09-10 14:21     ` Kani, Toshi
2018-09-10 14:26     ` Dan Williams
2018-09-10 14:26       ` Dan Williams
2018-09-10 14:29 ` Jan Kara [this message]
2018-09-10 14:29   ` Jan Kara
2018-09-10 14:51   ` Kani, Toshi
2018-09-10 14:51     ` Kani, Toshi
2018-09-10 17:58     ` Elliott, Robert (Persistent Memory)
2018-09-10 17:58       ` Elliott, Robert (Persistent Memory)
2018-09-11 15:27       ` Jan Kara
2018-09-11 15:27         ` Jan Kara
2018-09-11 16:34         ` Kani, Toshi
2018-09-11 16:34           ` Kani, Toshi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910142902.GA30197@quack2.suse.cz \
    --to=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nvdimm@lists.01.org \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.