All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] shairport-sync: add upstream patch to fix soxr configure issue
Date: Mon, 10 Sep 2018 17:37:54 +0200	[thread overview]
Message-ID: <20180910173754.61fc84ab@windsurf> (raw)
In-Reply-To: <20180909094317.10873-1-joerg.krause@embedded.rocks>

Hello,

On Sun,  9 Sep 2018 11:43:17 +0200, J?rg Krause wrote:
> Commit b06639cf7a adds an upstream patch to fix a build issue with soxr.
> The patch also adds detecting soxr using pkg-config. Upstream detected
> an config issue [1], where the resulting binary lacks soxr support, although
> libsoxr was correctly detected.
> 
> This patch adds a define for `HAVE_LIBSOXR` when using pkg-config.
> 
> Backported from: cd6a99a7cfde1c5e1c1cc74ee6a77041bb4012d9
> 
> [1] https://github.com/mikebrady/shairport-sync/issues/740
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>

Thanks for the additional explanations you have given, I have applied
after fixing the reference to the previous commit in the commit log. I
however have one request below.

> diff --git a/package/shairport-sync/0002-Include-a-definition-of-HAVE_LIBSOXR-with-using-pkg_config.patch b/package/shairport-sync/0002-Include-a-definition-of-HAVE_LIBSOXR-with-using-pkg_config.patch
> new file mode 100644
> index 0000000000..e10142a201
> --- /dev/null
> +++ b/package/shairport-sync/0002-Include-a-definition-of-HAVE_LIBSOXR-with-using-pkg_config.patch
> @@ -0,0 +1,34 @@
> +From cd6a99a7cfde1c5e1c1cc74ee6a77041bb4012d9 Mon Sep 17 00:00:00 2001
> +From: Mike Brady <mikebrady@eircom.net>
> +Date: Sat, 8 Sep 2018 15:06:18 +0100
> +Subject: [PATCH] Include a definition of HAVE_LIBSOXR with using pkg_config
> +MIME-Version: 1.0
> +Content-Type: text/plain; charset=UTF-8
> +Content-Transfer-Encoding: 8bit
> +
> +Commit b06639cf7a adds an upstream patch to fix a build issue with soxr.

The patch descriptions should ideally not refer to Buildroot or
Buildroot commits. Indeed, they should ideally be just the upstream
patch, or a patch acceptable by upstream. A patch that talks about
Buildroot commits is unlikely to be accepted upstream.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  parent reply	other threads:[~2018-09-10 15:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09  9:43 [Buildroot] [PATCH] shairport-sync: add upstream patch to fix soxr configure issue Jörg Krause
2018-09-09 13:13 ` Thomas Petazzoni
2018-09-09 19:03   ` Jörg Krause
2018-09-10 15:37 ` Thomas Petazzoni [this message]
2018-10-01 18:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180910173754.61fc84ab@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.