All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jörg Krause" <joerg.krause@embedded.rocks>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] shairport-sync: add upstream patch to fix soxr configure issue
Date: Sun, 09 Sep 2018 21:03:57 +0200	[thread overview]
Message-ID: <37290764ba05504ae3c5b862de98989528fb35e5.camel@embedded.rocks> (raw)
In-Reply-To: <20180909151344.2eadead8@windsurf.home>

Hi,

On Sun, 2018-09-09 at 15:13 +0200, Thomas Petazzoni wrote:
> Hello,
> 
> On Sun,  9 Sep 2018 11:43:17 +0200, J?rg Krause wrote:
> > Commit b06639cf7a adds an upstream patch to fix a build issue with soxr.
> 
> I don't have any commit with the hash b06639cf7a in Buildroot. Are you
> talking about e047dee241fe0660d92311a124757065c6c4c93d instead ?

Sorry. Yes, I am talking about
e047dee241fe0660d92311a124757065c6c4c93d. My bad!

> > Should be committed to 2018.02.x and 2018.05.x, too.
> 
> Well e047dee241fe0660d92311a124757065c6c4c93d was not backported to
> 2018.02.x and 2018.05.x.

The commit for 2018.02.x is 2aafa0366f0fe73afdf97a9a52917b2f1dbdf392
[1] and for 2018.05.x is 72f10180f5cbc6f4f3914e4a142d25e13c322f08

> Are you sure 2018.02.x and 2018.05.x are
> affected by the soxr build issue that
> e047dee241fe0660d92311a124757065c6c4c93d is fixing ? Indeed, I don't
> see any autobuilder failure:
> http://autobuild.buildroot.net/?reason=shairport%.

Peter commited the patch to 2018.02.x and 2018.05.x [3]. You're right,
there aren't any autobuild failures and I didn't checked these branches
for the build failure back then.

[1] https://git.buildroot.net/buildroot/commit/?h=2018.02.x&id=2aafa0366f0fe73afdf97a9a52917b2f1dbdf392
[2] https://git.buildroot.net/buildroot/commit/?h=2018.05.x&id=72f10180f5cbc6f4f3914e4a142d25e13c322f08
[3] https://patchwork.ozlabs.org/patch/962789/

Best regards,
J?rg Krause

  reply	other threads:[~2018-09-09 19:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-09  9:43 [Buildroot] [PATCH] shairport-sync: add upstream patch to fix soxr configure issue Jörg Krause
2018-09-09 13:13 ` Thomas Petazzoni
2018-09-09 19:03   ` Jörg Krause [this message]
2018-09-10 15:37 ` Thomas Petazzoni
2018-10-01 18:31 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37290764ba05504ae3c5b862de98989528fb35e5.camel@embedded.rocks \
    --to=joerg.krause@embedded.rocks \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.