From: LABBE Corentin <clabbe@baylibre.com>
To: Christophe LEROY <christophe.leroy@c-s.fr>
Cc: Gilles.Muller@lip6.fr, Julia.Lawall@lip6.fr, agust@denx.de,
alexandre.torgue@st.com, alistair@popple.id.au,
benh@kernel.crashing.org, carlo@caione.org, davem@davemloft.net,
galak@kernel.crashing.org, joabreu@synopsys.com,
khilman@baylibre.com, maxime.ripard@bootlin.com,
michal.lkml@markovi.net, mpe@ellerman.id.au,
mporter@kernel.crashing.org, nicolas.palix@imag.fr,
oss@buserror.net, paulus@samba.org, peppe.cavallaro@st.com,
tj@kernel.org, vitb@kernel.crashing.org, wens@csie.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, linux-sunxi@googlegroups.com,
linux-amlogic@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
cocci@systeme.lip6.fr, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be
Date: Mon, 10 Sep 2018 20:50:39 +0200 [thread overview]
Message-ID: <20180910185039.GB7819@Red> (raw)
In-Reply-To: <d16bf608-5b97-4baf-2ac1-a6d98656d716@c-s.fr>
On Mon, Sep 10, 2018 at 07:16:56AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 à 21:41, Corentin Labbe a écrit :
> > Since setbits32/clrbits32 work on be32, it's better to remove ambiguity on
> > the used data type.
>
> Wouldn't it be better to call them setbits_be32() / clrbits_be32() to
> have something looking similar to in_be32() / ou_be32() ?
>
I agree, I will update the patch.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: clabbe@baylibre.com (LABBE Corentin)
To: cocci@systeme.lip6.fr
Subject: [Cocci] [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be
Date: Mon, 10 Sep 2018 20:50:39 +0200 [thread overview]
Message-ID: <20180910185039.GB7819@Red> (raw)
In-Reply-To: <d16bf608-5b97-4baf-2ac1-a6d98656d716@c-s.fr>
On Mon, Sep 10, 2018 at 07:16:56AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > Since setbits32/clrbits32 work on be32, it's better to remove ambiguity on
> > the used data type.
>
> Wouldn't it be better to call them setbits_be32() / clrbits_be32() to
> have something looking similar to in_be32() / ou_be32() ?
>
I agree, I will update the patch.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: clabbe@baylibre.com (LABBE Corentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be
Date: Mon, 10 Sep 2018 20:50:39 +0200 [thread overview]
Message-ID: <20180910185039.GB7819@Red> (raw)
In-Reply-To: <d16bf608-5b97-4baf-2ac1-a6d98656d716@c-s.fr>
On Mon, Sep 10, 2018 at 07:16:56AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > Since setbits32/clrbits32 work on be32, it's better to remove ambiguity on
> > the used data type.
>
> Wouldn't it be better to call them setbits_be32() / clrbits_be32() to
> have something looking similar to in_be32() / ou_be32() ?
>
I agree, I will update the patch.
Thanks
WARNING: multiple messages have this Message-ID (diff)
From: clabbe@baylibre.com (LABBE Corentin)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be
Date: Mon, 10 Sep 2018 20:50:39 +0200 [thread overview]
Message-ID: <20180910185039.GB7819@Red> (raw)
In-Reply-To: <d16bf608-5b97-4baf-2ac1-a6d98656d716@c-s.fr>
On Mon, Sep 10, 2018 at 07:16:56AM +0200, Christophe LEROY wrote:
>
>
> Le 07/09/2018 ? 21:41, Corentin Labbe a ?crit?:
> > Since setbits32/clrbits32 work on be32, it's better to remove ambiguity on
> > the used data type.
>
> Wouldn't it be better to call them setbits_be32() / clrbits_be32() to
> have something looking similar to in_be32() / ou_be32() ?
>
I agree, I will update the patch.
Thanks
next prev parent reply other threads:[~2018-09-10 18:50 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-07 19:41 [PATCH 0/5] introduce setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 functions Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-07 19:41 ` [PATCH 1/5] powerpc: rename setbits32/clrbits32 to setbits32_be/clrbits32_be Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 5:16 ` Christophe LEROY
2018-09-10 5:16 ` [Cocci] " Christophe LEROY
2018-09-10 18:50 ` LABBE Corentin [this message]
2018-09-10 18:50 ` LABBE Corentin
2018-09-10 18:50 ` LABBE Corentin
2018-09-10 18:50 ` [Cocci] " LABBE Corentin
2018-09-07 19:41 ` [PATCH 2/5] include: add setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 in linux/setbits.h Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-07 20:00 ` Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-07 20:00 ` [Cocci] " Scott Wood
2018-09-07 20:00 ` Scott Wood
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 18:49 ` LABBE Corentin
2018-09-10 18:49 ` [Cocci] " LABBE Corentin
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 5:22 ` Christophe LEROY
2018-09-10 5:22 ` [Cocci] " Christophe LEROY
2018-09-10 18:53 ` LABBE Corentin
2018-09-10 18:53 ` LABBE Corentin
2018-09-10 18:53 ` LABBE Corentin
2018-09-10 18:53 ` [Cocci] " LABBE Corentin
2018-09-07 19:41 ` [PATCH RFC 3/5] coccinelle: add xxxsetbitsXX converting spatch Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-09 11:13 ` SF Markus Elfring
2018-09-07 19:41 ` [PATCH 4/5] net: ethernet: stmmac: use xxxsetbits32 Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-07 19:41 ` [PATCH 5/5] ata: ahci_sunxi: use xxxsetbits32 functions Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` Corentin Labbe
2018-09-07 19:41 ` [Cocci] " Corentin Labbe
2018-09-07 21:57 ` [PATCH 0/5] introduce setbits32/clrbits32/clrsetbits32/setbits64/clrbits64/clrsetbits64 functions David Miller
2018-09-07 21:57 ` David Miller
2018-09-07 21:57 ` David Miller
2018-09-07 21:57 ` [Cocci] " David Miller
2018-09-10 5:24 ` Christophe LEROY
2018-09-10 5:24 ` Christophe LEROY
2018-09-10 5:24 ` Christophe LEROY
2018-09-10 5:24 ` [Cocci] " Christophe LEROY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180910185039.GB7819@Red \
--to=clabbe@baylibre.com \
--cc=Gilles.Muller@lip6.fr \
--cc=Julia.Lawall@lip6.fr \
--cc=agust@denx.de \
--cc=alexandre.torgue@st.com \
--cc=alistair@popple.id.au \
--cc=benh@kernel.crashing.org \
--cc=carlo@caione.org \
--cc=christophe.leroy@c-s.fr \
--cc=cocci@systeme.lip6.fr \
--cc=davem@davemloft.net \
--cc=galak@kernel.crashing.org \
--cc=joabreu@synopsys.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maxime.ripard@bootlin.com \
--cc=michal.lkml@markovi.net \
--cc=mpe@ellerman.id.au \
--cc=mporter@kernel.crashing.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=oss@buserror.net \
--cc=paulus@samba.org \
--cc=peppe.cavallaro@st.com \
--cc=tj@kernel.org \
--cc=vitb@kernel.crashing.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.