All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
@ 2018-09-07 13:38 ` Eugen Hristev
  0 siblings, 0 replies; 6+ messages in thread
From: Eugen Hristev @ 2018-09-07 13:38 UTC (permalink / raw)
  To: alexandre.belloni, nicolas.ferre, ludovic.desroches,
	linux-arm-kernel, linux-kernel
  Cc: Eugen Hristev

This adds labels to commonly used device-tree nodes so that derivative
boards can avoid ahb/apb hierarchy.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---

Hello,

This was already done for SoC sama5d3 and sam9x5, in commit:
"fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")

This commit will do basically the same thing for sama5d4 SoC.

Based on top of at91-next branch of at91.git

Thanks.

 arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index 92a35a1..7371f2a 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1323,13 +1323,13 @@
 				};
 			};
 
-			rstc@fc068600 {
+			reset_controller: rstc@fc068600 {
 				compatible = "atmel,sama5d3-rstc", "atmel,at91sam9g45-rstc";
 				reg = <0xfc068600 0x10>;
 				clocks = <&clk32k>;
 			};
 
-			shdwc@fc068610 {
+			shutdown_controller: shdwc@fc068610 {
 				compatible = "atmel,at91sam9x5-shdwc";
 				reg = <0xfc068610 0x10>;
 				clocks = <&clk32k>;
@@ -1342,7 +1342,7 @@
 				clocks = <&h32ck>;
 			};
 
-			watchdog@fc068640 {
+			watchdog: watchdog@fc068640 {
 				compatible = "atmel,sama5d4-wdt";
 				reg = <0xfc068640 0x10>;
 				interrupts = <4 IRQ_TYPE_LEVEL_HIGH 7>;
@@ -1376,7 +1376,7 @@
 			};
 
 
-			pinctrl@fc06a000 {
+			pinctrl: pinctrl@fc06a000 {
 				#address-cells = <1>;
 				#size-cells = <1>;
 				compatible = "atmel,sama5d3-pinctrl", "atmel,at91sam9x5-pinctrl", "simple-bus";
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
@ 2018-09-07 13:38 ` Eugen Hristev
  0 siblings, 0 replies; 6+ messages in thread
From: Eugen Hristev @ 2018-09-07 13:38 UTC (permalink / raw)
  To: linux-arm-kernel

This adds labels to commonly used device-tree nodes so that derivative
boards can avoid ahb/apb hierarchy.

Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
---

Hello,

This was already done for SoC sama5d3 and sam9x5, in commit:
"fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")

This commit will do basically the same thing for sama5d4 SoC.

Based on top of at91-next branch of at91.git

Thanks.

 arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
index 92a35a1..7371f2a 100644
--- a/arch/arm/boot/dts/sama5d4.dtsi
+++ b/arch/arm/boot/dts/sama5d4.dtsi
@@ -1323,13 +1323,13 @@
 				};
 			};
 
-			rstc at fc068600 {
+			reset_controller: rstc at fc068600 {
 				compatible = "atmel,sama5d3-rstc", "atmel,at91sam9g45-rstc";
 				reg = <0xfc068600 0x10>;
 				clocks = <&clk32k>;
 			};
 
-			shdwc at fc068610 {
+			shutdown_controller: shdwc at fc068610 {
 				compatible = "atmel,at91sam9x5-shdwc";
 				reg = <0xfc068610 0x10>;
 				clocks = <&clk32k>;
@@ -1342,7 +1342,7 @@
 				clocks = <&h32ck>;
 			};
 
-			watchdog at fc068640 {
+			watchdog: watchdog at fc068640 {
 				compatible = "atmel,sama5d4-wdt";
 				reg = <0xfc068640 0x10>;
 				interrupts = <4 IRQ_TYPE_LEVEL_HIGH 7>;
@@ -1376,7 +1376,7 @@
 			};
 
 
-			pinctrl at fc06a000 {
+			pinctrl: pinctrl at fc06a000 {
 				#address-cells = <1>;
 				#size-cells = <1>;
 				compatible = "atmel,sama5d3-pinctrl", "atmel,at91sam9x5-pinctrl", "simple-bus";
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
  2018-09-07 13:38 ` Eugen Hristev
@ 2018-09-07 14:57   ` Ludovic Desroches
  -1 siblings, 0 replies; 6+ messages in thread
From: Ludovic Desroches @ 2018-09-07 14:57 UTC (permalink / raw)
  To: Eugen Hristev
  Cc: alexandre.belloni, nicolas.ferre, linux-arm-kernel, linux-kernel

Hi Eugen,

On Fri, Sep 07, 2018 at 04:38:09PM +0300, Eugen Hristev wrote:
> This adds labels to commonly used device-tree nodes so that derivative
> boards can avoid ahb/apb hierarchy.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> 
> Hello,
> 
> This was already done for SoC sama5d3 and sam9x5, in commit:
> "fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")
> 
> This commit will do basically the same thing for sama5d4 SoC.

Even if it's a mimic of what has been done for other SoCs, it could be
worth doing it for all peripherals: trng, aes, tdes and sha are still
missing a label.

Otherwise
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Regards

Ludovic

> 
> Based on top of at91-next branch of at91.git
> 
> Thanks.
> 
>  arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 92a35a1..7371f2a 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1323,13 +1323,13 @@
>  				};
>  			};
>  
> -			rstc@fc068600 {
> +			reset_controller: rstc@fc068600 {
>  				compatible = "atmel,sama5d3-rstc", "atmel,at91sam9g45-rstc";
>  				reg = <0xfc068600 0x10>;
>  				clocks = <&clk32k>;
>  			};
>  
> -			shdwc@fc068610 {
> +			shutdown_controller: shdwc@fc068610 {
>  				compatible = "atmel,at91sam9x5-shdwc";
>  				reg = <0xfc068610 0x10>;
>  				clocks = <&clk32k>;
> @@ -1342,7 +1342,7 @@
>  				clocks = <&h32ck>;
>  			};
>  
> -			watchdog@fc068640 {
> +			watchdog: watchdog@fc068640 {
>  				compatible = "atmel,sama5d4-wdt";
>  				reg = <0xfc068640 0x10>;
>  				interrupts = <4 IRQ_TYPE_LEVEL_HIGH 7>;
> @@ -1376,7 +1376,7 @@
>  			};
>  
>  
> -			pinctrl@fc06a000 {
> +			pinctrl: pinctrl@fc06a000 {
>  				#address-cells = <1>;
>  				#size-cells = <1>;
>  				compatible = "atmel,sama5d3-pinctrl", "atmel,at91sam9x5-pinctrl", "simple-bus";
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
@ 2018-09-07 14:57   ` Ludovic Desroches
  0 siblings, 0 replies; 6+ messages in thread
From: Ludovic Desroches @ 2018-09-07 14:57 UTC (permalink / raw)
  To: linux-arm-kernel

Hi Eugen,

On Fri, Sep 07, 2018 at 04:38:09PM +0300, Eugen Hristev wrote:
> This adds labels to commonly used device-tree nodes so that derivative
> boards can avoid ahb/apb hierarchy.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> 
> Hello,
> 
> This was already done for SoC sama5d3 and sam9x5, in commit:
> "fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")
> 
> This commit will do basically the same thing for sama5d4 SoC.

Even if it's a mimic of what has been done for other SoCs, it could be
worth doing it for all peripherals: trng, aes, tdes and sha are still
missing a label.

Otherwise
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>

Regards

Ludovic

> 
> Based on top of at91-next branch of at91.git
> 
> Thanks.
> 
>  arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/sama5d4.dtsi b/arch/arm/boot/dts/sama5d4.dtsi
> index 92a35a1..7371f2a 100644
> --- a/arch/arm/boot/dts/sama5d4.dtsi
> +++ b/arch/arm/boot/dts/sama5d4.dtsi
> @@ -1323,13 +1323,13 @@
>  				};
>  			};
>  
> -			rstc at fc068600 {
> +			reset_controller: rstc at fc068600 {
>  				compatible = "atmel,sama5d3-rstc", "atmel,at91sam9g45-rstc";
>  				reg = <0xfc068600 0x10>;
>  				clocks = <&clk32k>;
>  			};
>  
> -			shdwc at fc068610 {
> +			shutdown_controller: shdwc at fc068610 {
>  				compatible = "atmel,at91sam9x5-shdwc";
>  				reg = <0xfc068610 0x10>;
>  				clocks = <&clk32k>;
> @@ -1342,7 +1342,7 @@
>  				clocks = <&h32ck>;
>  			};
>  
> -			watchdog at fc068640 {
> +			watchdog: watchdog at fc068640 {
>  				compatible = "atmel,sama5d4-wdt";
>  				reg = <0xfc068640 0x10>;
>  				interrupts = <4 IRQ_TYPE_LEVEL_HIGH 7>;
> @@ -1376,7 +1376,7 @@
>  			};
>  
>  
> -			pinctrl at fc06a000 {
> +			pinctrl: pinctrl at fc06a000 {
>  				#address-cells = <1>;
>  				#size-cells = <1>;
>  				compatible = "atmel,sama5d3-pinctrl", "atmel,at91sam9x5-pinctrl", "simple-bus";
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
  2018-09-07 13:38 ` Eugen Hristev
@ 2018-09-12 10:40   ` Alexandre Belloni
  -1 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2018-09-12 10:40 UTC (permalink / raw)
  To: Eugen Hristev
  Cc: nicolas.ferre, ludovic.desroches, linux-arm-kernel, linux-kernel

On 07/09/2018 16:38:09+0300, Eugen Hristev wrote:
> This adds labels to commonly used device-tree nodes so that derivative
> boards can avoid ahb/apb hierarchy.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> 
> Hello,
> 
> This was already done for SoC sama5d3 and sam9x5, in commit:
> "fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")
> 
> This commit will do basically the same thing for sama5d4 SoC.
> 
> Based on top of at91-next branch of at91.git
> 
> Thanks.
> 
>  arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards
@ 2018-09-12 10:40   ` Alexandre Belloni
  0 siblings, 0 replies; 6+ messages in thread
From: Alexandre Belloni @ 2018-09-12 10:40 UTC (permalink / raw)
  To: linux-arm-kernel

On 07/09/2018 16:38:09+0300, Eugen Hristev wrote:
> This adds labels to commonly used device-tree nodes so that derivative
> boards can avoid ahb/apb hierarchy.
> 
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> 
> Hello,
> 
> This was already done for SoC sama5d3 and sam9x5, in commit:
> "fc37204432d" ("ARM: dts: at91: add labels to soc dtsi for derivative boards")
> 
> This commit will do basically the same thing for sama5d4 SoC.
> 
> Based on top of at91-next branch of at91.git
> 
> Thanks.
> 
>  arch/arm/boot/dts/sama5d4.dtsi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
Applied, thanks.

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-12 10:40 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-07 13:38 [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards Eugen Hristev
2018-09-07 13:38 ` Eugen Hristev
2018-09-07 14:57 ` Ludovic Desroches
2018-09-07 14:57   ` Ludovic Desroches
2018-09-12 10:40 ` Alexandre Belloni
2018-09-12 10:40   ` Alexandre Belloni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.