All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: gomonovych@gmail.com
Cc: w-kwok2@ti.com, m-karicheri2@ti.com, grygorii.strashko@ti.com,
	vasyl.gomonovych@nokia.com, ssantosh@kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] knav: qmss: Introduce queue descriptors monitor
Date: Thu, 13 Sep 2018 09:07:12 -0700 (PDT)	[thread overview]
Message-ID: <20180913.090712.1849966692069488441.davem@davemloft.net> (raw)
In-Reply-To: <20180911211549.12092-1-gomonovych@gmail.com>

From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Tue, 11 Sep 2018 23:15:47 +0200

> Monitor and record available descriptors in knav_qmss queues
> Get amount of available descriptors in free-descriptor queue
> base on event-triggered RX traffic.
> Also monitor free-descriptor queue base on periodic time interval
> in kernel thread.
> To start monitoring available descriptors in queue earlyi,
> module parameters, enable start monitoring in boottime
> 
> This queue descriptor monitor helps debugging starvation issue.
> The monitor should help debug queue under traffic pressure
> and can describe the shape of this pressure when a queue
> faced descriptors starvation.
> Monitor helpful for IP blocks which do not have dedicated
> descriptor starvation interrupt like RapidIO IP.
> 
> Registration and enable file in debugfs hierarchy
> 
> |-/sys/kernel/debug
> |-- knav_qmssm_soc:hwqueue@2a40000
> |   |-- 8710
> |   |   |-- buffer_size
> |   |   |-- enable
> |   |   |-- monitor_stats
> |   |   -- unregister
> 
> ---
> 
> The current implementation is the first iteration
> and require additional work.
> By this patch I would like to know does this could be
> helpful for other components and continue my work in a right way.
> 
> Signed-off-by: Vasyl Gomonovych <vasyl.gomonovych@nokia.com>

This is way over engineered for just keeping some statistics around.

Just have a periodic timer or a workqueue that does the necessary
sampling.

WARNING: multiple messages have this Message-ID (diff)
From: davem@davemloft.net (David Miller)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] knav: qmss: Introduce queue descriptors monitor
Date: Thu, 13 Sep 2018 09:07:12 -0700 (PDT)	[thread overview]
Message-ID: <20180913.090712.1849966692069488441.davem@davemloft.net> (raw)
In-Reply-To: <20180911211549.12092-1-gomonovych@gmail.com>

From: Vasyl Gomonovych <gomonovych@gmail.com>
Date: Tue, 11 Sep 2018 23:15:47 +0200

> Monitor and record available descriptors in knav_qmss queues
> Get amount of available descriptors in free-descriptor queue
> base on event-triggered RX traffic.
> Also monitor free-descriptor queue base on periodic time interval
> in kernel thread.
> To start monitoring available descriptors in queue earlyi,
> module parameters, enable start monitoring in boottime
> 
> This queue descriptor monitor helps debugging starvation issue.
> The monitor should help debug queue under traffic pressure
> and can describe the shape of this pressure when a queue
> faced descriptors starvation.
> Monitor helpful for IP blocks which do not have dedicated
> descriptor starvation interrupt like RapidIO IP.
> 
> Registration and enable file in debugfs hierarchy
> 
> |-/sys/kernel/debug
> |-- knav_qmssm_soc:hwqueue at 2a40000
> |   |-- 8710
> |   |   |-- buffer_size
> |   |   |-- enable
> |   |   |-- monitor_stats
> |   |   -- unregister
> 
> ---
> 
> The current implementation is the first iteration
> and require additional work.
> By this patch I would like to know does this could be
> helpful for other components and continue my work in a right way.
> 
> Signed-off-by: Vasyl Gomonovych <vasyl.gomonovych@nokia.com>

This is way over engineered for just keeping some statistics around.

Just have a periodic timer or a workqueue that does the necessary
sampling.

  reply	other threads:[~2018-09-13 17:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-11 21:15 [PATCH] knav: qmss: Introduce queue descriptors monitor Vasyl Gomonovych
2018-09-11 21:15 ` Vasyl Gomonovych
2018-09-13 16:07 ` David Miller [this message]
2018-09-13 16:07   ` David Miller
2018-09-14  3:20 ` kbuild test robot
2018-09-14  3:20   ` kbuild test robot
2018-09-14  3:20   ` kbuild test robot
2018-10-01  9:34 ` Gomonovych, Vasyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180913.090712.1849966692069488441.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=gomonovych@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-karicheri2@ti.com \
    --cc=netdev@vger.kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=vasyl.gomonovych@nokia.com \
    --cc=w-kwok2@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.