* [PATCH] btrfs-progs: calibrate extent_end when found a gap
@ 2018-09-04 12:42 Lu Fengqi
2018-09-11 14:41 ` David Sterba
0 siblings, 1 reply; 4+ messages in thread
From: Lu Fengqi @ 2018-09-04 12:42 UTC (permalink / raw)
To: linux-btrfs
The extent_end will be used to check whether there is gap between this
extent and next extent. If it is not calibrated, check_file_extent will
mistake that there are gaps between the remaining extents.
Signed-off-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
---
check/mode-lowmem.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c
index 1bce44f5658a..0f14a4968e84 100644
--- a/check/mode-lowmem.c
+++ b/check/mode-lowmem.c
@@ -1972,6 +1972,7 @@ static int check_file_extent(struct btrfs_root *root, struct btrfs_path *path,
root->objectid, fkey.objectid, fkey.offset,
fkey.objectid, *end);
}
+ *end = fkey.offset;
}
*end += extent_num_bytes;
--
2.18.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: calibrate extent_end when found a gap
2018-09-04 12:42 [PATCH] btrfs-progs: calibrate extent_end when found a gap Lu Fengqi
@ 2018-09-11 14:41 ` David Sterba
2018-09-13 8:30 ` Lu Fengqi
0 siblings, 1 reply; 4+ messages in thread
From: David Sterba @ 2018-09-11 14:41 UTC (permalink / raw)
To: Lu Fengqi; +Cc: linux-btrfs
On Tue, Sep 04, 2018 at 08:42:01PM +0800, Lu Fengqi wrote:
> The extent_end will be used to check whether there is gap between this
> extent and next extent. If it is not calibrated, check_file_extent will
Do you mean 'synchronized' or 'matching'.
> mistake that there are gaps between the remaining extents.
If this is a bugfix, do you have a testcase? Thanks.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: calibrate extent_end when found a gap
2018-09-11 14:41 ` David Sterba
@ 2018-09-13 8:30 ` Lu Fengqi
2018-09-13 8:32 ` Lu Fengqi
0 siblings, 1 reply; 4+ messages in thread
From: Lu Fengqi @ 2018-09-13 8:30 UTC (permalink / raw)
To: dsterba, linux-btrfs
On Tue, Sep 11, 2018 at 04:41:21PM +0200, David Sterba wrote:
>On Tue, Sep 04, 2018 at 08:42:01PM +0800, Lu Fengqi wrote:
>> The extent_end will be used to check whether there is gap between this
>> extent and next extent. If it is not calibrated, check_file_extent will
>
>Do you mean 'synchronized' or 'matching'.
I apologize for this incomprehensible commit message, and I have updated
the commit message.
[PATCH] btrfs-progs: lowmem: fix false alert about the existence of gaps in the check_file_extent
>
>> mistake that there are gaps between the remaining extents.
>
>If this is a bugfix, do you have a testcase? Thanks.
>
The testcase requires some check repair's fixes (including originl and lowmem)
that my colleagues are working on. After they get it, I will send the
testcase.
The attached is the image which can trigger the false alert.
Without the patch mentioned before, lowmem check will false alert that expect
the hole extent [257 EXTENT_DATA 8192].
ERROR: root 5 EXTENT_DATA[257 12288] gap exists, expected: EXTENT_DATA[257 8192]
--
Thanks,
Lu
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] btrfs-progs: calibrate extent_end when found a gap
2018-09-13 8:30 ` Lu Fengqi
@ 2018-09-13 8:32 ` Lu Fengqi
0 siblings, 0 replies; 4+ messages in thread
From: Lu Fengqi @ 2018-09-13 8:32 UTC (permalink / raw)
To: dsterba, linux-btrfs
[-- Attachment #1: Type: text/plain, Size: 1214 bytes --]
On Thu, Sep 13, 2018 at 04:30:28PM +0800, Lu Fengqi wrote:
>On Tue, Sep 11, 2018 at 04:41:21PM +0200, David Sterba wrote:
>>On Tue, Sep 04, 2018 at 08:42:01PM +0800, Lu Fengqi wrote:
>>> The extent_end will be used to check whether there is gap between this
>>> extent and next extent. If it is not calibrated, check_file_extent will
>>
>>Do you mean 'synchronized' or 'matching'.
>
>I apologize for this incomprehensible commit message, and I have updated
>the commit message.
>
>[PATCH] btrfs-progs: lowmem: fix false alert about the existence of gaps in the check_file_extent
>
>>
>>> mistake that there are gaps between the remaining extents.
>>
>>If this is a bugfix, do you have a testcase? Thanks.
>>
>
>The testcase requires some check repair's fixes (including originl and lowmem)
>that my colleagues are working on. After they get it, I will send the
>testcase.
>
>The attached is the image which can trigger the false alert.
Sorry, I miss the attached.
--
Thanks,
Lu
>
>Without the patch mentioned before, lowmem check will false alert that expect
>the hole extent [257 EXTENT_DATA 8192].
>
>ERROR: root 5 EXTENT_DATA[257 12288] gap exists, expected: EXTENT_DATA[257 8192]
>
>--
>Thanks,
>Lu
>
>
[-- Attachment #2: file_extent_with_gap.img --]
[-- Type: application/octet-stream, Size: 3072 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-13 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-04 12:42 [PATCH] btrfs-progs: calibrate extent_end when found a gap Lu Fengqi
2018-09-11 14:41 ` David Sterba
2018-09-13 8:30 ` Lu Fengqi
2018-09-13 8:32 ` Lu Fengqi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.