* [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg @ 2018-08-05 17:28 ` Marc Zyngier 2018-08-05 20:51 ` Laurent Pinchart 2018-09-13 9:00 ` Andrzej Hajda 0 siblings, 2 replies; 4+ messages in thread From: Marc Zyngier @ 2018-08-05 17:28 UTC (permalink / raw) To: dri-devel; +Cc: Archit Taneja, Andrzej Hajda, Laurent Pinchart, linux-kernel The Analogix DP bridge driver is pretty verbose, and outputs things like [ 619.414067] rockchip-dp ff970000.edp: Link Training Clock Recovery success [ 619.429233] rockchip-dp ff970000.edp: Link Training success! each time the display gets unblanked. While it is good to know that the device is behaving correctly, users already know that because they can see some video output. Let's keep these messages for cases where we need to actually debug the driver (we have dynamic debug to enable them at runtime if need be), and let's keep the kernel quiet otherwise. Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 2bcbfadb6ac5..0d715a375ff9 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -554,7 +554,7 @@ static int analogix_dp_process_clock_recovery(struct analogix_dp_device *dp) if (retval < 0) return retval; - dev_info(dp->dev, "Link Training Clock Recovery success\n"); + dev_dbg(dp->dev, "Link Training Clock Recovery success\n"); dp->link_train.lt_state = EQUALIZER_TRAINING; } else { for (lane = 0; lane < lane_count; lane++) { @@ -634,7 +634,7 @@ static int analogix_dp_process_equalizer_training(struct analogix_dp_device *dp) if (retval < 0) return retval; - dev_info(dp->dev, "Link Training success!\n"); + dev_dbg(dp->dev, "Link Training success!\n"); analogix_dp_get_link_bandwidth(dp, ®); dp->link_train.link_rate = reg; dev_dbg(dp->dev, "final bandwidth = %.2x\n", -- 2.14.2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg 2018-08-05 17:28 ` [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg Marc Zyngier @ 2018-08-05 20:51 ` Laurent Pinchart 2018-09-13 9:00 ` Andrzej Hajda 1 sibling, 0 replies; 4+ messages in thread From: Laurent Pinchart @ 2018-08-05 20:51 UTC (permalink / raw) To: Marc Zyngier; +Cc: dri-devel, Archit Taneja, Andrzej Hajda, linux-kernel Hi Marc, Thank you for the patch. On Sunday, 5 August 2018 20:28:57 EEST Marc Zyngier wrote: > The Analogix DP bridge driver is pretty verbose, and outputs > things like > > [ 619.414067] rockchip-dp ff970000.edp: Link Training Clock Recovery > success [ 619.429233] rockchip-dp ff970000.edp: Link Training success! > > each time the display gets unblanked. While it is good to know > that the device is behaving correctly, users already know that > because they can see some video output. > > Let's keep these messages for cases where we need to actually > debug the driver (we have dynamic debug to enable them at runtime > if need be), and let's keep the kernel quiet otherwise. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index > 2bcbfadb6ac5..0d715a375ff9 100644 > --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c > @@ -554,7 +554,7 @@ static int analogix_dp_process_clock_recovery(struct > analogix_dp_device *dp) > if (retval < 0) > return retval; > > - dev_info(dp->dev, "Link Training Clock Recovery success\n"); > + dev_dbg(dp->dev, "Link Training Clock Recovery success\n"); > dp->link_train.lt_state = EQUALIZER_TRAINING; > } else { > for (lane = 0; lane < lane_count; lane++) { > @@ -634,7 +634,7 @@ static int analogix_dp_process_equalizer_training(struct > analogix_dp_device *dp) > if (retval < 0) > return retval; > > - dev_info(dp->dev, "Link Training success!\n"); > + dev_dbg(dp->dev, "Link Training success!\n"); > analogix_dp_get_link_bandwidth(dp, ®); > dp->link_train.link_rate = reg; > dev_dbg(dp->dev, "final bandwidth = %.2x\n", -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg 2018-08-05 17:28 ` [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg Marc Zyngier @ 2018-09-13 9:00 ` Andrzej Hajda 2018-09-13 9:00 ` Andrzej Hajda 1 sibling, 0 replies; 4+ messages in thread From: Andrzej Hajda @ 2018-09-13 9:00 UTC (permalink / raw) To: Marc Zyngier, dri-devel; +Cc: Archit Taneja, Laurent Pinchart, linux-kernel On 05.08.2018 19:28, Marc Zyngier wrote: > The Analogix DP bridge driver is pretty verbose, and outputs > things like > > [ 619.414067] rockchip-dp ff970000.edp: Link Training Clock Recovery success > [ 619.429233] rockchip-dp ff970000.edp: Link Training success! > > each time the display gets unblanked. While it is good to know > that the device is behaving correctly, users already know that > because they can see some video output. > > Let's keep these messages for cases where we need to actually > debug the driver (we have dynamic debug to enable them at runtime > if need be), and let's keep the kernel quiet otherwise. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Queued to drm-misc-next. Regards Andrzej ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg @ 2018-09-13 9:00 ` Andrzej Hajda 0 siblings, 0 replies; 4+ messages in thread From: Andrzej Hajda @ 2018-09-13 9:00 UTC (permalink / raw) To: Marc Zyngier, dri-devel; +Cc: Laurent Pinchart, linux-kernel On 05.08.2018 19:28, Marc Zyngier wrote: > The Analogix DP bridge driver is pretty verbose, and outputs > things like > > [ 619.414067] rockchip-dp ff970000.edp: Link Training Clock Recovery success > [ 619.429233] rockchip-dp ff970000.edp: Link Training success! > > each time the display gets unblanked. While it is good to know > that the device is behaving correctly, users already know that > because they can see some video output. > > Let's keep these messages for cases where we need to actually > debug the driver (we have dynamic debug to enable them at runtime > if need be), and let's keep the kernel quiet otherwise. > > Signed-off-by: Marc Zyngier <marc.zyngier@arm.com> Queued to drm-misc-next. Regards Andrzej _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-09-13 9:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20180805172917epcas4p1635a7c069cb57b08bbd6891a29195d26@epcas4p1.samsung.com>
2018-08-05 17:28 ` [PATCH] drm/bridge: analogix_dp: Downgrade "Link Training" messages to dev_dbg Marc Zyngier
2018-08-05 20:51 ` Laurent Pinchart
2018-09-13 9:00 ` Andrzej Hajda
2018-09-13 9:00 ` Andrzej Hajda
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.