* [PATCH] drm/amdgpu/display: return proper error codes in dm
@ 2018-09-13 16:29 Alex Deucher
[not found] ` <20180913162928.2504-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 2+ messages in thread
From: Alex Deucher @ 2018-09-13 16:29 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Alex Deucher
Replace -1 with proper error codes.
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
index eccae63d3ef1..541f33749961 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
@@ -493,7 +493,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
error:
amdgpu_dm_fini(adev);
- return -1;
+ return -EINVAL;
}
static void amdgpu_dm_fini(struct amdgpu_device *adev)
@@ -548,7 +548,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev)
break;
default:
DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type);
- return -1;
+ return -EINVAL;
}
if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) {
@@ -1537,7 +1537,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
link_cnt = dm->dc->caps.max_links;
if (amdgpu_dm_mode_config_init(dm->adev)) {
DRM_ERROR("DM: Failed to initialize mode config\n");
- return -1;
+ return -EINVAL;
}
/* Identify the number of planes to be initialized */
@@ -1652,7 +1652,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev)
kfree(aconnector);
for (i = 0; i < dm->dc->caps.max_planes; i++)
kfree(mode_info->planes[i]);
- return -1;
+ return -EINVAL;
}
static void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm)
--
2.13.6
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread[parent not found: <20180913162928.2504-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu/display: return proper error codes in dm [not found] ` <20180913162928.2504-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org> @ 2018-09-14 5:45 ` Huang Rui 0 siblings, 0 replies; 2+ messages in thread From: Huang Rui @ 2018-09-14 5:45 UTC (permalink / raw) To: Alex Deucher; +Cc: Alex Deucher, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Thu, Sep 13, 2018 at 11:29:28AM -0500, Alex Deucher wrote: > Replace -1 with proper error codes. > > Signed-off-by: Alex Deucher <alexander.deucher@amd.com> Acked-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > index eccae63d3ef1..541f33749961 100644 > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > @@ -493,7 +493,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev) > error: > amdgpu_dm_fini(adev); > > - return -1; > + return -EINVAL; > } > > static void amdgpu_dm_fini(struct amdgpu_device *adev) > @@ -548,7 +548,7 @@ static int load_dmcu_fw(struct amdgpu_device *adev) > break; > default: > DRM_ERROR("Unsupported ASIC type: 0x%X\n", adev->asic_type); > - return -1; > + return -EINVAL; > } > > if (adev->firmware.load_type != AMDGPU_FW_LOAD_PSP) { > @@ -1537,7 +1537,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) > link_cnt = dm->dc->caps.max_links; > if (amdgpu_dm_mode_config_init(dm->adev)) { > DRM_ERROR("DM: Failed to initialize mode config\n"); > - return -1; > + return -EINVAL; > } > > /* Identify the number of planes to be initialized */ > @@ -1652,7 +1652,7 @@ static int amdgpu_dm_initialize_drm_device(struct amdgpu_device *adev) > kfree(aconnector); > for (i = 0; i < dm->dc->caps.max_planes; i++) > kfree(mode_info->planes[i]); > - return -1; > + return -EINVAL; > } > > static void amdgpu_dm_destroy_drm_device(struct amdgpu_display_manager *dm) > -- > 2.13.6 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-14 5:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 16:29 [PATCH] drm/amdgpu/display: return proper error codes in dm Alex Deucher
[not found] ` <20180913162928.2504-1-alexander.deucher-5C7GfCeVMHo@public.gmane.org>
2018-09-14 5:45 ` Huang Rui
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.