* [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
@ 2018-09-14 0:18 Dhinakaran Pandiyan
2018-09-14 0:57 ` ✓ Fi.CI.BAT: success for " Patchwork
` (7 more replies)
0 siblings, 8 replies; 9+ messages in thread
From: Dhinakaran Pandiyan @ 2018-09-14 0:18 UTC (permalink / raw)
To: intel-gfx; +Cc: Casey G Bowman, Dhinakaran Pandiyan
PSR requires AUX IO power well to be enabled. This was already in place
for CNL, extend this for ICL too. Not enabling the power well results in
the aux error interrupts when the hardware exits PSR.
Reported-by: Casey G Bowman <casey.g.bowman@intel.com>
Reported-by: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Casey G Bowman <casey.g.bowman@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..b6910c8b4e08 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2077,7 +2077,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
static inline enum intel_display_power_domain
intel_ddi_main_link_aux_domain(struct intel_dp *intel_dp)
{
- /* CNL HW requires corresponding AUX IOs to be powered up for PSR with
+ /* CNL+ HW requires corresponding AUX IOs to be powered up for PSR with
* DC states enabled at the same time, while for driver initiated AUX
* transfers we need the same AUX IOs to be powered but with DC states
* disabled. Accordingly use the AUX power domain here which leaves DC
diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 9bebec389de1..0fdabce647ab 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1996,6 +1996,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
BIT_ULL(POWER_DOMAIN_PORT_DDI_F_IO))
#define ICL_AUX_A_IO_POWER_DOMAINS ( \
+ BIT_ULL(POWER_DOMAIN_AUX_IO_A) | \
BIT_ULL(POWER_DOMAIN_AUX_A))
#define ICL_AUX_B_IO_POWER_DOMAINS ( \
BIT_ULL(POWER_DOMAIN_AUX_B))
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
@ 2018-09-14 0:57 ` Patchwork
2018-09-14 4:48 ` ✓ Fi.CI.IGT: " Patchwork
` (6 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-14 0:57 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
URL : https://patchwork.freedesktop.org/series/49682/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4822 -> Patchwork_10184 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49682/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10184 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_frontbuffer_tracking@basic:
fi-glk-j4005: PASS -> FAIL (fdo#103167)
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
igt@prime_vgem@basic-fence-flip:
fi-ilk-650: PASS -> FAIL (fdo#104008)
==== Possible fixes ====
igt@drv_selftest@live_coherency:
fi-gdg-551: DMESG-FAIL (fdo#107164) -> PASS
igt@drv_selftest@mock_hugepages:
fi-bwr-2160: DMESG-FAIL -> PASS
igt@kms_flip@basic-flip-vs-dpms:
fi-hsw-4770r: DMESG-WARN (fdo#105602) -> PASS
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: DMESG-WARN (fdo#102614) -> PASS
igt@kms_psr@primary_page_flip:
fi-whl-u: FAIL (fdo#107336) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#107164 https://bugs.freedesktop.org/show_bug.cgi?id=107164
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
== Participating hosts (49 -> 45) ==
Missing (4): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4822 -> Patchwork_10184
CI_DRM_4822: e3090c9e82d61aa837ccae2ba224e5a0b9b89d3f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4640: 9a8da36e708f9ed15b20689dfe305e41f9a19008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10184: d9f0c7b0e74d35276248bc0c9d69812097ecad46 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
d9f0c7b0e74d drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10184/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
2018-09-14 0:57 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-14 4:48 ` Patchwork
2018-09-14 13:33 ` [PATCH] " Imre Deak
` (5 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-14 4:48 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
URL : https://patchwork.freedesktop.org/series/49682/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4822_full -> Patchwork_10184_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10184_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_suspend@shrink:
shard-kbl: PASS -> INCOMPLETE (fdo#103665, fdo#106886)
igt@gem_userptr_blits@readonly-unsync:
shard-apl: PASS -> INCOMPLETE (fdo#103927)
igt@kms_flip@flip-vs-expired-vblank:
shard-snb: PASS -> FAIL (fdo#105363)
igt@kms_plane_scaling@pipe-b-scaler-with-clipping-clamping:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@kms_setmode@basic:
shard-apl: PASS -> FAIL (fdo#99912)
igt@kms_vblank@pipe-c-wait-idle-hang:
shard-glk: PASS -> INCOMPLETE (k.org#198133, fdo#103359)
==== Possible fixes ====
igt@gem_exec_await@wide-contexts:
shard-kbl: FAIL (fdo#106680) -> PASS
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: FAIL (fdo#105363, fdo#102887) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4822 -> Patchwork_10184
CI_DRM_4822: e3090c9e82d61aa837ccae2ba224e5a0b9b89d3f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4640: 9a8da36e708f9ed15b20689dfe305e41f9a19008 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10184: d9f0c7b0e74d35276248bc0c9d69812097ecad46 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10184/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
2018-09-14 0:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-14 4:48 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-14 13:33 ` Imre Deak
2018-09-14 15:53 ` Bowman, Casey G
` (4 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Imre Deak @ 2018-09-14 13:33 UTC (permalink / raw)
To: Dhinakaran Pandiyan; +Cc: intel-gfx
On Thu, Sep 13, 2018 at 05:18:22PM -0700, Dhinakaran Pandiyan wrote:
> PSR requires AUX IO power well to be enabled. This was already in place
> for CNL, extend this for ICL too. Not enabling the power well results in
> the aux error interrupts when the hardware exits PSR.
>
> Reported-by: Casey G Bowman <casey.g.bowman@intel.com>
> Reported-by: Jyoti R Yadav <jyoti.r.yadav@intel.com>
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Cc: Jyoti R Yadav <jyoti.r.yadav@intel.com>
> Cc: Casey G Bowman <casey.g.bowman@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Reviewed-by: Imre Deak <imre.deak@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..b6910c8b4e08 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2077,7 +2077,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
> static inline enum intel_display_power_domain
> intel_ddi_main_link_aux_domain(struct intel_dp *intel_dp)
> {
> - /* CNL HW requires corresponding AUX IOs to be powered up for PSR with
> + /* CNL+ HW requires corresponding AUX IOs to be powered up for PSR with
> * DC states enabled at the same time, while for driver initiated AUX
> * transfers we need the same AUX IOs to be powered but with DC states
> * disabled. Accordingly use the AUX power domain here which leaves DC
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 9bebec389de1..0fdabce647ab 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -1996,6 +1996,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
> BIT_ULL(POWER_DOMAIN_PORT_DDI_F_IO))
>
> #define ICL_AUX_A_IO_POWER_DOMAINS ( \
> + BIT_ULL(POWER_DOMAIN_AUX_IO_A) | \
> BIT_ULL(POWER_DOMAIN_AUX_A))
> #define ICL_AUX_B_IO_POWER_DOMAINS ( \
> BIT_ULL(POWER_DOMAIN_AUX_B))
> --
> 2.17.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
` (2 preceding siblings ...)
2018-09-14 13:33 ` [PATCH] " Imre Deak
@ 2018-09-14 15:53 ` Bowman, Casey G
2018-09-14 16:30 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2) Patchwork
` (3 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Bowman, Casey G @ 2018-09-14 15:53 UTC (permalink / raw)
To: Pandiyan, Dhinakaran, intel-gfx
Tested-by: Casey Bowman <casey.g.bowman@intel.com>
-----Original Message-----
From: Pandiyan, Dhinakaran
Sent: Thursday, September 13, 2018 5:18 PM
To: intel-gfx@lists.freedesktop.org
Cc: Souza, Jose <jose.souza@intel.com>; Deak, Imre <imre.deak@intel.com>; Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Atwood, Matthew S <matthew.s.atwood@intel.com>; Yadav, Jyoti R <jyoti.r.yadav@intel.com>; Bowman, Casey G <casey.g.bowman@intel.com>
Subject: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
PSR requires AUX IO power well to be enabled. This was already in place for CNL, extend this for ICL too. Not enabling the power well results in the aux error interrupts when the hardware exits PSR.
Reported-by: Casey G Bowman <casey.g.bowman@intel.com>
Reported-by: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Casey G Bowman <casey.g.bowman@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..b6910c8b4e08 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2077,7 +2077,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder, static inline enum intel_display_power_domain intel_ddi_main_link_aux_domain(struct intel_dp *intel_dp) {
- /* CNL HW requires corresponding AUX IOs to be powered up for PSR with
+ /* CNL+ HW requires corresponding AUX IOs to be powered up for PSR
+with
* DC states enabled at the same time, while for driver initiated AUX
* transfers we need the same AUX IOs to be powered but with DC states
* disabled. Accordingly use the AUX power domain here which leaves DC diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 9bebec389de1..0fdabce647ab 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1996,6 +1996,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
BIT_ULL(POWER_DOMAIN_PORT_DDI_F_IO))
#define ICL_AUX_A_IO_POWER_DOMAINS ( \
+ BIT_ULL(POWER_DOMAIN_AUX_IO_A) | \
BIT_ULL(POWER_DOMAIN_AUX_A))
#define ICL_AUX_B_IO_POWER_DOMAINS ( \
BIT_ULL(POWER_DOMAIN_AUX_B))
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2)
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
` (3 preceding siblings ...)
2018-09-14 15:53 ` Bowman, Casey G
@ 2018-09-14 16:30 ` Patchwork
2018-09-14 16:34 ` [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Souza, Jose
` (2 subsequent siblings)
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-14 16:30 UTC (permalink / raw)
To: Bowman, Casey G; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2)
URL : https://patchwork.freedesktop.org/series/49682/
State : failure
== Summary ==
Applying: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
error: corrupt patch at line 27
error: could not build fake ancestor
Patch failed at 0001 drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
` (4 preceding siblings ...)
2018-09-14 16:30 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2) Patchwork
@ 2018-09-14 16:34 ` Souza, Jose
2018-09-17 6:15 ` Yadav, Jyoti R
2018-09-17 6:16 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev3) Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Souza, Jose @ 2018-09-14 16:34 UTC (permalink / raw)
To: intel-gfx, Pandiyan, Dhinakaran
On Thu, 2018-09-13 at 17:18 -0700, Dhinakaran Pandiyan wrote:
> PSR requires AUX IO power well to be enabled. This was already in
> place
> for CNL, extend this for ICL too. Not enabling the power well results
> in
> the aux error interrupts when the hardware exits PSR.
>
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
> Reported-by: Casey G Bowman <casey.g.bowman@intel.com>
> Reported-by: Jyoti R Yadav <jyoti.r.yadav@intel.com>
> Cc: Matt Atwood <matthew.s.atwood@intel.com>
> Cc: Jyoti R Yadav <jyoti.r.yadav@intel.com>
> Cc: Casey G Bowman <casey.g.bowman@intel.com>
> Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c
> b/drivers/gpu/drm/i915/intel_ddi.c
> index cd01a09c5e0f..b6910c8b4e08 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -2077,7 +2077,7 @@ bool intel_ddi_get_hw_state(struct
> intel_encoder *encoder,
> static inline enum intel_display_power_domain
> intel_ddi_main_link_aux_domain(struct intel_dp *intel_dp)
> {
> - /* CNL HW requires corresponding AUX IOs to be powered up for
> PSR with
> + /* CNL+ HW requires corresponding AUX IOs to be powered up for
> PSR with
> * DC states enabled at the same time, while for driver
> initiated AUX
> * transfers we need the same AUX IOs to be powered but with DC
> states
> * disabled. Accordingly use the AUX power domain here which
> leaves DC
> diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c
> b/drivers/gpu/drm/i915/intel_runtime_pm.c
> index 9bebec389de1..0fdabce647ab 100644
> --- a/drivers/gpu/drm/i915/intel_runtime_pm.c
> +++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
> @@ -1996,6 +1996,7 @@ void intel_display_power_put(struct
> drm_i915_private *dev_priv,
> BIT_ULL(POWER_DOMAIN_PORT_DDI_F_IO))
>
> #define ICL_AUX_A_IO_POWER_DOMAINS ( \
> + BIT_ULL(POWER_DOMAIN_AUX_IO_A) | \
> BIT_ULL(POWER_DOMAIN_AUX_A))
> #define ICL_AUX_B_IO_POWER_DOMAINS ( \
> BIT_ULL(POWER_DOMAIN_AUX_B))
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
` (5 preceding siblings ...)
2018-09-14 16:34 ` [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Souza, Jose
@ 2018-09-17 6:15 ` Yadav, Jyoti R
2018-09-17 6:16 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev3) Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Yadav, Jyoti R @ 2018-09-17 6:15 UTC (permalink / raw)
To: Pandiyan, Dhinakaran; +Cc: intel-gfx
Hi Dhinakaran,
I tested this patch. Now I am not able to see those "AUX Error Interrupts".
Thanks for your patch.
Regards
Jyoti
-----Original Message-----
From: Pandiyan, Dhinakaran
Sent: Friday, September 14, 2018 5:48 AM
To: intel-gfx@lists.freedesktop.org
Cc: Souza, Jose <jose.souza@intel.com>; Deak, Imre <imre.deak@intel.com>; Pandiyan, Dhinakaran <dhinakaran.pandiyan@intel.com>; Atwood, Matthew S <matthew.s.atwood@intel.com>; Yadav, Jyoti R <jyoti.r.yadav@intel.com>; Bowman, Casey G <casey.g.bowman@intel.com>
Subject: [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
PSR requires AUX IO power well to be enabled. This was already in place for CNL, extend this for ICL too. Not enabling the power well results in the aux error interrupts when the hardware exits PSR.
Reported-by: Casey G Bowman <casey.g.bowman@intel.com>
Reported-by: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Matt Atwood <matthew.s.atwood@intel.com>
Cc: Jyoti R Yadav <jyoti.r.yadav@intel.com>
Cc: Casey G Bowman <casey.g.bowman@intel.com>
Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 2 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index cd01a09c5e0f..b6910c8b4e08 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -2077,7 +2077,7 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder, static inline enum intel_display_power_domain intel_ddi_main_link_aux_domain(struct intel_dp *intel_dp) {
- /* CNL HW requires corresponding AUX IOs to be powered up for PSR with
+ /* CNL+ HW requires corresponding AUX IOs to be powered up for PSR
+with
* DC states enabled at the same time, while for driver initiated AUX
* transfers we need the same AUX IOs to be powered but with DC states
* disabled. Accordingly use the AUX power domain here which leaves DC diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/i915/intel_runtime_pm.c
index 9bebec389de1..0fdabce647ab 100644
--- a/drivers/gpu/drm/i915/intel_runtime_pm.c
+++ b/drivers/gpu/drm/i915/intel_runtime_pm.c
@@ -1996,6 +1996,7 @@ void intel_display_power_put(struct drm_i915_private *dev_priv,
BIT_ULL(POWER_DOMAIN_PORT_DDI_F_IO))
#define ICL_AUX_A_IO_POWER_DOMAINS ( \
+ BIT_ULL(POWER_DOMAIN_AUX_IO_A) | \
BIT_ULL(POWER_DOMAIN_AUX_A))
#define ICL_AUX_B_IO_POWER_DOMAINS ( \
BIT_ULL(POWER_DOMAIN_AUX_B))
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev3)
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
` (6 preceding siblings ...)
2018-09-17 6:15 ` Yadav, Jyoti R
@ 2018-09-17 6:16 ` Patchwork
7 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-17 6:16 UTC (permalink / raw)
To: Yadav, Jyoti R; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev3)
URL : https://patchwork.freedesktop.org/series/49682/
State : failure
== Summary ==
Applying: drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
error: corrupt patch at line 27
error: could not build fake ancestor
Patch failed at 0001 drm/i915/psr: Enable AUX-A IO power well on ICL for PSR
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-09-17 6:16 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-14 0:18 [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Dhinakaran Pandiyan
2018-09-14 0:57 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-09-14 4:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-14 13:33 ` [PATCH] " Imre Deak
2018-09-14 15:53 ` Bowman, Casey G
2018-09-14 16:30 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev2) Patchwork
2018-09-14 16:34 ` [PATCH] drm/i915/psr: Enable AUX-A IO power well on ICL for PSR Souza, Jose
2018-09-17 6:15 ` Yadav, Jyoti R
2018-09-17 6:16 ` ✗ Fi.CI.BAT: failure for drm/i915/psr: Enable AUX-A IO power well on ICL for PSR (rev3) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.