v2.19.0 Git install doesn't allow VS Code as an editor

v2.19.0 Git install doesn't allow VS Code as an editor

[Zachary Bryant]

Hi,

I received the notification to update to the latest 2.19.0.

When the installer asks for a default editor, it defaults to vim and
when I select either VS Code option, it won't allow me to proceed.

I've reproduced this on two machines.
VS Code is up to date on both machines.

Both machines:
Windows 10
Latest VS Code (production)

Re: v2.19.0 Git install doesn't allow VS Code as an editor

[Taylor Blau]

Hi Zachary,

On Fri, Sep 14, 2018 at 09:43:43AM -0500, Zachary Bryant wrote:
> When the installer asks for a default editor, it defaults to vim and
> when I select either VS Code option, it won't allow me to proceed.

It sounds like this is an issue pertaining to Git for Windows, which
uses an issue tracker that is separate from the mailing list here. Their
tracker is at [1], but I'm cc-ing the maintainer here to let him know.

Thanks,
Taylor

[1]: https://github.com/git-for-windows/git/issues

Re: v2.19.0 Git install doesn't allow VS Code as an editor

[Johannes Schindelin]

Hi,

On Fri, 14 Sep 2018, Taylor Blau wrote:

> Hi Zachary,
> 
> On Fri, Sep 14, 2018 at 09:43:43AM -0500, Zachary Bryant wrote:
> > When the installer asks for a default editor, it defaults to vim and
> > when I select either VS Code option, it won't allow me to proceed.
> 
> It sounds like this is an issue pertaining to Git for Windows, which
> uses an issue tracker that is separate from the mailing list here. Their
> tracker is at [1], but I'm cc-ing the maintainer here to let him know.

see https://github.com/git-for-windows/build-extra/pull/200

Ciao,
Johannes