[Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation

All of lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
  2018-09-17 10:09 [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation Pierret David
@ 2018-09-17 10:01 ` Thomas Petazzoni
  2018-09-17 11:29   ` Pierret David
  0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2018-09-17 10:01 UTC (permalink / raw)
  To: buildroot

Hello David,

Thanks for your contribution!

On Mon, 17 Sep 2018 12:09:01 +0200, Pierret David wrote:
> This commit add an option to enable SSL/TLS plugin compilation who is 
> not build
> by default.
> If mbedtls library is selected, she will be used instead of build-in one.

We always want to use external libraries instead of bundled libraries.

> +config BR2_PACKAGE_MONKEY_SSL
> +        bool "enable SSL/TLS"
> +        help
> +          Enable build of the SSL/TLS plugin.

Please use one tab to indent bool and help, and one tab + two spaces to
indent the help text.

Make sure to run "make check-package" after your changes to verify that
you do not introduce coding style issues such as those ones.

> +ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)

No space before "y".

> +MONKEY_CONF_OPTS += --enable-plugins=tls
> +# If we already have TLS/SSL library, use it.
> +ifeq ($(BR2_PACKAGE_MBEDTLS), y)
> +MONKEY_CONF_OPTS += --mbedtls-shared
> +endif
> +endif

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
@ 2018-09-17 10:09 Pierret David
  2018-09-17 10:01 ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Pierret David @ 2018-09-17 10:09 UTC (permalink / raw)
  To: buildroot

This commit add an option to enable SSL/TLS plugin compilation who is 
not build
by default.
If mbedtls library is selected, she will be used instead of build-in one.

Signed-off-by: David Pierret <david.pierret@gmail.com>
---
  package/monkey/Config.in | 5 +++++
  package/monkey/monkey.mk | 8 ++++++++
  2 files changed, 13 insertions(+)

diff --git a/package/monkey/Config.in b/package/monkey/Config.in
index 9054aa0..a2496aa 100644
--- a/package/monkey/Config.in
+++ b/package/monkey/Config.in
@@ -19,6 +19,11 @@ config BR2_PACKAGE_MONKEY_SHARED

  endif

+config BR2_PACKAGE_MONKEY_SSL
+        bool "enable SSL/TLS"
+        help
+          Enable build of the SSL/TLS plugin.
+
  comment "monkey needs an toolchain w/ threads, dynamic library"
  	depends on BR2_USE_MMU
  	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS
diff --git a/package/monkey/monkey.mk b/package/monkey/monkey.mk
index 58bc26e..4fe5eb2 100644
--- a/package/monkey/monkey.mk
+++ b/package/monkey/monkey.mk
@@ -48,6 +48,14 @@ ifeq ($(BR2_ENABLE_DEBUG),y)
  MONKEY_CONF_OPTS += --debug
  endif

+ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
+MONKEY_CONF_OPTS += --enable-plugins=tls
+# If we already have TLS/SSL library, use it.
+ifeq ($(BR2_PACKAGE_MBEDTLS), y)
+MONKEY_CONF_OPTS += --mbedtls-shared
+endif
+endif
+
  define MONKEY_CONFIGURE_CMDS
  	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(MONKEY_CONF_OPTS))
  endef
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
  2018-09-17 10:01 ` Thomas Petazzoni
@ 2018-09-17 11:29   ` Pierret David
  2018-09-17 11:30     ` Pierret David
  0 siblings, 1 reply; 5+ messages in thread
From: Pierret David @ 2018-09-17 11:29 UTC (permalink / raw)
  To: buildroot

Hello Thomas,

Thank's for review

>> We always want to use external libraries instead of bundled libraries.

Ok, I define the mbedtls as a select.
I'm not yet comfortable with mailing list :/

Regards,
David

Le 17/09/2018 ? 12:01, Thomas Petazzoni a ?crit?:
> Hello David,
> 
> Thanks for your contribution!
> 
> On Mon, 17 Sep 2018 12:09:01 +0200, Pierret David wrote:
>> This commit add an option to enable SSL/TLS plugin compilation who is
>> not build
>> by default.
>> If mbedtls library is selected, she will be used instead of build-in one.
> 
> We always want to use external libraries instead of bundled libraries.
> 
>> +config BR2_PACKAGE_MONKEY_SSL
>> +        bool "enable SSL/TLS"
>> +        help
>> +          Enable build of the SSL/TLS plugin.
> 
> Please use one tab to indent bool and help, and one tab + two spaces to
> indent the help text.
> 
> Make sure to run "make check-package" after your changes to verify that
> you do not introduce coding style issues such as those ones.
> 
>> +ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
> 
> No space before "y".
> 
>> +MONKEY_CONF_OPTS += --enable-plugins=tls
>> +# If we already have TLS/SSL library, use it.
>> +ifeq ($(BR2_PACKAGE_MBEDTLS), y)
>> +MONKEY_CONF_OPTS += --mbedtls-shared
>> +endif
>> +endif
> 
> Thanks!
> 
> Thomas
> 

-- 
<div>
     <link href="https://fonts.googleapis.com/css?family=Raleway" 
rel="stylesheet" type="text/css">
     <font face="Raleway, regular">
     <table style="padding:20px;margin-bottom:-10px" border=0>
         <tbody>
         <tr>
             <td style="font-size:13px; color:#ff8054; text-align: 
center; padding-right:30px">
                 <a href="http://www.smile.eu/">
                     <img style="max-width:100%; height:auto" 
src="http://ftp.smile.fr/client/Communication/signature/img/Logo-new.png" 
alt="SMILE"/>
                 </a><br/><br/>
                     <p style="line-heigth:8px">2 Esplanade Compans 
Caffarelli, 31100 Toulouse</p>
             </td>
             <td style="border-left: 1px solid #3b7ffe; 
padding-left:20px; font-size:13px; color:#ff8054;">
                 <div style="color:#ff8054; font-size:14px;">
                     <b>David PIERRET</b>
                 </div>
                 <div style="color:#3b7ffe; font-size:13px;">
                     Ing?nieur Etude et D?veloppement<br>

                 </div><br>
                 <div style="color:#3b7ffe; font-size:13px;">
                     <span style="white-space: nowrap"><img 
style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/mail.png" 
alt="email" width="12" height="10" />
                         <a href="mailto:david.pierret@smile.fr" 
style="color:#3b7ffe; font-size:13px; 
text-decoration:none;">david.pierret at smile.fr</a>
                     </span>
                      <br>
                                     <span style="white-space: 
nowrap"><img style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/phone.png" 
alt="phone" width="10" height="10" /></span>
 
+33662312341
                                     <br>
                                                     <span 
style="white-space: nowrap"><img style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/web.png" 
alt="url" width="12" height="12" />
<a href="http://www.smile.eu/" style="color:#3b7ffe; font-size:13px; 
text-decoration:none;">http://www.smile.eu/</a>
                   </span>
                                 </div>

                 <br>
                 <div>
                     <span><a style="margin-right:5px" 
href="https://twitter.com/openwide_inge"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-twitter.png" 
alt="Twitter" style="max-width:100%; height:auto"/></a></span>
                     <span><a style="margin-right:5px" 
href="https://www.facebook.com/smileopensource"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-facebook.png" 
alt="Facebook" style="max-width:100%; height:auto"></a></span>
                     <span><a style="margin-right:5px" 
href="https://fr.linkedin.com/in/david-pierret-11912290"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-linkedin.png" 
alt="LinkedIn" style="max-width:100%; height:auto"/></a></span>
                     <span><a style="margin-right:5px" 
href="https://github.com/Smile-SA"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-github.png" 
alt="Github" style="max-width:100%; height:auto"/></a></span>
                 </div>
             </td>
         </tr>
         </tbody>
     </table>
     <br>
     <div> <a 
href="https://www.smile.eu/fr/publications/livres-blancs/freertos-aws?utm_source=signature&amp;utm_medium=email&amp;utm_campaign=signature"><img 
src="https://signature.smile.eu/assets/img/bandeaux_signature_mail_FreeRTOS.gif.gif" 
alt="D?couvrez l?univers Smile, rendez-vous sur smile.eu" border="0" 
/></a></div>
     <br>
     <div style="color:#a3acb5; font-size:10px;">
         <img 
src="http://ftp.smile.fr/client/Communication/signature/img/eco.png" 
alt="eco" width="13" height="11" />
             Pour la plan?te, n'imprimez ce mail que si c'est n?cessaire
     </div>
     </font>
</div>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
  2018-09-17 11:29   ` Pierret David
@ 2018-09-17 11:30     ` Pierret David
  2018-09-17 11:50       ` Thomas Petazzoni
  0 siblings, 1 reply; 5+ messages in thread
From: Pierret David @ 2018-09-17 11:30 UTC (permalink / raw)
  To: buildroot


This commit add an option to enable SSL/TLS plugin compilation who is 
not build
by default.

Signed-off-by: David Pierret <david.pierret@gmail.com>
---
  package/monkey/Config.in | 6 ++++++
  package/monkey/monkey.mk | 4 ++++
  2 files changed, 10 insertions(+)

diff --git a/package/monkey/Config.in b/package/monkey/Config.in
index 9054aa0..fdfa148 100644
--- a/package/monkey/Config.in
+++ b/package/monkey/Config.in
@@ -17,6 +17,12 @@ config BR2_PACKAGE_MONKEY_SHARED
  	  Build Monkey as a shared library in addition to stand-alone
  	  server

+config BR2_PACKAGE_MONKEY_SSL
+	bool "enable SSL/TLS"
+	select BR2_PACKAGE_MBEDTLS
+	help
+	  Enable build of the SSL/TLS plugin.
+
  endif

  comment "monkey needs an toolchain w/ threads, dynamic library"
diff --git a/package/monkey/monkey.mk b/package/monkey/monkey.mk
index 58bc26e..427f359 100644
--- a/package/monkey/monkey.mk
+++ b/package/monkey/monkey.mk
@@ -48,6 +48,10 @@ ifeq ($(BR2_ENABLE_DEBUG),y)
  MONKEY_CONF_OPTS += --debug
  endif

+ifeq ($(BR2_PACKAGE_MONKEY_SSL),y)
+MONKEY_CONF_OPTS += --enable-plugins=tls --mbedtls-shared
+endif
+
  define MONKEY_CONFIGURE_CMDS
  	(cd $(@D); $(TARGET_CONFIGURE_OPTS) ./configure $(MONKEY_CONF_OPTS))
  endef
-- 
2.7.4


Le 17/09/2018 ? 13:29, Pierret David a ?crit?:
> Hello Thomas,
> 
> Thank's for review
> 
>>> We always want to use external libraries instead of bundled libraries.
> 
> Ok, I define the mbedtls as a select.
> I'm not yet comfortable with mailing list :/
> 
> Regards,
> David
> 
> Le 17/09/2018 ? 12:01, Thomas Petazzoni a ?crit?:
>> Hello David,
>>
>> Thanks for your contribution!
>>
>> On Mon, 17 Sep 2018 12:09:01 +0200, Pierret David wrote:
>>> This commit add an option to enable SSL/TLS plugin compilation who is
>>> not build
>>> by default.
>>> If mbedtls library is selected, she will be used instead of build-in 
>>> one.
>>
>> We always want to use external libraries instead of bundled libraries.
>>
>>> +config BR2_PACKAGE_MONKEY_SSL
>>> +??????? bool "enable SSL/TLS"
>>> +??????? help
>>> +????????? Enable build of the SSL/TLS plugin.
>>
>> Please use one tab to indent bool and help, and one tab + two spaces to
>> indent the help text.
>>
>> Make sure to run "make check-package" after your changes to verify that
>> you do not introduce coding style issues such as those ones.
>>
>>> +ifeq ($(BR2_PACKAGE_MONKEY_SSL), y)
>>
>> No space before "y".
>>
>>> +MONKEY_CONF_OPTS += --enable-plugins=tls
>>> +# If we already have TLS/SSL library, use it.
>>> +ifeq ($(BR2_PACKAGE_MBEDTLS), y)
>>> +MONKEY_CONF_OPTS += --mbedtls-shared
>>> +endif
>>> +endif
>>
>> Thanks!
>>
>> Thomas
>>
> 

-- 
<div>
     <link href="https://fonts.googleapis.com/css?family=Raleway" 
rel="stylesheet" type="text/css">
     <font face="Raleway, regular">
     <table style="padding:20px;margin-bottom:-10px" border=0>
         <tbody>
         <tr>
             <td style="font-size:13px; color:#ff8054; text-align: 
center; padding-right:30px">
                 <a href="http://www.smile.eu/">
                     <img style="max-width:100%; height:auto" 
src="http://ftp.smile.fr/client/Communication/signature/img/Logo-new.png" 
alt="SMILE"/>
                 </a><br/><br/>
                     <p style="line-heigth:8px">2 Esplanade Compans 
Caffarelli, 31100 Toulouse</p>
             </td>
             <td style="border-left: 1px solid #3b7ffe; 
padding-left:20px; font-size:13px; color:#ff8054;">
                 <div style="color:#ff8054; font-size:14px;">
                     <b>David PIERRET</b>
                 </div>
                 <div style="color:#3b7ffe; font-size:13px;">
                     Ing?nieur Etude et D?veloppement<br>

                 </div><br>
                 <div style="color:#3b7ffe; font-size:13px;">
                     <span style="white-space: nowrap"><img 
style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/mail.png" 
alt="email" width="12" height="10" />
                         <a href="mailto:david.pierret@smile.fr" 
style="color:#3b7ffe; font-size:13px; 
text-decoration:none;">david.pierret at smile.fr</a>
                     </span>
                      <br>
                                     <span style="white-space: 
nowrap"><img style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/phone.png" 
alt="phone" width="10" height="10" /></span>
 
+33662312341
                                     <br>
                                                     <span 
style="white-space: nowrap"><img style="margin-right:5px" 
src="http://ftp.smile.fr/client/Communication/signature/img/web.png" 
alt="url" width="12" height="12" />
<a href="http://www.smile.eu/" style="color:#3b7ffe; font-size:13px; 
text-decoration:none;">http://www.smile.eu/</a>
                   </span>
                                 </div>

                 <br>
                 <div>
                     <span><a style="margin-right:5px" 
href="https://twitter.com/openwide_inge"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-twitter.png" 
alt="Twitter" style="max-width:100%; height:auto"/></a></span>
                     <span><a style="margin-right:5px" 
href="https://www.facebook.com/smileopensource"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-facebook.png" 
alt="Facebook" style="max-width:100%; height:auto"></a></span>
                     <span><a style="margin-right:5px" 
href="https://fr.linkedin.com/in/david-pierret-11912290"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-linkedin.png" 
alt="LinkedIn" style="max-width:100%; height:auto"/></a></span>
                     <span><a style="margin-right:5px" 
href="https://github.com/Smile-SA"><img 
src="http://ftp.smile.fr/client/Communication/signature/img/rs-github.png" 
alt="Github" style="max-width:100%; height:auto"/></a></span>
                 </div>
             </td>
         </tr>
         </tbody>
     </table>
     <br>
     <div> <a 
href="https://www.smile.eu/fr/publications/livres-blancs/freertos-aws?utm_source=signature&amp;utm_medium=email&amp;utm_campaign=signature"><img 
src="https://signature.smile.eu/assets/img/bandeaux_signature_mail_FreeRTOS.gif.gif" 
alt="D?couvrez l?univers Smile, rendez-vous sur smile.eu" border="0" 
/></a></div>
     <br>
     <div style="color:#a3acb5; font-size:10px;">
         <img 
src="http://ftp.smile.fr/client/Communication/signature/img/eco.png" 
alt="eco" width="13" height="11" />
             Pour la plan?te, n'imprimez ce mail que si c'est n?cessaire
     </div>
     </font>
</div>

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation
  2018-09-17 11:30     ` Pierret David
@ 2018-09-17 11:50       ` Thomas Petazzoni
  0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2018-09-17 11:50 UTC (permalink / raw)
  To: buildroot

Hello,

On Mon, 17 Sep 2018 13:30:49 +0200, Pierret David wrote:
> This commit add an option to enable SSL/TLS plugin compilation who is 
> not build
> by default.
> 
> Signed-off-by: David Pierret <david.pierret@gmail.com>

Could you send a proper v2 of the patch series ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-09-17 11:50 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-17 10:09 [Buildroot] [PATCH 2/2] monkey: add option for SSL/TLS plugin compilation Pierret David
2018-09-17 10:01 ` Thomas Petazzoni
2018-09-17 11:29   ` Pierret David
2018-09-17 11:30     ` Pierret David
2018-09-17 11:50       ` Thomas Petazzoni

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.