From: kbuild test robot <lkp@intel.com> To: christophe.kerello@st.com Cc: kbuild-all@01.org, boris.brezillon@bootlin.com, miquel.raynal@bootlin.com, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Christophe Kerello <christophe.kerello@st.com> Subject: Re: [PATCH 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver Date: Tue, 18 Sep 2018 01:32:25 +0800 [thread overview] Message-ID: <201809180105.owAEaTjk%fengguang.wu@intel.com> (raw) In-Reply-To: <1537199260-7280-3-git-send-email-christophe.kerello@st.com> [-- Attachment #1: Type: text/plain, Size: 4777 bytes --] Hi Christophe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mtd/nand/next] [also build test WARNING on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/christophe-kerello-st-com/mtd-rawnand-add-STM32-FMC2-NAND-flash-controller-driver/20180918-000016 base: git://git.infradead.org/linux-mtd.git nand/next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All warnings (new ones prefixed by >>): In file included from include/linux/clk.h:16, from drivers/mtd/nand/raw/stm32_fmc2_nand.c:7: drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function 'stm32_fmc2_read_data': >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:838:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:30: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:838:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:44: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function 'stm32_fmc2_write_data': drivers/mtd/nand/raw/stm32_fmc2_nand.c:872:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:30: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ drivers/mtd/nand/raw/stm32_fmc2_nand.c:872:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:44: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ In file included from include/linux/module.h:18, from drivers/mtd/nand/raw/stm32_fmc2_nand.c:13: drivers/mtd/nand/raw/stm32_fmc2_nand.c: At top level: drivers/mtd/nand/raw/stm32_fmc2_nand.c:1726:26: error: expected ',' or ';' before 'DRIVER_NAME' MODULE_ALIAS("platform:" DRIVER_NAME); ^~~~~~~~~~~ include/linux/moduleparam.h:24:26: note: in definition of macro '__MODULE_INFO' = __stringify(tag) "=" info ^~~~ include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO' #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias) ^~~~~~~~~~~ drivers/mtd/nand/raw/stm32_fmc2_nand.c:1726:1: note: in expansion of macro 'MODULE_ALIAS' MODULE_ALIAS("platform:" DRIVER_NAME); ^~~~~~~~~~~~ vim +838 drivers/mtd/nand/raw/stm32_fmc2_nand.c 826 827 void stm32_fmc2_read_data(struct nand_chip *chip, void *buf, 828 unsigned int len, bool force_8bit) 829 { 830 struct stm32_fmc2 *fmc2 = nand_get_controller_data(chip); 831 void __iomem *io_addr_r = fmc2->data_base[fmc2->cs_sel]; 832 u8 *p = buf; 833 unsigned int i; 834 835 if (force_8bit) 836 goto read_8bit; 837 > 838 if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { 839 u32 *p = buf; 840 841 len >>= 2; 842 for (i = 0; i < len; i++) 843 p[i] = readl_relaxed(io_addr_r); 844 return; 845 } 846 847 if (chip->options & NAND_BUSWIDTH_16) { 848 u16 *p = buf; 849 850 len >>= 1; 851 for (i = 0; i < len; i++) 852 p[i] = readw_relaxed(io_addr_r); 853 return; 854 } 855 856 read_8bit: 857 for (i = 0; i < len; i++) 858 p[i] = readb_relaxed(io_addr_r); 859 } 860 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 51736 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> Cc: kbuild-all@01.org, boris.brezillon@bootlin.com, miquel.raynal@bootlin.com, richard@nod.at, dwmw2@infradead.org, computersforpeace@gmail.com, marek.vasut@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Christophe Kerello <christophe.kerello@st.com> Subject: Re: [PATCH 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver Date: Tue, 18 Sep 2018 01:32:25 +0800 [thread overview] Message-ID: <201809180105.owAEaTjk%fengguang.wu@intel.com> (raw) In-Reply-To: <1537199260-7280-3-git-send-email-christophe.kerello@st.com> [-- Attachment #1: Type: text/plain, Size: 4777 bytes --] Hi Christophe, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mtd/nand/next] [also build test WARNING on v4.19-rc4 next-20180913] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/christophe-kerello-st-com/mtd-rawnand-add-STM32-FMC2-NAND-flash-controller-driver/20180918-000016 base: git://git.infradead.org/linux-mtd.git nand/next config: ia64-allmodconfig (attached as .config) compiler: ia64-linux-gcc (GCC) 8.1.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=8.1.0 make.cross ARCH=ia64 All warnings (new ones prefixed by >>): In file included from include/linux/clk.h:16, from drivers/mtd/nand/raw/stm32_fmc2_nand.c:7: drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function 'stm32_fmc2_read_data': >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:838:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:30: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ >> drivers/mtd/nand/raw/stm32_fmc2_nand.c:838:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:44: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ drivers/mtd/nand/raw/stm32_fmc2_nand.c: In function 'stm32_fmc2_write_data': drivers/mtd/nand/raw/stm32_fmc2_nand.c:872:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:30: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ drivers/mtd/nand/raw/stm32_fmc2_nand.c:872:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast] if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { ^ include/linux/kernel.h:62:44: note: in definition of macro 'IS_ALIGNED' #define IS_ALIGNED(x, a) (((x) & ((typeof(x))(a) - 1)) == 0) ^ In file included from include/linux/module.h:18, from drivers/mtd/nand/raw/stm32_fmc2_nand.c:13: drivers/mtd/nand/raw/stm32_fmc2_nand.c: At top level: drivers/mtd/nand/raw/stm32_fmc2_nand.c:1726:26: error: expected ',' or ';' before 'DRIVER_NAME' MODULE_ALIAS("platform:" DRIVER_NAME); ^~~~~~~~~~~ include/linux/moduleparam.h:24:26: note: in definition of macro '__MODULE_INFO' = __stringify(tag) "=" info ^~~~ include/linux/module.h:164:30: note: in expansion of macro 'MODULE_INFO' #define MODULE_ALIAS(_alias) MODULE_INFO(alias, _alias) ^~~~~~~~~~~ drivers/mtd/nand/raw/stm32_fmc2_nand.c:1726:1: note: in expansion of macro 'MODULE_ALIAS' MODULE_ALIAS("platform:" DRIVER_NAME); ^~~~~~~~~~~~ vim +838 drivers/mtd/nand/raw/stm32_fmc2_nand.c 826 827 void stm32_fmc2_read_data(struct nand_chip *chip, void *buf, 828 unsigned int len, bool force_8bit) 829 { 830 struct stm32_fmc2 *fmc2 = nand_get_controller_data(chip); 831 void __iomem *io_addr_r = fmc2->data_base[fmc2->cs_sel]; 832 u8 *p = buf; 833 unsigned int i; 834 835 if (force_8bit) 836 goto read_8bit; 837 > 838 if (IS_ALIGNED((u32)buf, sizeof(u32)) && IS_ALIGNED(len, sizeof(u32))) { 839 u32 *p = buf; 840 841 len >>= 2; 842 for (i = 0; i < len; i++) 843 p[i] = readl_relaxed(io_addr_r); 844 return; 845 } 846 847 if (chip->options & NAND_BUSWIDTH_16) { 848 u16 *p = buf; 849 850 len >>= 1; 851 for (i = 0; i < len; i++) 852 p[i] = readw_relaxed(io_addr_r); 853 return; 854 } 855 856 read_8bit: 857 for (i = 0; i < len; i++) 858 p[i] = readb_relaxed(io_addr_r); 859 } 860 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 51736 bytes --]
next prev parent reply other threads:[~2018-09-17 17:34 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-17 15:47 [PATCH 0/3] mtd: rawnand: add STM32 FMC2 NAND flash controller driver christophe.kerello 2018-09-17 15:47 ` christophe.kerello 2018-09-17 15:47 ` [PATCH 1/3] dt-bindings: mtd: stm32_fmc2: add STM32 FMC2 NAND controller documentation christophe.kerello 2018-09-17 15:47 ` christophe.kerello 2018-09-22 8:34 ` Miquel Raynal 2018-09-22 8:34 ` Miquel Raynal 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 17:17 ` Boris Brezillon 2018-09-24 17:17 ` Boris Brezillon 2018-09-25 9:14 ` Christophe Kerello 2018-09-25 9:14 ` Christophe Kerello 2018-09-17 15:47 ` [PATCH 2/3] mtd: rawnand: stm32_fmc2: add STM32 FMC2 NAND flash controller driver christophe.kerello 2018-09-17 15:47 ` christophe.kerello 2018-09-17 17:05 ` kbuild test robot 2018-09-17 17:05 ` kbuild test robot 2018-09-17 17:32 ` kbuild test robot [this message] 2018-09-17 17:32 ` kbuild test robot 2018-09-22 13:48 ` Miquel Raynal 2018-09-22 13:48 ` Miquel Raynal 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 17:26 ` Boris Brezillon 2018-09-24 17:26 ` Boris Brezillon 2018-10-29 9:22 ` Miquel Raynal 2018-10-29 9:22 ` Miquel Raynal 2018-09-23 11:34 ` Miquel Raynal 2018-09-23 11:34 ` Miquel Raynal 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 16:36 ` Christophe Kerello 2018-09-24 17:23 ` Boris Brezillon 2018-09-24 17:23 ` Boris Brezillon 2018-09-25 9:14 ` Christophe Kerello 2018-09-25 9:14 ` Christophe Kerello 2018-09-17 15:47 ` [PATCH 3/3] mtd: rawnand: stm32_fmc2: add manual mode christophe.kerello 2018-09-17 15:47 ` christophe.kerello
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201809180105.owAEaTjk%fengguang.wu@intel.com \ --to=lkp@intel.com \ --cc=boris.brezillon@bootlin.com \ --cc=christophe.kerello@st.com \ --cc=computersforpeace@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dwmw2@infradead.org \ --cc=kbuild-all@01.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.