From: jacopo mondi <jacopo@jmondi.org>
To: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Linus Walleij <linus.walleij@linaro.org>,
Simon Horman <horms@verge.net.au>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] pinctrl: renesas: Renesas RZ/N1 pinctrl driver
Date: Tue, 18 Sep 2018 15:33:53 +0200 [thread overview]
Message-ID: <20180918133353.GT16851@w540> (raw)
In-Reply-To: <TY1PR01MB17695F174D9083C0E625494FF51D0@TY1PR01MB1769.jpnprd01.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]
Hi Phil,
On Tue, Sep 18, 2018 at 11:55:16AM +0000, Phil Edworthy wrote:
> Hi Jacopo,
>
[snip]
> > > +
> > > +/*
> > > + * Structure detailing the HW registers on the RZ/N1 devices.
> > > + * Both the Level 1 mux registers and Level 2 mux registers have the
> > > +same
> > > + * structure. The only difference is that Level 2 has additional MDIO
> > > +registers
> > > + * at the end.
> > > + */
> > > +struct rzn1_pinctrl_regs {
> > > + union {
> > > + u32 conf[170];
> > > + u8 pad0[0x400];
> >
> > Is pad0 actually used?
> No, it's just to implement the padding. Would you prefer not using a union
> here?
Oh, I did the math wrong, to me it was (32*170 > 8*400) but it's
actually (32*170 < 8*1024).
Also using a struct to define the memory region layout confused me and
I was about to ask "WHY ARE YOU RESERVING MEMORY HERE???" but this
type is just used for pointers, and it makes accessing HW locations
nicer actually (thanks Geert for having saved me a silly comment on this).
Cheers
j
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2018-09-18 13:33 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 16:36 [PATCH v3 0/3] Renesas R9A06G032 PINCTRL Driver Phil Edworthy
2018-09-17 16:36 ` [PATCH v3 1/3] dt-bindings: pinctrl: renesas,rzn1-pinctrl: documentation Phil Edworthy
2018-09-18 9:27 ` jacopo mondi
2018-09-18 9:44 ` Phil Edworthy
2018-09-18 9:44 ` Phil Edworthy
2018-09-18 10:48 ` jacopo mondi
2018-09-18 10:48 ` jacopo mondi
2018-09-17 16:36 ` [PATCH v3 2/3] pinctrl: renesas: Renesas RZ/N1 pinctrl driver Phil Edworthy
2018-09-18 10:43 ` jacopo mondi
2018-09-18 11:55 ` Phil Edworthy
2018-09-18 11:55 ` Phil Edworthy
2018-09-18 13:33 ` jacopo mondi [this message]
2018-09-18 13:33 ` jacopo mondi
2018-09-17 16:36 ` [PATCH v3 3/3] ARM: dts: r9a06g032: Add pinctrl node Phil Edworthy
2018-09-19 9:15 ` Simon Horman
2018-09-19 9:18 ` Phil Edworthy
2018-09-19 9:18 ` Phil Edworthy
2018-09-19 9:23 ` Geert Uytterhoeven
2018-09-19 9:27 ` Phil Edworthy
2018-09-19 9:26 ` Simon Horman
2018-09-19 9:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180918133353.GT16851@w540 \
--to=jacopo@jmondi.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.