From: Jaegeuk Kim <jaegeuk@kernel.org> To: Chao Yu <chao@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 1/2] f2fs: report ENOENT correct in f2fs_rename Date: Tue, 18 Sep 2018 10:59:36 -0700 [thread overview] Message-ID: <20180918175936.GF91945@jaegeuk-macbookpro.roam.corp.google.com> (raw) In-Reply-To: <f2d06f89-4f84-8492-eeea-e1c07e5104c3@kernel.org> On 09/18, Chao Yu wrote: > On 2018/9/18 10:18, Jaegeuk Kim wrote: > > This fixes wrong error report in f2fs_rename. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/namei.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > > index 98d3ab7c3ce6..d653be777529 100644 > > --- a/fs/f2fs/namei.c > > +++ b/fs/f2fs/namei.c > > @@ -833,7 +833,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, > > struct f2fs_dir_entry *old_entry; > > struct f2fs_dir_entry *new_entry; > > bool is_old_inline = f2fs_has_inline_dentry(old_dir); > > - int err = -ENOENT; > > + int err; > > > > if (unlikely(f2fs_cp_error(sbi))) > > return -EIO; > > @@ -854,6 +854,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, > > if (err) > > goto out; > > > > + err = -ENOENT; > > I didn't get what's the difference after moving initialization of 'err' here... One example, old_entry = f2fs_find_entry(old_dir, &old_dentry->d_name, &old_page); if (!old_entry) { if (IS_ERR(old_page)) err = PTR_ERR(old_page); --> need to return ENOENT instead of 0. goto out; } > > Thanks, > > > if (new_inode) { > > err = dquot_initialize(new_inode); > > if (err) > >
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org> To: Chao Yu <chao@kernel.org> Cc: linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 1/2] f2fs: report ENOENT correct in f2fs_rename Date: Tue, 18 Sep 2018 10:59:36 -0700 [thread overview] Message-ID: <20180918175936.GF91945@jaegeuk-macbookpro.roam.corp.google.com> (raw) In-Reply-To: <f2d06f89-4f84-8492-eeea-e1c07e5104c3@kernel.org> On 09/18, Chao Yu wrote: > On 2018/9/18 10:18, Jaegeuk Kim wrote: > > This fixes wrong error report in f2fs_rename. > > > > Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org> > > --- > > fs/f2fs/namei.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c > > index 98d3ab7c3ce6..d653be777529 100644 > > --- a/fs/f2fs/namei.c > > +++ b/fs/f2fs/namei.c > > @@ -833,7 +833,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, > > struct f2fs_dir_entry *old_entry; > > struct f2fs_dir_entry *new_entry; > > bool is_old_inline = f2fs_has_inline_dentry(old_dir); > > - int err = -ENOENT; > > + int err; > > > > if (unlikely(f2fs_cp_error(sbi))) > > return -EIO; > > @@ -854,6 +854,7 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, > > if (err) > > goto out; > > > > + err = -ENOENT; > > I didn't get what's the difference after moving initialization of 'err' here... One example, old_entry = f2fs_find_entry(old_dir, &old_dentry->d_name, &old_page); if (!old_entry) { if (IS_ERR(old_page)) err = PTR_ERR(old_page); --> need to return ENOENT instead of 0. goto out; } > > Thanks, > > > if (new_inode) { > > err = dquot_initialize(new_inode); > > if (err) > >
next prev parent reply other threads:[~2018-09-18 17:59 UTC|newest] Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-18 2:18 [PATCH 1/2] f2fs: report ENOENT correct in f2fs_rename Jaegeuk Kim 2018-09-18 2:18 ` [PATCH 2/2] f2fs: avoid f2fs_bug_on if f2fs_get_meta_page_nofail got EIO Jaegeuk Kim 2018-09-18 13:16 ` [f2fs-dev] " Chao Yu 2018-09-18 17:55 ` Jaegeuk Kim 2018-09-18 17:56 ` [PATCH 2/2 v2] " Jaegeuk Kim 2018-09-19 1:45 ` [f2fs-dev] " Chao Yu 2018-09-19 1:45 ` Chao Yu 2018-09-19 22:47 ` Jaegeuk Kim 2018-09-20 6:07 ` Chao Yu 2018-09-20 6:07 ` Chao Yu 2018-09-20 21:46 ` Jaegeuk Kim 2018-09-20 21:46 ` Jaegeuk Kim 2018-09-21 1:30 ` [f2fs-dev] " Chao Yu 2018-09-21 1:30 ` Chao Yu 2018-09-26 0:18 ` Jaegeuk Kim 2018-09-26 0:18 ` Jaegeuk Kim 2018-09-26 1:10 ` [f2fs-dev] " Chao Yu 2018-09-26 1:10 ` Chao Yu 2018-09-26 8:31 ` Chao Yu 2018-09-26 8:31 ` Chao Yu 2018-09-26 19:49 ` Jaegeuk Kim 2018-09-27 1:14 ` Chao Yu 2018-09-27 1:14 ` Chao Yu 2018-09-27 4:58 ` Jaegeuk Kim 2018-09-27 5:45 ` Chao Yu 2018-09-27 5:45 ` Chao Yu 2018-09-20 21:48 ` [f2fs-dev] [PATCH 2/2 v3] " Jaegeuk Kim 2018-09-20 21:48 ` Jaegeuk Kim 2018-09-27 12:09 ` [f2fs-dev] " Chao Yu 2018-09-18 12:47 ` [f2fs-dev] [PATCH 1/2] f2fs: report ENOENT correct in f2fs_rename Chao Yu 2018-09-18 17:59 ` Jaegeuk Kim [this message] 2018-09-18 17:59 ` Jaegeuk Kim 2018-09-19 1:48 ` [f2fs-dev] " Chao Yu 2018-09-19 1:48 ` Chao Yu 2018-09-19 0:47 ` Sahitya Tummala 2018-09-19 22:50 ` [PATCH 1/2 v2] " Jaegeuk Kim 2018-09-20 6:14 ` [f2fs-dev] " Chao Yu 2018-09-20 6:14 ` Chao Yu 2018-09-20 21:35 ` [f2fs-dev] [PATCH 1/2 v3] " Jaegeuk Kim 2018-09-21 1:31 ` Chao Yu 2018-09-21 1:31 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180918175936.GF91945@jaegeuk-macbookpro.roam.corp.google.com \ --to=jaegeuk@kernel.org \ --cc=chao@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.