All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Roberto Sassu <roberto.sassu@huawei.com>
Cc: linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read
Date: Tue, 18 Sep 2018 21:54:33 +0300	[thread overview]
Message-ID: <20180918185433.GA9177@linux.intel.com> (raw)
In-Reply-To: <8621eb6d-b252-4fb3-cb67-294f0aafb54c@huawei.com>

On Tue, Sep 18, 2018 at 09:14:43AM +0200, Roberto Sassu wrote:
> On 9/17/2018 11:16 PM, Jarkko Sakkinen wrote:
> > On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote:
> > > This code has the same behavior of tpm2_get_pcr_allocation(). If some
> > > banks are not used, set the algorithm of the first unused to
> > > TPM_ALG_ERROR.
> > 
> > My point is that maybe it would sense to use zero for that in order
> > to make code a bit simpler.
> 
> Wouldn't be better to compare data with the same type? Since the alg_id
> structure member stores an algorithm, it should be fine to compare its
> value with an algorithm.
> 
> No problem to change that, but probably I should modify also
> tpm_pcr_extend().
> 
> Roberto

Please do.

/Jarkko

WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read
Date: Tue, 18 Sep 2018 21:54:33 +0300	[thread overview]
Message-ID: <20180918185433.GA9177@linux.intel.com> (raw)
In-Reply-To: <8621eb6d-b252-4fb3-cb67-294f0aafb54c@huawei.com>

On Tue, Sep 18, 2018 at 09:14:43AM +0200, Roberto Sassu wrote:
> On 9/17/2018 11:16 PM, Jarkko Sakkinen wrote:
> > On Mon, Sep 17, 2018 at 12:02:56PM +0200, Roberto Sassu wrote:
> > > This code has the same behavior of tpm2_get_pcr_allocation(). If some
> > > banks are not used, set the algorithm of the first unused to
> > > TPM_ALG_ERROR.
> > 
> > My point is that maybe it would sense to use zero for that in order
> > to make code a bit simpler.
> 
> Wouldn't be better to compare data with the same type? Since the alg_id
> structure member stores an algorithm, it should be fine to compare its
> value with an algorithm.
> 
> No problem to change that, but probably I should modify also
> tpm_pcr_extend().
> 
> Roberto

Please do.

/Jarkko

  reply	other threads:[~2018-09-18 18:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180905114202.7757-1-roberto.sassu@huawei.com>
     [not found] ` <20180905114202.7757-3-roberto.sassu@huawei.com>
2018-09-05 13:43   ` EXTERNAL: [PATCH v2 2/3] tpm: modify tpm_pcr_read() definition to pass TPM hash algorithms Jeremy Boone
     [not found]     ` <e1d77563-81fd-36f0-648f-3325969b05af@huawei.com>
2018-09-16 12:30       ` Jarkko Sakkinen
2018-09-16 12:37         ` Winkler, Tomas
2018-09-16 19:21           ` Jarkko Sakkinen
2018-09-26 14:09       ` Mimi Zohar
2018-09-26 14:39         ` Roberto Sassu
2018-09-26 14:39           ` Roberto Sassu
2018-09-26 14:39           ` Roberto Sassu
2018-09-10 18:42 ` [PATCH v2 0/3] tpm: retrieve digest size of unknown algorithms from TPM Jarkko Sakkinen
     [not found] ` <20180905114202.7757-2-roberto.sassu@huawei.com>
2018-09-16 12:13   ` [PATCH v2 1/3] tpm: rename and export tpm2_digest and tpm2_algorithms Jarkko Sakkinen
     [not found] ` <20180905114202.7757-4-roberto.sassu@huawei.com>
2018-09-16 12:37   ` [PATCH v2 3/3] tpm: retrieve digest size of unknown algorithms with PCR read Jarkko Sakkinen
2018-09-17 10:02     ` Roberto Sassu
2018-09-17 10:02       ` Roberto Sassu
2018-09-17 21:16       ` Jarkko Sakkinen
2018-09-17 21:16         ` Jarkko Sakkinen
2018-09-18  7:14         ` Roberto Sassu
2018-09-18  7:14           ` Roberto Sassu
2018-09-18 18:54           ` Jarkko Sakkinen [this message]
2018-09-18 18:54             ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180918185433.GA9177@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=roberto.sassu@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.