[PATCH 0/2] Add APMU support to r8a77470

[PATCH 0/2] Add APMU support to r8a77470

[Fabrizio Castro]

Dear All,

this series adds APMU support to the RZ/G1C (a.k.a. r8a77470).

Thanks,
Fab

Fabrizio Castro (2):
  dt-bindings: apmu: Document r8a77470 support
  ARM: dts: r8a77470: Add APMU node and second CPU core

 Documentation/devicetree/bindings/power/renesas,apmu.txt |  1 +
 arch/arm/boot/dts/r8a77470.dtsi                          | 16 ++++++++++++++++
 2 files changed, 17 insertions(+)

-- 
2.7.4

[PATCH 1/2] dt-bindings: apmu: Document r8a77470 support

[Fabrizio Castro]

Document APMU and SMP enable method for RZ/G1C (also known as
r8a77470) SoC.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 Documentation/devicetree/bindings/power/renesas,apmu.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/power/renesas,apmu.txt b/Documentation/devicetree/bindings/power/renesas,apmu.txt
index f747f95..e6f47c9 100644
--- a/Documentation/devicetree/bindings/power/renesas,apmu.txt
+++ b/Documentation/devicetree/bindings/power/renesas,apmu.txt
@@ -9,6 +9,7 @@ Required properties:
 	      Examples with soctypes are:
 		- "renesas,r8a7743-apmu" (RZ/G1M)
 		- "renesas,r8a7745-apmu" (RZ/G1E)
+		- "renesas,r8a77470-apmu" (RZ/G1C)
 		- "renesas,r8a7790-apmu" (R-Car H2)
 		- "renesas,r8a7791-apmu" (R-Car M2-W)
 		- "renesas,r8a7792-apmu" (R-Car V2H)
-- 
2.7.4

[PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Add DT node for the Advanced Power Management Unit (APMU), add the
second CPU core, and use "renesas,apmu" as "enable-method".

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm/boot/dts/r8a77470.dtsi | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi
index c053a28..9aba350 100644
--- a/arch/arm/boot/dts/r8a77470.dtsi
+++ b/arch/arm/boot/dts/r8a77470.dtsi
@@ -17,6 +17,7 @@
 	cpus {
 		#address-cells = <1>;
 		#size-cells = <0>;
+		enable-method = "renesas,apmu";
 
 		cpu0: cpu@0 {
 			device_type = "cpu";
@@ -28,6 +29,15 @@
 			next-level-cache = <&L2_CA7>;
 		};
 
+		cpu1: cpu@1 {
+			device_type = "cpu";
+			compatible = "arm,cortex-a7";
+			reg = <1>;
+			clock-frequency = <1000000000>;
+			clocks = <&cpg CPG_CORE R8A77470_CLK_Z2>;
+			power-domains = <&sysc R8A77470_PD_CA7_CPU1>;
+			next-level-cache = <&L2_CA7>;
+		};
 
 		L2_CA7: cache-controller-0 {
 			compatible = "cache";
@@ -167,6 +177,12 @@
 			#reset-cells = <1>;
 		};
 
+		apmu@e6151000 {
+			compatible = "renesas,r8a77470-apmu", "renesas,apmu";
+			reg = <0 0xe6151000 0 0x188>;
+			cpus = <&cpu0 &cpu1>;
+		};
+
 		rst: reset-controller@e6160000 {
 			compatible = "renesas,r8a77470-rst";
 			reg = <0 0xe6160000 0 0x100>;
-- 
2.7.4

Re: [PATCH 1/2] dt-bindings: apmu: Document r8a77470 support

[Geert Uytterhoeven]

On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Document APMU and SMP enable method for RZ/G1C (also known as
> r8a77470) SoC.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Geert Uytterhoeven]

Perhaps "ARM: dts: r8a77470: Add SMP support"?

On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> Add DT node for the Advanced Power Management Unit (APMU), add the
> second CPU core, and use "renesas,apmu" as "enable-method".
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 1/2] dt-bindings: apmu: Document r8a77470 support

[Simon Horman]

On Mon, Sep 17, 2018 at 10:52:19AM +0200, Geert Uytterhoeven wrote:
> On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Document APMU and SMP enable method for RZ/G1C (also known as
> > r8a77470) SoC.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied for v4.20.

Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Simon Horman]

On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> Perhaps "ARM: dts: r8a77470: Add SMP support"?
> 
> On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Add DT node for the Advanced Power Management Unit (APMU), add the
> > second CPU core, and use "renesas,apmu" as "enable-method".
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

I would like to ask to what extent this has been tested with respect to
CPU hotplug, suspend to RAM, and combinations thereof.

Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Simon Horman]

On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote:
> On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> > 
> > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > second CPU core, and use "renesas,apmu" as "enable-method".
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > 
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> I would like to ask to what extent this has been tested with respect to
> CPU hotplug, suspend to RAM, and combinations thereof.

And any details of firmware, bootloader, ... version stacks where this is
supported.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> Perhaps "ARM: dts: r8a77470: Add SMP support"?

Your proposal is with me, Simon do you want me to send a v2 for this?

Thanks,
Fab

>
> On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Add DT node for the Advanced Power Management Unit (APMU), add the
> > second CPU core, and use "renesas,apmu" as "enable-method".
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Geert,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> Perhaps "ARM: dts: r8a77470: Add SMP support"?

Your proposal is with me, Simon do you want me to send a v2 for this?

Thanks,
Fab

>
> On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > Add DT node for the Advanced Power Management Unit (APMU), add the
> > second CPU core, and use "renesas,apmu" as "enable-method".
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> >
> > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > second CPU core, and use "renesas,apmu" as "enable-method".
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I would like to ask to what extent this has been tested with respect to
> CPU hotplug, suspend to RAM, and combinations thereof.

Both CPU hotplug and STR were tested on their own and combined, I haven't encountered any issue so far.

Thanks,
Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> >
> > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > second CPU core, and use "renesas,apmu" as "enable-method".
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> I would like to ask to what extent this has been tested with respect to
> CPU hotplug, suspend to RAM, and combinations thereof.

Both CPU hotplug and STR were tested on their own and combined, I haven't encountered any issue so far.

Thanks,
Fab




Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote:
> > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> > >
> > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > > second CPU core, and use "renesas,apmu" as "enable-method".
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > I would like to ask to what extent this has been tested with respect to
> > CPU hotplug, suspend to RAM, and combinations thereof.
>
> And any details of firmware, bootloader, ... version stacks where this is
> supported.

iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25
U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39)

# cat /sys/devices/soc0/revision
ES2.0

I hope this helps.

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

RE: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback.

> Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
>
> On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote:
> > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> > >
> > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > > second CPU core, and use "renesas,apmu" as "enable-method".
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > I would like to ask to what extent this has been tested with respect to
> > CPU hotplug, suspend to RAM, and combinations thereof.
>
> And any details of firmware, bootloader, ... version stacks where this is
> supported.

iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25
U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39)

# cat /sys/devices/soc0/revision
ES2.0

I hope this helps.

Thanks,
Fab



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.

Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core

[Simon Horman]

Hi Fabrizio, Hi Geert,

On Wed, Sep 19, 2018 at 10:21:13AM +0000, Fabrizio Castro wrote:
> Hello Geert,
> 
> Thank you for your feedback.
> 
> > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
> >
> > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> 
> Your proposal is with me, Simon do you want me to send a v2 for this?

Thanks, I have applied this for v4.20 with the updated subject
and Geert's review tag.

> >
> > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > second CPU core, and use "renesas,apmu" as "enable-method".
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

...

On Wed, Sep 19, 2018 at 10:24:00AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback.
> 
> > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
> >
> > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> > >
> > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > > second CPU core, and use "renesas,apmu" as "enable-method".
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> > I would like to ask to what extent this has been tested with respect to
> > CPU hotplug, suspend to RAM, and combinations thereof.
> 
> Both CPU hotplug and STR were tested on their own and combined, I haven't encountered any issue so far.

On Wed, Sep 19, 2018 at 10:32:24AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback.
> 
> > Subject: Re: [PATCH 2/2] ARM: dts: r8a77470: Add APMU node and second CPU core
> >
> > On Wed, Sep 19, 2018 at 10:25:42AM +0200, Simon Horman wrote:
> > > On Mon, Sep 17, 2018 at 10:53:16AM +0200, Geert Uytterhoeven wrote:
> > > > Perhaps "ARM: dts: r8a77470: Add SMP support"?
> > > >
> > > > On Mon, Sep 17, 2018 at 10:44 AM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > Add DT node for the Advanced Power Management Unit (APMU), add the
> > > > > second CPU core, and use "renesas,apmu" as "enable-method".
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > Reviewed-by: Biju Das <biju.das@bp.renesas.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > I would like to ask to what extent this has been tested with respect to
> > > CPU hotplug, suspend to RAM, and combinations thereof.
> >
> > And any details of firmware, bootloader, ... version stacks where this is
> > supported.
> 
> iW-RainboW-G23S SPI_LOADER(DDR3) V1.00 2016.03.25
> U-Boot 2013.01.01-gaa28b1d-dirty (Feb 01 2018 - 22:55:39)
> 
> # cat /sys/devices/soc0/revision
> ES2.0
> 
> I hope this helps.

Thanks for your follow-up on the testing and environment,
it does indeed help to give me confidence when applying this patch.


...