From: Oscar Salvador <osalvador@techadventures.net> To: akpm@linux-foundation.org Cc: mhocko@suse.com, dan.j.williams@intel.com, david@redhat.com, Pavel.Tatashin@microsoft.com, Jonathan.Cameron@huawei.com, yasu.isimatu@gmail.com, malat@debian.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de> Subject: [PATCH 1/5] mm/memory_hotplug: Spare unnecessary calls to node_set_state Date: Wed, 19 Sep 2018 12:08:15 +0200 [thread overview] Message-ID: <20180919100819.25518-2-osalvador@techadventures.net> (raw) In-Reply-To: <20180919100819.25518-1-osalvador@techadventures.net> From: Oscar Salvador <osalvador@suse.de> In node_states_check_changes_online, we check if the node will have to be set for any of the N_*_MEMORY states after the pages have been onlined. Later on, we perform the activation in node_states_set_node. Currently, in node_states_set_node we set the node to N_MEMORY unconditionally. This means that we call node_set_state for N_MEMORY every time pages go online, but we only need to do it if the node has not yet been set for N_MEMORY. Fix this by checking status_change_nid. Signed-off-by: Oscar Salvador <osalvador@suse.de> --- mm/memory_hotplug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index 38d94b703e9d..63facfc57224 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -753,7 +753,8 @@ static void node_states_set_node(int node, struct memory_notify *arg) if (arg->status_change_nid_high >= 0) node_set_state(node, N_HIGH_MEMORY); - node_set_state(node, N_MEMORY); + if (arg->status_change_nid >= 0) + node_set_state(node, N_MEMORY); } static void __meminit resize_zone_range(struct zone *zone, unsigned long start_pfn, -- 2.13.6
next prev parent reply other threads:[~2018-09-19 10:09 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-19 10:08 [PATCH 0/5] Refactor node_states_check_changes_online/offline Oscar Salvador 2018-09-19 10:08 ` Oscar Salvador [this message] 2018-09-20 20:53 ` [PATCH 1/5] mm/memory_hotplug: Spare unnecessary calls to node_set_state Pasha Tatashin 2018-09-19 10:08 ` [PATCH 2/5] mm/memory_hotplug: Avoid node_set/clear_state(N_HIGH_MEMORY) when !CONFIG_HIGHMEM Oscar Salvador 2018-09-20 20:59 ` Pasha Tatashin 2018-09-21 10:31 ` Oscar Salvador 2018-09-19 10:08 ` [PATCH 3/5] mm/memory_hotplug: Tidy up node_states_clear_node Oscar Salvador 2018-09-20 23:40 ` Pasha Tatashin 2018-09-19 10:08 ` [PATCH 4/5] mm/memory_hotplug: Simplify node_states_check_changes_online Oscar Salvador 2018-09-21 0:15 ` Pasha Tatashin 2018-09-21 10:30 ` Oscar Salvador 2018-09-19 10:08 ` [PATCH 5/5] mm/memory_hotplug: Clean up node_states_check_changes_offline Oscar Salvador 2018-09-21 0:38 ` Pasha Tatashin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180919100819.25518-2-osalvador@techadventures.net \ --to=osalvador@techadventures.net \ --cc=Jonathan.Cameron@huawei.com \ --cc=Pavel.Tatashin@microsoft.com \ --cc=akpm@linux-foundation.org \ --cc=dan.j.williams@intel.com \ --cc=david@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=malat@debian.org \ --cc=mhocko@suse.com \ --cc=osalvador@suse.de \ --cc=yasu.isimatu@gmail.com \ --subject='Re: [PATCH 1/5] mm/memory_hotplug: Spare unnecessary calls to node_set_state' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.