* [OSSTEST PATCH] make-flight: Test with `sched=credit'
@ 2018-09-19 10:57 Ian Jackson
2018-09-19 10:59 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Ian Jackson @ 2018-09-19 10:57 UTC (permalink / raw)
To: xen-devel
Cc: Tim Deegan, Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
Andrew Cooper, Ian Jackson, George Dunlap, Dario Faggioli,
Jan Beulich
The default in xen-unstable#staging is soon to be sched=credit2. That
leaves osstest not testing credit1 at all.
Add a job that does this. It's a copy of the -credit2 job. (It's
a pretty nugatory test but it will probably do.)
We call the test -credit1, although the Xen parameter is =credit.
I have verified with standalone-generate-dump-flight-runvars that the
effect is to add the appropriately mutated copy of the credit2 job to
every flight. The mutations are solely the sched= parameter and the
job name.
CC: George Dunlap <george.dunlap@citrix.com>
CC: Dario Faggioli <dfaggioli@suse.com>
CC: Jan Beulich <JBeulich@suse.com>
CC: Andrew Cooper <andrew.cooper3@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Tim Deegan <tim@xen.org>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
make-flight | 12 ++++++++----
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/make-flight b/make-flight
index 96c261b5..93c82a21 100755
--- a/make-flight
+++ b/make-flight
@@ -493,15 +493,19 @@ do_hvm_rhel6_tests () {
done
}
-do_credit2_tests () {
+do_credit12_tests () {
if [ $xenarch != $dom0arch ]; then
return
fi
- job_create_test test-$xenarch$kern-$dom0arch-xl-credit2 \
+ for c in credit1:credit credit2:credit2; do
+
+ job_create_test test-$xenarch$kern-$dom0arch-xl-${c%:*} \
test-debian xl $xenarch $dom0arch \
- guests_vcpus=4 xen_boot_append='sched=credit2' \
+ guests_vcpus=4 xen_boot_append="sched=${c#*:}" \
$debian_runvars all_hostflags=$most_hostflags
+
+ done
}
do_rtds_tests () {
@@ -730,7 +734,7 @@ test_matrix_do_one () {
esac
do_rtds_tests
- do_credit2_tests
+ do_credit12_tests
do_examine_one
--
2.11.0
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [OSSTEST PATCH] make-flight: Test with `sched=credit'
2018-09-19 10:57 [OSSTEST PATCH] make-flight: Test with `sched=credit' Ian Jackson
@ 2018-09-19 10:59 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2018-09-19 10:59 UTC (permalink / raw)
To: Ian Jackson
Cc: Stefano Stabellini, Wei Liu, Konrad Rzeszutek Wilk,
Andrew Cooper, Tim Deegan, George Dunlap, Dario Faggioli,
Jan Beulich, xen-devel
On Wed, Sep 19, 2018 at 11:57:20AM +0100, Ian Jackson wrote:
> The default in xen-unstable#staging is soon to be sched=credit2. That
> leaves osstest not testing credit1 at all.
>
> Add a job that does this. It's a copy of the -credit2 job. (It's
> a pretty nugatory test but it will probably do.)
>
> We call the test -credit1, although the Xen parameter is =credit.
>
> I have verified with standalone-generate-dump-flight-runvars that the
> effect is to add the appropriately mutated copy of the credit2 job to
> every flight. The mutations are solely the sched= parameter and the
> job name.
>
> CC: George Dunlap <george.dunlap@citrix.com>
> CC: Dario Faggioli <dfaggioli@suse.com>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Tim Deegan <tim@xen.org>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-19 10:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 10:57 [OSSTEST PATCH] make-flight: Test with `sched=credit' Ian Jackson
2018-09-19 10:59 ` Wei Liu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.