From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Tomas Winkler <tomas.winkler@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>,
Alexander Usyskin <alexander.usyskin@intel.com>,
Tadeusz Struk <tadeusz.struk@intel.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts
Date: Wed, 19 Sep 2018 17:04:25 +0300 [thread overview]
Message-ID: <20180919140425.GH26571@linux.intel.com> (raw)
In-Reply-To: <20180918093459.19165-6-tomas.winkler@intel.com>
On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote:
> Factor out tpm_get_timeouts into tpm2_get_timeouts
> and tpm1_get_timeouts.
Function names missing parentheses. Should be there for clarity when
used in a sentence. Otherwise, the commit looks fine.
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: jarkko.sakkinen@linux.intel.com (Jarkko Sakkinen)
To: linux-security-module@vger.kernel.org
Subject: [PATCH v3 05/20] tpm: factor out tpm_get_timeouts
Date: Wed, 19 Sep 2018 17:04:25 +0300 [thread overview]
Message-ID: <20180919140425.GH26571@linux.intel.com> (raw)
In-Reply-To: <20180918093459.19165-6-tomas.winkler@intel.com>
On Tue, Sep 18, 2018 at 12:34:44PM +0300, Tomas Winkler wrote:
> Factor out tpm_get_timeouts into tpm2_get_timeouts
> and tpm1_get_timeouts.
Function names missing parentheses. Should be there for clarity when
used in a sentence. Otherwise, the commit looks fine.
Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
/Jarkko
next prev parent reply other threads:[~2018-09-19 14:04 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 9:34 [PATCH v3 00/20] tpm: separate tpm 1.x and tpm 2.x commands Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-18 9:34 ` [PATCH v3 01/20] tpm2: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
[not found] ` <20180919134627.GA26571@linux.intel.com>
2018-09-19 13:59 ` Jarkko Sakkinen
2018-09-19 13:59 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 02/20] tpm: sort objects in the Makefile Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 13:48 ` Jarkko Sakkinen
2018-09-19 13:48 ` Jarkko Sakkinen
2018-09-19 13:59 ` Jarkko Sakkinen
2018-09-19 13:59 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 03/20] tpm: factor out tpm 1.x duration calculation to tpm1-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 13:55 ` Jarkko Sakkinen
2018-09-19 13:55 ` Jarkko Sakkinen
2018-09-19 14:00 ` Jarkko Sakkinen
2018-09-19 14:00 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 04/20] tpm: add tpm_calc_ordinal_duration wrapper Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:02 ` Jarkko Sakkinen
2018-09-19 14:02 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 05/20] tpm: factor out tpm_get_timeouts Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:04 ` Jarkko Sakkinen [this message]
2018-09-19 14:04 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 06/20] tpm: move tpm1_pcr_extend to tpm1-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:06 ` Jarkko Sakkinen
2018-09-19 14:06 ` Jarkko Sakkinen
2018-09-19 14:06 ` Jarkko Sakkinen
2018-09-25 16:25 ` Nayna Jain
2018-09-25 16:25 ` Nayna Jain
2018-09-25 16:25 ` Nayna Jain
2018-09-18 9:34 ` [PATCH v3 07/20] tpm: move tpm_getcap " Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:09 ` Jarkko Sakkinen
2018-09-19 14:09 ` Jarkko Sakkinen
2018-09-19 14:09 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 08/20] tpm: factor out tpm1_get_random into tpm1-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:56 ` Jarkko Sakkinen
2018-09-19 14:56 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 09/20] tpm: move tpm1 selftest code from tpm-interface tpm1-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:05 ` Jarkko Sakkinen
2018-09-19 15:05 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 10/20] tpm: factor out tpm1 pm suspend flow into tpm1-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:03 ` Jarkko Sakkinen
2018-09-19 15:03 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 11/20] tpm: factor out tpm_startup function Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:07 ` Jarkko Sakkinen
2018-09-19 15:07 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 12/20] tpm: move pcr extend code to tpm2-cmd.c Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 14:58 ` Jarkko Sakkinen
2018-09-19 14:58 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 13/20] tpm: add tpm_auto_startup into tpm-interface Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:09 ` Jarkko Sakkinen
2018-09-19 15:09 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 14/20] tpm: tpm-interface.c drop unused macros Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:10 ` Jarkko Sakkinen
2018-09-19 15:10 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 15/20] tpm: tpm-space.c remove unneeded semicolon Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:12 ` Jarkko Sakkinen
2018-09-19 15:12 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 16/20] tpm: tpm1: rewrite tpm1_get_random() using tpm_buf structure Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:12 ` Jarkko Sakkinen
2018-09-19 15:12 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 17/20] tpm1: implement tpm1_pcr_read_dev() " Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:13 ` Jarkko Sakkinen
2018-09-19 15:13 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 18/20] tpm: use u32 instead of int for pcr index Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:22 ` Jarkko Sakkinen
2018-09-19 15:22 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 19/20] tpm1: reimplement SAVESTATE using tpm_buf Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:23 ` Jarkko Sakkinen
2018-09-19 15:23 ` Jarkko Sakkinen
2018-09-18 9:34 ` [PATCH v3 20/20] tpm1: reimplement tpm1_continue_selftest() " Tomas Winkler
2018-09-18 9:34 ` Tomas Winkler
2018-09-19 15:24 ` Jarkko Sakkinen
2018-09-19 15:24 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180919140425.GH26571@linux.intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=tadeusz.struk@intel.com \
--cc=tomas.winkler@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.