All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting
Date: Thu, 20 Sep 2018 14:26:28 +0300	[thread overview]
Message-ID: <20180920112628.GE11965@kuha.fi.intel.com> (raw)
In-Reply-To: <20180920112003.GA12655@kroah.com>

On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote:
> On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote:
> > Functions typec_mux_get() and typec_switch_get() already
> > make sure that the mux device reference count is
> > incremented, but the same must be done to the driver module
> > as well to prevent the drivers from being unloaded in the
> > middle of operation.
> > 
> > This fixes a potential "BUG: unable to handle kernel paging
> > request at ..." from happening.
> > 
> > Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter")
> > Cc: <stable@vger.kernel.org>
> 
> Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has
> not been backported anywhere else.
> 
> confused,

Sorry, it should not have the stable tag. Shall I resend these?

Thanks,

-- 
heikki

WARNING: multiple messages have this Message-ID (diff)
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Hans de Goede <hdegoede@redhat.com>,
	linux-usb@vger.kernel.org, stable@vger.kernel.org
Subject: [1/2] usb: typec: mux: Take care of driver module reference counting
Date: Thu, 20 Sep 2018 14:26:28 +0300	[thread overview]
Message-ID: <20180920112628.GE11965@kuha.fi.intel.com> (raw)

On Thu, Sep 20, 2018 at 01:20:03PM +0200, Greg KH wrote:
> On Wed, Sep 19, 2018 at 10:58:04AM +0300, Heikki Krogerus wrote:
> > Functions typec_mux_get() and typec_switch_get() already
> > make sure that the mux device reference count is
> > incremented, but the same must be done to the driver module
> > as well to prevent the drivers from being unloaded in the
> > middle of operation.
> > 
> > This fixes a potential "BUG: unable to handle kernel paging
> > request at ..." from happening.
> > 
> > Fixes: 93dd2112c7b2 ("usb: typec: mux: Get the mux identifier from function parameter")
> > Cc: <stable@vger.kernel.org>
> 
> Why is this flagged for stable? 93dd2112c7b2 went into 4.19-rc1 and has
> not been backported anywhere else.
> 
> confused,

Sorry, it should not have the stable tag. Shall I resend these?

Thanks,

  reply	other threads:[~2018-09-20 17:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180919075805.61319-1-heikki.krogerus@linux.intel.com>
2018-09-19  7:58 ` [PATCH 1/2] usb: typec: mux: Take care of driver module reference counting Heikki Krogerus
2018-09-19  7:58   ` [1/2] " Heikki Krogerus
2018-09-19 18:58   ` [PATCH 1/2] " Sasha Levin
2018-09-19 18:58     ` [1/2] " Sasha Levin
2018-09-20 11:20   ` [PATCH 1/2] " Greg KH
2018-09-20 11:20     ` [1/2] " Greg Kroah-Hartman
2018-09-20 11:26     ` Heikki Krogerus [this message]
2018-09-20 11:26       ` Heikki Krogerus
2018-09-20 11:34       ` [PATCH 1/2] " Greg KH
2018-09-20 11:34         ` [1/2] " Greg Kroah-Hartman
2018-09-19  7:58 ` [PATCH 2/2] usb: roles: " Heikki Krogerus
2018-09-19  7:58   ` [2/2] " Heikki Krogerus
2018-09-19 18:58   ` [PATCH 2/2] " Sasha Levin
2018-09-19 18:58     ` [2/2] " Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920112628.GE11965@kuha.fi.intel.com \
    --to=heikki.krogerus@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.