* [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 12:32 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-20 12:32 UTC (permalink / raw)
To: linux-arm-kernel
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
YueHaibing (22):
net: micrel: fix return type of ndo_start_xmit function
net: freescale: fix return type of ndo_start_xmit function
net: seeq: fix return type of ndo_start_xmit function
net: cirrus: fix return type of ndo_start_xmit function
net: sgi: fix return type of ndo_start_xmit function
net: wiznet: fix return type of ndo_start_xmit function
net: i825xx: fix return type of ndo_start_xmit function
net: apple: fix return type of ndo_start_xmit function
net: smsc: fix return type of ndo_start_xmit function
net: ti: fix return type of ndo_start_xmit function
net: faraday: fix return type of ndo_start_xmit function
net: ovs: fix return type of ndo_start_xmit function
net: xen-netback: fix return type of ndo_start_xmit function
net: caif: fix return type of ndo_start_xmit function
net: hamradio: fix return type of ndo_start_xmit function
usbnet: ipheth: fix return type of ndo_start_xmit function
hv_netvsc: fix return type of ndo_start_xmit function
can: xilinx: fix return type of ndo_start_xmit function
net: plip: fix return type of ndo_start_xmit function
rionet: fix return type of ndo_start_xmit function
l2tp: fix return type of ndo_start_xmit function
net: hsr: fix return type of ndo_start_xmit function
drivers/net/caif/caif_hsi.c | 10 +++++-----
drivers/net/caif/caif_serial.c | 7 +++++--
drivers/net/caif/caif_spi.c | 6 +++---
drivers/net/caif/caif_virtio.c | 2 +-
drivers/net/can/xilinx_can.c | 2 +-
drivers/net/ethernet/apple/bmac.c | 4 ++--
drivers/net/ethernet/apple/mace.c | 4 ++--
drivers/net/ethernet/apple/macmace.c | 4 ++--
drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +-
drivers/net/ethernet/cirrus/mac89x0.c | 4 ++--
drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--
drivers/net/ethernet/faraday/ftmac100.c | 7 ++++---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 3 ++-
drivers/net/ethernet/freescale/fec_mpc52xx.c | 3 ++-
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 3 ++-
drivers/net/ethernet/freescale/gianfar.c | 4 ++--
drivers/net/ethernet/freescale/ucc_geth.c | 3 ++-
drivers/net/ethernet/i825xx/ether1.c | 5 +++--
drivers/net/ethernet/i825xx/lib82596.c | 4 ++--
drivers/net/ethernet/i825xx/sun3_82586.c | 6 ++++--
drivers/net/ethernet/micrel/ks8695net.c | 2 +-
drivers/net/ethernet/micrel/ks8851_mll.c | 4 ++--
drivers/net/ethernet/seeq/ether3.c | 5 +++--
drivers/net/ethernet/seeq/sgiseeq.c | 3 ++-
drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++--
drivers/net/ethernet/sgi/meth.c | 2 +-
drivers/net/ethernet/smsc/smc911x.c | 3 ++-
drivers/net/ethernet/smsc/smc91x.c | 3 ++-
drivers/net/ethernet/smsc/smsc911x.c | 3 ++-
drivers/net/ethernet/ti/cpmac.c | 2 +-
drivers/net/ethernet/ti/davinci_emac.c | 2 +-
drivers/net/ethernet/ti/netcp_core.c | 8 ++++----
drivers/net/ethernet/wiznet/w5100.c | 2 +-
drivers/net/ethernet/wiznet/w5300.c | 2 +-
drivers/net/hamradio/baycom_epp.c | 3 ++-
drivers/net/hamradio/dmascc.c | 4 ++--
drivers/net/hyperv/netvsc_drv.c | 10 +++++++---
drivers/net/plip/plip.c | 4 ++--
drivers/net/rionet.c | 3 ++-
drivers/net/usb/ipheth.c | 2 +-
drivers/net/xen-netback/interface.c | 3 ++-
net/caif/chnl_net.c | 3 ++-
net/hsr/hsr_device.c | 2 +-
net/l2tp/l2tp_eth.c | 3 ++-
net/openvswitch/vport-internal_dev.c | 5 +++--
45 files changed, 100 insertions(+), 74 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 12:32 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-20 12:32 UTC (permalink / raw)
To: davem, dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten,
madalin.bucur, pantelis.antoniou, claudiu.manoil, leoyang.li,
linux, sammy, ralf, nico, steve.glendinning, f.fainelli,
grygorii.strashko, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: linux-kernel, netdev, linux-can, linux-arm-kernel, linuxppc-dev,
linux-mips, linux-omap, linux-hams, devel, linux-usb, xen-devel,
dev, YueHaibing
The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
which is a typedef for an enum type, so make sure the implementation in
this driver has returns 'netdev_tx_t' value, and change the function
return type to netdev_tx_t.
YueHaibing (22):
net: micrel: fix return type of ndo_start_xmit function
net: freescale: fix return type of ndo_start_xmit function
net: seeq: fix return type of ndo_start_xmit function
net: cirrus: fix return type of ndo_start_xmit function
net: sgi: fix return type of ndo_start_xmit function
net: wiznet: fix return type of ndo_start_xmit function
net: i825xx: fix return type of ndo_start_xmit function
net: apple: fix return type of ndo_start_xmit function
net: smsc: fix return type of ndo_start_xmit function
net: ti: fix return type of ndo_start_xmit function
net: faraday: fix return type of ndo_start_xmit function
net: ovs: fix return type of ndo_start_xmit function
net: xen-netback: fix return type of ndo_start_xmit function
net: caif: fix return type of ndo_start_xmit function
net: hamradio: fix return type of ndo_start_xmit function
usbnet: ipheth: fix return type of ndo_start_xmit function
hv_netvsc: fix return type of ndo_start_xmit function
can: xilinx: fix return type of ndo_start_xmit function
net: plip: fix return type of ndo_start_xmit function
rionet: fix return type of ndo_start_xmit function
l2tp: fix return type of ndo_start_xmit function
net: hsr: fix return type of ndo_start_xmit function
drivers/net/caif/caif_hsi.c | 10 +++++-----
drivers/net/caif/caif_serial.c | 7 +++++--
drivers/net/caif/caif_spi.c | 6 +++---
drivers/net/caif/caif_virtio.c | 2 +-
drivers/net/can/xilinx_can.c | 2 +-
drivers/net/ethernet/apple/bmac.c | 4 ++--
drivers/net/ethernet/apple/mace.c | 4 ++--
drivers/net/ethernet/apple/macmace.c | 4 ++--
drivers/net/ethernet/cirrus/ep93xx_eth.c | 2 +-
drivers/net/ethernet/cirrus/mac89x0.c | 4 ++--
drivers/net/ethernet/faraday/ftgmac100.c | 4 ++--
drivers/net/ethernet/faraday/ftmac100.c | 7 ++++---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 3 ++-
drivers/net/ethernet/freescale/fec_mpc52xx.c | 3 ++-
drivers/net/ethernet/freescale/fs_enet/fs_enet-main.c | 3 ++-
drivers/net/ethernet/freescale/gianfar.c | 4 ++--
drivers/net/ethernet/freescale/ucc_geth.c | 3 ++-
drivers/net/ethernet/i825xx/ether1.c | 5 +++--
drivers/net/ethernet/i825xx/lib82596.c | 4 ++--
drivers/net/ethernet/i825xx/sun3_82586.c | 6 ++++--
drivers/net/ethernet/micrel/ks8695net.c | 2 +-
drivers/net/ethernet/micrel/ks8851_mll.c | 4 ++--
drivers/net/ethernet/seeq/ether3.c | 5 +++--
drivers/net/ethernet/seeq/sgiseeq.c | 3 ++-
drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++--
drivers/net/ethernet/sgi/meth.c | 2 +-
drivers/net/ethernet/smsc/smc911x.c | 3 ++-
drivers/net/ethernet/smsc/smc91x.c | 3 ++-
drivers/net/ethernet/smsc/smsc911x.c | 3 ++-
drivers/net/ethernet/ti/cpmac.c | 2 +-
drivers/net/ethernet/ti/davinci_emac.c | 2 +-
drivers/net/ethernet/ti/netcp_core.c | 8 ++++----
drivers/net/ethernet/wiznet/w5100.c | 2 +-
drivers/net/ethernet/wiznet/w5300.c | 2 +-
drivers/net/hamradio/baycom_epp.c | 3 ++-
drivers/net/hamradio/dmascc.c | 4 ++--
drivers/net/hyperv/netvsc_drv.c | 10 +++++++---
drivers/net/plip/plip.c | 4 ++--
drivers/net/rionet.c | 3 ++-
drivers/net/usb/ipheth.c | 2 +-
drivers/net/xen-netback/interface.c | 3 ++-
net/caif/chnl_net.c | 3 ++-
net/hsr/hsr_device.c | 2 +-
net/l2tp/l2tp_eth.c | 3 ++-
net/openvswitch/vport-internal_dev.c | 5 +++--
45 files changed, 100 insertions(+), 74 deletions(-)
--
1.8.3.1
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 12:32 ` YueHaibing
(?)
(?)
@ 2018-09-20 15:50 ` David Miller
-1 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2018-09-20 15:50 UTC (permalink / raw)
To: yuehaibing
Cc: dmitry.tarnyagin, madalin.bucur, linux-mips, linux,
pantelis.antoniou, kys, t.sailer, dev, f.fainelli, arvid.brodin,
michal.simek, pshelar, m-karicheri2, xen-devel, jreuter, sammy,
grygorii.strashko, w-kwok2, haiyangz, steve.glendinning,
linux-can, claudiu.manoil, paul.durrant, mkl, linux-hams,
linux-omap, linux-arm-kernel, wei.liu2, nico, netdev, linux-usb,
linux-kernel, ralf, leoyang.li, hsweeten, wg, devel
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
I would advise you not to send so many of these changes as a group.
If one of the patches needs feedback addressed, which is already the
case, you will have to resubmit the entire series all over again with
the fixes.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 12:32 ` YueHaibing
(?)
@ 2018-09-20 15:50 ` David Miller
-1 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2018-09-20 15:50 UTC (permalink / raw)
To: yuehaibing
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-dev, linux-mips,
linux-omap
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
I would advise you not to send so many of these changes as a group.
If one of the patches needs feedback addressed, which is already the
case, you will have to resubmit the entire series all over again with
the fixes.
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 15:50 ` David Miller
0 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2018-09-20 15:50 UTC (permalink / raw)
To: linux-arm-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
I would advise you not to send so many of these changes as a group.
If one of the patches needs feedback addressed, which is already the
case, you will have to resubmit the entire series all over again with
the fixes.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 15:50 ` David Miller
0 siblings, 0 replies; 20+ messages in thread
From: David Miller @ 2018-09-20 15:50 UTC (permalink / raw)
To: yuehaibing
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-dev, linux-mips,
linux-omap, linux-hams, devel, linux-usb, xen-devel, dev
From: YueHaibing <yuehaibing@huawei.com>
Date: Thu, 20 Sep 2018 20:32:44 +0800
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
I would advise you not to send so many of these changes as a group.
If one of the patches needs feedback addressed, which is already the
case, you will have to resubmit the entire series all over again with
the fixes.
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 15:50 ` David Miller
` (2 preceding siblings ...)
(?)
@ 2018-09-21 1:33 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: David Miller
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-21 1:33 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: linux-arm-kernel
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-21 1:33 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: David Miller
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-dev, linux-mips,
linux-omap, linux-hams, devel, linux-usb, xen-devel, dev
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-21 1:33 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: David Miller
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-21 1:33 ` YueHaibing
0 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: David Miller
Cc: dmitry.tarnyagin, wg, mkl, michal.simek, hsweeten, madalin.bucur,
pantelis.antoniou, claudiu.manoil, leoyang.li, linux, sammy,
ralf, nico, steve.glendinning, f.fainelli, grygorii.strashko,
w-kwok2, m-karicheri2, t.sailer, jreuter, kys, haiyangz,
wei.liu2, paul.durrant, arvid.brodin, pshelar, linux-kernel,
netdev, linux-can, linux-arm-kernel, linuxppc-dev, linux-mips,
linux-omap, linux-hams, devel, linux-usb, xen-devel, dev
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 15:50 ` David Miller
` (2 preceding siblings ...)
(?)
@ 2018-09-21 1:33 ` YueHaibing
-1 siblings, 0 replies; 20+ messages in thread
From: YueHaibing @ 2018-09-21 1:33 UTC (permalink / raw)
To: David Miller
Cc: dmitry.tarnyagin, madalin.bucur, linux-mips, linux,
pantelis.antoniou, kys, t.sailer, dev, f.fainelli, arvid.brodin,
michal.simek, pshelar, m-karicheri2, xen-devel, jreuter, sammy,
grygorii.strashko, w-kwok2, haiyangz, steve.glendinning,
linux-can, claudiu.manoil, paul.durrant, mkl, linux-hams,
linux-omap, linux-arm-kernel, wei.liu2, nico, netdev, linux-usb,
linux-kernel, ralf, leoyang.li, hsweeten, wg, devel
On 2018/9/20 23:50, David Miller wrote:
> From: YueHaibing <yuehaibing@huawei.com>
> Date: Thu, 20 Sep 2018 20:32:44 +0800
>
>> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
>> which is a typedef for an enum type, so make sure the implementation in
>> this driver has returns 'netdev_tx_t' value, and change the function
>> return type to netdev_tx_t.
>
> I would advise you not to send so many of these changes as a group.
>
> If one of the patches needs feedback addressed, which is already the
> case, you will have to resubmit the entire series all over again with
> the fixes.
>
Yes, I will send it separately after test and review again.
Thank you for your advice.
> .
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 12:32 ` YueHaibing
` (3 preceding siblings ...)
(?)
@ 2018-09-20 17:04 ` Grygorii Strashko
-1 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: YueHaibing, davem, dmitry.tarnyagin, wg, mkl, michal.simek,
hsweeten, madalin.bucur, pantelis.antoniou, claudiu.manoil,
leoyang.li, linux, sammy, ralf, nico, steve.glendinning,
f.fainelli, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: dev, linux-mips, xen-devel, netdev, linux-usb, linux-kernel,
linux-can, devel, linux-hams, linux-omap, linuxppc-dev,
linux-arm-kernel
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
2018-09-20 12:32 ` YueHaibing
` (2 preceding siblings ...)
(?)
@ 2018-09-20 17:04 ` Grygorii Strashko
-1 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: YueHaibing, davem, dmitry.tarnyagin, wg, mkl, michal.simek,
hsweeten, madalin.bucur, pantelis.antoniou, claudiu.manoil,
leoyang.li, linux, sammy, ralf, nico, steve.glendinning,
f.fainelli, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: dev, linux-mips, xen-devel, netdev, linux-usb, linux-kernel,
linux-can, devel, linux-hams, linux-omap, linuxppc-dev,
linux-arm-kernel
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 17:04 ` Grygorii Strashko
0 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: linux-arm-kernel
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 17:04 ` Grygorii Strashko
0 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: YueHaibing, davem, dmitry.tarnyagin, wg, mkl, michal.simek,
hsweeten, madalin.bucur, pantelis.antoniou, claudiu.manoil,
leoyang.li, linux, sammy, ralf, nico, steve.glendinning,
f.fainelli, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: linux-kernel, netdev, linux-can, linux-arm-kernel, linuxppc-dev,
linux-mips, linux-omap, linux-hams, devel, linux-usb, xen-devel,
dev
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 17:04 ` Grygorii Strashko
0 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: YueHaibing, davem, dmitry.tarnyagin, wg, mkl, michal.simek,
hsweeten, madalin.bucur, pantelis.antoniou, claudiu.manoil,
leoyang.li, linux, sammy, ralf, nico, steve.glendinning,
f.fainelli, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: dev, linux-mips, xen-devel, netdev, linux-usb, linux-kernel,
linux-can, devel, linux-hams, linux-omap, linuxppc-dev,
linux-arm-kernel
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH net-next 00/22] net: fix return type of ndo_start_xmit function
@ 2018-09-20 17:04 ` Grygorii Strashko
0 siblings, 0 replies; 20+ messages in thread
From: Grygorii Strashko @ 2018-09-20 17:04 UTC (permalink / raw)
To: YueHaibing, davem, dmitry.tarnyagin, wg, mkl, michal.simek,
hsweeten, madalin.bucur, pantelis.antoniou, claudiu.manoil,
leoyang.li, linux, sammy, ralf, nico, steve.glendinning,
f.fainelli, w-kwok2, m-karicheri2, t.sailer, jreuter, kys,
haiyangz, wei.liu2, paul.durrant, arvid.brodin, pshelar
Cc: linux-kernel, netdev, linux-can, linux-arm-kernel, linuxppc-dev,
linux-mips, linux-omap, linux-hams, devel, linux-usb, xen-devel,
dev
On 09/20/2018 07:32 AM, YueHaibing wrote:
> The method ndo_start_xmit() is defined as returning an 'netdev_tx_t',
> which is a typedef for an enum type, so make sure the implementation in
> this driver has returns 'netdev_tx_t' value, and change the function
> return type to netdev_tx_t.
>
May be I missed smth, but it's acceptable to report standard error codes from
.xmit() callback as per dev_xmit_complete().
--
regards,
-grygorii
^ permalink raw reply [flat|nested] 20+ messages in thread