From: Christoph Hellwig <hch@infradead.org>
To: Zong Li <zongbox@gmail.com>
Cc: palmer@sifive.com, aou@eecs.berkeley.edu, vincentc@andestech.com,
zong@andestech.com, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap
Date: Fri, 21 Sep 2018 00:00:59 -0700 [thread overview]
Message-ID: <20180921070059.GD8401@infradead.org> (raw)
In-Reply-To: <9fc325660fb1e0ef9133705f7c05784dcc12c0c2.1537260207.git.zongbox@gmail.com>
On Tue, Sep 18, 2018 at 05:19:17PM +0800, Zong Li wrote:
> From: Vincent Chen <vincentc@andestech.com>
>
> For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero
> after AND with PAGE_MASK because the data type of PAGE_MASK is
> unsigned long. To fix this problem, the page alignment is done by
> subtracting the page offset instead of AND with PAGE_MASK.
>
> Signed-off-by: Vincent Chen <vincentc@andestech.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
WARNING: multiple messages have this Message-ID (diff)
From: hch@infradead.org (Christoph Hellwig)
To: linux-riscv@lists.infradead.org
Subject: [PATCH 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap
Date: Fri, 21 Sep 2018 00:00:59 -0700 [thread overview]
Message-ID: <20180921070059.GD8401@infradead.org> (raw)
In-Reply-To: <9fc325660fb1e0ef9133705f7c05784dcc12c0c2.1537260207.git.zongbox@gmail.com>
On Tue, Sep 18, 2018 at 05:19:17PM +0800, Zong Li wrote:
> From: Vincent Chen <vincentc@andestech.com>
>
> For 32bit, the upper 32-bit of phys_addr_t will be flushed to zero
> after AND with PAGE_MASK because the data type of PAGE_MASK is
> unsigned long. To fix this problem, the page alignment is done by
> subtracting the page offset instead of AND with PAGE_MASK.
>
> Signed-off-by: Vincent Chen <vincentc@andestech.com>
Looks fine,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2018-09-21 7:01 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-18 9:19 [PATCH 0/5] Fix some bugs on RV32 build fail and issue Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-18 9:19 ` [PATCH 1/5] RISC-V: Build tishift only on 64-bit Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-21 6:58 ` Christoph Hellwig
2018-09-21 6:58 ` Christoph Hellwig
2018-09-25 2:33 ` Zong Li
2018-09-25 2:33 ` Zong Li
2018-09-25 2:33 ` Zong Li
2018-09-18 9:19 ` [PATCH 2/5] RISC-V: Use swiotlb on RV64 only Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-21 6:59 ` Christoph Hellwig
2018-09-21 6:59 ` Christoph Hellwig
2018-09-18 9:19 ` [PATCH 3/5] lib: Add umoddi3 and udivmoddi4 of GCC library routines Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-21 7:00 ` Christoph Hellwig
2018-09-21 7:00 ` Christoph Hellwig
2018-09-25 2:19 ` Zong Li
2018-09-25 2:19 ` Zong Li
2018-09-25 2:19 ` Zong Li
2018-09-25 7:20 ` Andreas Schwab
2018-09-25 7:20 ` Andreas Schwab
2018-09-25 7:20 ` Andreas Schwab
2018-09-26 7:12 ` Zong Li
2018-09-26 7:12 ` Zong Li
2018-09-26 7:12 ` Zong Li
2018-09-25 15:25 ` Christoph Hellwig
2018-09-25 15:25 ` Christoph Hellwig
2018-09-25 15:25 ` Christoph Hellwig
2018-09-26 2:40 ` Zong Li
2018-09-26 2:40 ` Zong Li
2018-09-26 2:40 ` Zong Li
2018-09-18 9:19 ` [PATCH 4/5] RISC-V: Select GENERIC_LIB_UMODDI3 on RV32 Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-18 9:19 ` [PATCH 5/5] RISC-V: Avoid corrupting the upper 32-bit of phys_addr_t in ioremap Zong Li
2018-09-18 9:19 ` Zong Li
2018-09-21 7:00 ` Christoph Hellwig [this message]
2018-09-21 7:00 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180921070059.GD8401@infradead.org \
--to=hch@infradead.org \
--cc=aou@eecs.berkeley.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@sifive.com \
--cc=vincentc@andestech.com \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.