* [PATCH] drm/i915: set i915 driver probe to asynchronous
@ 2018-09-19 7:37 ning.a.zhang
2018-09-19 9:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-21 9:30 ` [PATCH] " Daniel Vetter
0 siblings, 2 replies; 6+ messages in thread
From: ning.a.zhang @ 2018-09-19 7:37 UTC (permalink / raw)
To: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied
Cc: intel-gfx, dri-devel, linux-kernel, Zhang Ning
From: Zhang Ning <ning.a.zhang@intel.com>
when i915 is built in module, and system has built-in display, eg. eDP,
i915 will detect and active it during driver probe. it will take long
time.
set i915 driver probe to asynchrous can save kernel initial time.
Signed-off-by: Zhang Ning <ning.a.zhang@intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 6a4d1388ad2d..0f57d71d0abb 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -738,6 +738,7 @@ static struct pci_driver i915_pci_driver = {
.probe = i915_pci_probe,
.remove = i915_pci_remove,
.driver.pm = &i915_pm_ops,
+ .driver.probe_type = PROBE_PREFER_ASYNCHRONOUS,
};
static int __init i915_init(void)
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915: set i915 driver probe to asynchronous
2018-09-19 7:37 [PATCH] drm/i915: set i915 driver probe to asynchronous ning.a.zhang
@ 2018-09-19 9:12 ` Patchwork
2018-09-20 1:34 ` Zhang, Ning A
2018-09-21 9:30 ` [PATCH] " Daniel Vetter
1 sibling, 1 reply; 6+ messages in thread
From: Patchwork @ 2018-09-19 9:12 UTC (permalink / raw)
To: ning.a.zhang; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: set i915 driver probe to asynchronous
URL : https://patchwork.freedesktop.org/series/49892/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4841 -> Patchwork_10221 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10221 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10221, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49892/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10221:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-reload-inject:
fi-skl-6260u: PASS -> INCOMPLETE
fi-snb-2600: PASS -> INCOMPLETE
fi-kbl-7560u: PASS -> INCOMPLETE
fi-skl-6770hq: PASS -> INCOMPLETE
fi-bwr-2160: PASS -> INCOMPLETE
fi-kbl-r: PASS -> INCOMPLETE
fi-cfl-s3: PASS -> INCOMPLETE
fi-cfl-8109u: PASS -> INCOMPLETE
fi-gdg-551: PASS -> INCOMPLETE
fi-bsw-kefka: PASS -> INCOMPLETE
fi-ilk-650: PASS -> INCOMPLETE
fi-bsw-n3050: PASS -> INCOMPLETE
fi-cnl-u: PASS -> INCOMPLETE
fi-kbl-7567u: PASS -> INCOMPLETE
fi-skl-iommu: PASS -> INCOMPLETE
fi-ivb-3770: PASS -> INCOMPLETE
fi-whl-u: PASS -> INCOMPLETE
fi-skl-6700hq: PASS -> INCOMPLETE
fi-kbl-7500u: PASS -> INCOMPLETE
fi-ivb-3520m: PASS -> INCOMPLETE
fi-hsw-4770: PASS -> INCOMPLETE
fi-bdw-5557u: PASS -> INCOMPLETE
fi-cfl-8700k: PASS -> INCOMPLETE
fi-hsw-peppy: PASS -> INCOMPLETE
fi-kbl-x1275: PASS -> INCOMPLETE
fi-pnv-d510: PASS -> INCOMPLETE
fi-blb-e6850: PASS -> INCOMPLETE
fi-skl-6700k2: PASS -> INCOMPLETE
== Known issues ==
Here are the changes found in Patchwork_10221 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload-inject:
fi-byt-j1900: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-byt-n2820: PASS -> INCOMPLETE (fdo#102657)
fi-bxt-j4205: PASS -> INCOMPLETE (fdo#103927)
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-glk-j4005: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
fi-skl-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-glk-dsi: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
fi-skl-6600u: PASS -> INCOMPLETE (fdo#104108)
fi-skl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-cfl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-elk-e7500: PASS -> INCOMPLETE (fdo#103989)
igt@gem_exec_suspend@basic-s3:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#107901)
igt@gem_exec_suspend@basic-s4-devices:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-WARN (fdo#102614)
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: PASS -> FAIL (fdo#107336)
fi-kbl-r: PASS -> FAIL (fdo#107336)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107901 https://bugs.freedesktop.org/show_bug.cgi?id=107901
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (52 -> 48) ==
Additional (1): fi-icl-u
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4841 -> Patchwork_10221
CI_DRM_4841: 4a03aefd83495146beca5f593558343aca40eb51 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10221: a3f7db648c33310dda049ba1ac885341779c6e37 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a3f7db648c33 drm/i915: set i915 driver probe to asynchronous
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10221/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fi.CI.BAT: failure for drm/i915: set i915 driver probe to asynchronous
2018-09-19 9:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-09-20 1:34 ` Zhang, Ning A
2018-09-20 7:44 ` Chris Wilson
0 siblings, 1 reply; 6+ messages in thread
From: Zhang, Ning A @ 2018-09-20 1:34 UTC (permalink / raw)
To: intel-gfx, joonas.lahtinen, jani.nikula, Vivi, Rodrigo
[-- Attachment #1.1: Type: text/plain, Size: 5905 bytes --]
I don't understand why CI failure, could you help me to resolve it?
在 2018-09-19三的 09:12 +0000，Patchwork写道：
== Series Details ==
Series: drm/i915: set i915 driver probe to asynchronous
URL : https://patchwork.freedesktop.org/series/49892/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4841 -> Patchwork_10221 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10221 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_10221, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49892/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10221:
=== IGT changes ===
==== Possible regressions ====
igt@drv_module_reload@basic-reload-inject:
fi-skl-6260u: PASS -> INCOMPLETE
fi-snb-2600: PASS -> INCOMPLETE
fi-kbl-7560u: PASS -> INCOMPLETE
fi-skl-6770hq: PASS -> INCOMPLETE
fi-bwr-2160: PASS -> INCOMPLETE
fi-kbl-r: PASS -> INCOMPLETE
fi-cfl-s3: PASS -> INCOMPLETE
fi-cfl-8109u: PASS -> INCOMPLETE
fi-gdg-551: PASS -> INCOMPLETE
fi-bsw-kefka: PASS -> INCOMPLETE
fi-ilk-650: PASS -> INCOMPLETE
fi-bsw-n3050: PASS -> INCOMPLETE
fi-cnl-u: PASS -> INCOMPLETE
fi-kbl-7567u: PASS -> INCOMPLETE
fi-skl-iommu: PASS -> INCOMPLETE
fi-ivb-3770: PASS -> INCOMPLETE
fi-whl-u: PASS -> INCOMPLETE
fi-skl-6700hq: PASS -> INCOMPLETE
fi-kbl-7500u: PASS -> INCOMPLETE
fi-ivb-3520m: PASS -> INCOMPLETE
fi-hsw-4770: PASS -> INCOMPLETE
fi-bdw-5557u: PASS -> INCOMPLETE
fi-cfl-8700k: PASS -> INCOMPLETE
fi-hsw-peppy: PASS -> INCOMPLETE
fi-kbl-x1275: PASS -> INCOMPLETE
fi-pnv-d510: PASS -> INCOMPLETE
fi-blb-e6850: PASS -> INCOMPLETE
fi-skl-6700k2: PASS -> INCOMPLETE
== Known issues ==
Here are the changes found in Patchwork_10221 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_module_reload@basic-reload-inject:
fi-byt-j1900: PASS -> INCOMPLETE (fdo#102657)
fi-kbl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-byt-n2820: PASS -> INCOMPLETE (fdo#102657)
fi-bxt-j4205: PASS -> INCOMPLETE (fdo#103927)
fi-byt-clapper: PASS -> INCOMPLETE (fdo#102657)
fi-snb-2520m: PASS -> INCOMPLETE (fdo#103713)
fi-bdw-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-glk-j4005: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
fi-bxt-dsi: PASS -> INCOMPLETE (fdo#103927)
fi-skl-gvtdvm: PASS -> INCOMPLETE (fdo#105600)
fi-glk-dsi: PASS -> INCOMPLETE (fdo#103359, k.org#198133)
fi-skl-6600u: PASS -> INCOMPLETE (fdo#104108)
fi-skl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-cfl-guc: PASS -> INCOMPLETE (fdo#106693)
fi-elk-e7500: PASS -> INCOMPLETE (fdo#103989)
igt@gem_exec_suspend@basic-s3:
fi-icl-u: NOTRUN -> INCOMPLETE (fdo#107901)
igt@gem_exec_suspend@basic-s4-devices:
fi-bdw-samus: NOTRUN -> INCOMPLETE (fdo#107773)
igt@kms_frontbuffer_tracking@basic:
fi-hsw-peppy: PASS -> DMESG-WARN (fdo#102614)
igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
fi-byt-clapper: PASS -> FAIL (fdo#107362, fdo#103191)
igt@kms_psr@primary_page_flip:
fi-kbl-7560u: PASS -> FAIL (fdo#107336)
fi-kbl-r: PASS -> FAIL (fdo#107336)
==== Possible fixes ====
igt@gem_exec_suspend@basic-s3:
fi-bdw-samus: INCOMPLETE (fdo#107773) -> PASS
fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
fdo#102657 https://bugs.freedesktop.org/show_bug.cgi?id=102657
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
fdo#103989 https://bugs.freedesktop.org/show_bug.cgi?id=103989
fdo#104108 https://bugs.freedesktop.org/show_bug.cgi?id=104108
fdo#105600 https://bugs.freedesktop.org/show_bug.cgi?id=105600
fdo#106693 https://bugs.freedesktop.org/show_bug.cgi?id=106693
fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
fdo#107901 https://bugs.freedesktop.org/show_bug.cgi?id=107901
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (52 -> 48) ==
Additional (1): fi-icl-u
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4841 -> Patchwork_10221
CI_DRM_4841: 4a03aefd83495146beca5f593558343aca40eb51 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4646: d409cc6f234fbc0122c64be27ba85b5603658de5 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10221: a3f7db648c33310dda049ba1ac885341779c6e37 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
a3f7db648c33 drm/i915: set i915 driver probe to asynchronous
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10221/issues.html
[-- Attachment #1.2: Type: text/html, Size: 7548 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fi.CI.BAT: failure for drm/i915: set i915 driver probe to asynchronous
2018-09-20 1:34 ` Zhang, Ning A
@ 2018-09-20 7:44 ` Chris Wilson
2018-09-20 8:04 ` Zhang, Ning A
0 siblings, 1 reply; 6+ messages in thread
From: Chris Wilson @ 2018-09-20 7:44 UTC (permalink / raw)
To: Vivi, Rodrigo, Zhang, Ning A, intel-gfx, jani.nikula, joonas.lahtinen
Quoting Zhang, Ning A (2018-09-20 02:34:42)
> I don't understand why CI failure, could you help me to resolve it?
https://patchwork.freedesktop.org/patch/251045/
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Fi.CI.BAT: failure for drm/i915: set i915 driver probe to asynchronous
2018-09-20 7:44 ` Chris Wilson
@ 2018-09-20 8:04 ` Zhang, Ning A
0 siblings, 0 replies; 6+ messages in thread
From: Zhang, Ning A @ 2018-09-20 8:04 UTC (permalink / raw)
To: joonas.lahtinen, intel-gfx, Vivi, Rodrigo, jani.nikula, chris
[-- Attachment #1.1: Type: text/plain, Size: 326 bytes --]
thank you, by your patch I understand why CI fail for my patch.
BR.
Ning.
在 2018-09-20四的 08:44 +0100，Chris Wilson写道：
Quoting Zhang, Ning A (2018-09-20 02:34:42)
I don't understand why CI failure, could you help me to resolve it?
https://patchwork.freedesktop.org/patch/251045/
-Chris
[-- Attachment #1.2: Type: text/html, Size: 690 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm/i915: set i915 driver probe to asynchronous
2018-09-19 7:37 [PATCH] drm/i915: set i915 driver probe to asynchronous ning.a.zhang
2018-09-19 9:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2018-09-21 9:30 ` Daniel Vetter
1 sibling, 0 replies; 6+ messages in thread
From: Daniel Vetter @ 2018-09-21 9:30 UTC (permalink / raw)
To: ning.a.zhang
Cc: jani.nikula, joonas.lahtinen, rodrigo.vivi, airlied, intel-gfx,
linux-kernel, dri-devel
On Wed, Sep 19, 2018 at 03:37:12PM +0800, ning.a.zhang@intel.com wrote:
> From: Zhang Ning <ning.a.zhang@intel.com>
>
> when i915 is built in module, and system has built-in display, eg. eDP,
> i915 will detect and active it during driver probe. it will take long
> time.
>
> set i915 driver probe to asynchrous can save kernel initial time.
>
> Signed-off-by: Zhang Ning <ning.a.zhang@intel.com>
Last time around this was proposed there was a very long discussion around
how this breaks the sound driver. Was this resolved? Definitely needs to
add this context to the commit message, and all people involved back then
added to the Cc: list. Searching for PROBE_PREFER_ASYNCHRONOUS in the
archives should dig it all up.
Thanks, Daniel
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 6a4d1388ad2d..0f57d71d0abb 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -738,6 +738,7 @@ static struct pci_driver i915_pci_driver = {
> .probe = i915_pci_probe,
> .remove = i915_pci_remove,
> .driver.pm = &i915_pm_ops,
> + .driver.probe_type = PROBE_PREFER_ASYNCHRONOUS,
> };
>
> static int __init i915_init(void)
> --
> 2.18.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-09-21 9:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-19 7:37 [PATCH] drm/i915: set i915 driver probe to asynchronous ning.a.zhang
2018-09-19 9:12 ` ✗ Fi.CI.BAT: failure for " Patchwork
2018-09-20 1:34 ` Zhang, Ning A
2018-09-20 7:44 ` Chris Wilson
2018-09-20 8:04 ` Zhang, Ning A
2018-09-21 9:30 ` [PATCH] " Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.