All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] arm64: Remove unused VGA console support
@ 2018-09-13 11:56 Andrew Murray
  2018-09-14 13:00 ` Will Deacon
  2018-09-21 11:12 ` Catalin Marinas
  0 siblings, 2 replies; 3+ messages in thread
From: Andrew Murray @ 2018-09-13 11:56 UTC (permalink / raw)
  To: linux-arm-kernel

Support for VGA_CONSOLE is not allowable due to commit ee23794b8668
("video: vgacon: Don't build on arm64"), thus remove the associated
unused code.

Whilst PCI on arm64 would support VGA a valid screen_info structure
is missing.

Signed-off-by: Andrew Murray <andrew.murray@arm.com>
---
 arch/arm64/kernel/setup.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/arm64/kernel/setup.c b/arch/arm64/kernel/setup.c
index 5b4fac4..95670a1 100644
--- a/arch/arm64/kernel/setup.c
+++ b/arch/arm64/kernel/setup.c
@@ -351,12 +351,8 @@ void __init setup_arch(char **cmdline_p)
 #endif
 
 #ifdef CONFIG_VT
-#if defined(CONFIG_VGA_CONSOLE)
-	conswitchp = &vga_con;
-#elif defined(CONFIG_DUMMY_CONSOLE)
 	conswitchp = &dummy_con;
 #endif
-#endif
 	if (boot_args[1] || boot_args[2] || boot_args[3]) {
 		pr_err("WARNING: x1-x3 nonzero in violation of boot protocol:\n"
 			"\tx1: %016llx\n\tx2: %016llx\n\tx3: %016llx\n"
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] arm64: Remove unused VGA console support
  2018-09-13 11:56 [PATCH] arm64: Remove unused VGA console support Andrew Murray
@ 2018-09-14 13:00 ` Will Deacon
  2018-09-21 11:12 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Will Deacon @ 2018-09-14 13:00 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 13, 2018 at 12:56:40PM +0100, Andrew Murray wrote:
> Support for VGA_CONSOLE is not allowable due to commit ee23794b8668
> ("video: vgacon: Don't build on arm64"), thus remove the associated
> unused code.
> 
> Whilst PCI on arm64 would support VGA a valid screen_info structure
> is missing.
> 
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>
> ---
>  arch/arm64/kernel/setup.c | 4 ----
>  1 file changed, 4 deletions(-)

Acked-by: Will Deacon <will.deacon@arm.com>

Will

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] arm64: Remove unused VGA console support
  2018-09-13 11:56 [PATCH] arm64: Remove unused VGA console support Andrew Murray
  2018-09-14 13:00 ` Will Deacon
@ 2018-09-21 11:12 ` Catalin Marinas
  1 sibling, 0 replies; 3+ messages in thread
From: Catalin Marinas @ 2018-09-21 11:12 UTC (permalink / raw)
  To: linux-arm-kernel

On Thu, Sep 13, 2018 at 12:56:40PM +0100, Andrew Murray wrote:
> Support for VGA_CONSOLE is not allowable due to commit ee23794b8668
> ("video: vgacon: Don't build on arm64"), thus remove the associated
> unused code.
> 
> Whilst PCI on arm64 would support VGA a valid screen_info structure
> is missing.
> 
> Signed-off-by: Andrew Murray <andrew.murray@arm.com>

Queued for 4.20. Thanks.

-- 
Catalin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-09-21 11:12 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-13 11:56 [PATCH] arm64: Remove unused VGA console support Andrew Murray
2018-09-14 13:00 ` Will Deacon
2018-09-21 11:12 ` Catalin Marinas

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.