All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability
@ 2018-09-21 13:38 Juha-Pekka Heikkila
  2018-09-21 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (6 more replies)
  0 siblings, 7 replies; 9+ messages in thread
From: Juha-Pekka Heikkila @ 2018-09-21 13:38 UTC (permalink / raw)
  To: igt-dev

Max sprite plane width at 2000 to avoid going over hw watermark
limits.

bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105458
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_ccs.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index e1ee588..f630029 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -68,6 +68,8 @@ typedef struct {
 #define CCS_UNCOMPRESSED	0x0
 #define CCS_COMPRESSED		0x55
 
+#define MAX_SPRITE_PLANE_WIDTH 2000
+
 struct local_drm_format_modifier {
        /* Bitmask of formats in get_plane format list this info applies to. The
 	* offset allows a sliding window of which 64 formats (bits).
@@ -408,12 +410,12 @@ static bool try_config(data_t *data, enum test_fb_flags fb_flags,
 	if (data->plane && fb_flags & FB_COMPRESSED) {
 		if (!plane_has_format_with_ccs(data, data->plane, DRM_FORMAT_XRGB8888))
 			return false;
-		generate_fb(data, &fb, drm_mode->hdisplay,
+		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
 			    drm_mode->vdisplay,
 			    (fb_flags & ~FB_COMPRESSED) | FB_HAS_PLANE);
 		generate_fb(data, &fb_sprite, 256, 256, fb_flags);
 	} else {
-		generate_fb(data, &fb, drm_mode->hdisplay,
+		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
 			    drm_mode->vdisplay, fb_flags);
 	}
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_ccs: Avoid using plane sizes which exceed hw capability
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
@ 2018-09-21 14:14 ` Patchwork
  2018-09-21 14:35 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
                   ` (5 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-21 14:14 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

== Series Details ==

Series: tests/kms_ccs: Avoid using plane sizes which exceed hw capability
URL   : https://patchwork.freedesktop.org/series/50011/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4859 -> IGTPW_1864 =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1864 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1864, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50011/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1864:

  === IGT changes ===

    ==== Warnings ====

    igt@pm_rpm@module-reload:
      fi-hsw-4770r:       PASS -> SKIP

    
== Known issues ==

  Here are the changes found in IGTPW_1864 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload-inject:
      fi-hsw-4770r:       PASS -> DMESG-WARN (fdo#107425, fdo#107924)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-glk-j4005:       INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-cfl-8109u:       FAIL (fdo#103375) -> PASS

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107425 https://bugs.freedesktop.org/show_bug.cgi?id=107425
  fdo#107924 https://bugs.freedesktop.org/show_bug.cgi?id=107924
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (51 -> 47) ==

  Additional (2): fi-cnl-u fi-skl-caroline 
  Missing    (6): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-cfl-guc fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1864

  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1864: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1864/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1864/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
  2018-09-21 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-21 14:35 ` Ville Syrjälä
  2018-09-21 15:41 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
                   ` (4 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Ville Syrjälä @ 2018-09-21 14:35 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

On Fri, Sep 21, 2018 at 04:38:01PM +0300, Juha-Pekka Heikkila wrote:
> Max sprite plane width at 2000 to avoid going over hw watermark
> limits.
> 
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105458
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_ccs.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index e1ee588..f630029 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -68,6 +68,8 @@ typedef struct {
>  #define CCS_UNCOMPRESSED	0x0
>  #define CCS_COMPRESSED		0x55
>  
> +#define MAX_SPRITE_PLANE_WIDTH 2000

Please include a comment explaining why we limit the plane width
like this. Avoids the next guy having to trawl git logs for the
information.

> +
>  struct local_drm_format_modifier {
>         /* Bitmask of formats in get_plane format list this info applies to. The
>  	* offset allows a sliding window of which 64 formats (bits).
> @@ -408,12 +410,12 @@ static bool try_config(data_t *data, enum test_fb_flags fb_flags,
>  	if (data->plane && fb_flags & FB_COMPRESSED) {
>  		if (!plane_has_format_with_ccs(data, data->plane, DRM_FORMAT_XRGB8888))
>  			return false;
> -		generate_fb(data, &fb, drm_mode->hdisplay,
> +		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
>  			    drm_mode->vdisplay,
>  			    (fb_flags & ~FB_COMPRESSED) | FB_HAS_PLANE);
>  		generate_fb(data, &fb_sprite, 256, 256, fb_flags);
>  	} else {
> -		generate_fb(data, &fb, drm_mode->hdisplay,
> +		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
>  			    drm_mode->vdisplay, fb_flags);
>  	}
>  
> -- 
> 2.7.4
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_ccs: Avoid using plane sizes which exceed hw capability
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
  2018-09-21 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-09-21 14:35 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
@ 2018-09-21 15:41 ` Patchwork
  2018-09-24  8:29 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
                   ` (3 subsequent siblings)
  6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-21 15:41 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

== Series Details ==

Series: tests/kms_ccs: Avoid using plane sizes which exceed hw capability
URL   : https://patchwork.freedesktop.org/series/50011/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4648_full -> IGTPW_1864_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50011/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1864_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_userptr_blits@readonly-unsync:
      shard-apl:          PASS -> INCOMPLETE (fdo#103927)

    igt@kms_busy@extended-modeset-hang-newfb-render-c:
      shard-glk:          NOTRUN -> DMESG-WARN (fdo#107956) +2

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_fbcon_fbt@fbc-suspend:
      shard-snb:          NOTRUN -> INCOMPLETE (fdo#105411)

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-pri-shrfb-draw-blt:
      shard-glk:          PASS -> FAIL (fdo#103167)

    igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
      shard-snb:          PASS -> FAIL (fdo#103166)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          NOTRUN -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)
      shard-kbl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_vblank@pipe-b-query-busy-hang:
      shard-apl:          DMESG-WARN (fdo#106107) -> PASS

    igt@perf_pmu@init-wait-vcs0:
      shard-snb:          INCOMPLETE (fdo#105411, fdo#107816) -> PASS

    
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106107 https://bugs.freedesktop.org/show_bug.cgi?id=106107
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#107816 https://bugs.freedesktop.org/show_bug.cgi?id=107816
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1864
    * Linux: CI_DRM_4854 -> CI_DRM_4859

  CI_DRM_4854: 78a6bcff149f370d58fe0bf51c29cbe62d8bc27c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1864: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1864/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1864/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
                   ` (2 preceding siblings ...)
  2018-09-21 15:41 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
@ 2018-09-24  8:29 ` Juha-Pekka Heikkila
  2018-10-12 15:23   ` Maarten Lankhorst
  2018-09-24  9:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2) Patchwork
                   ` (2 subsequent siblings)
  6 siblings, 1 reply; 9+ messages in thread
From: Juha-Pekka Heikkila @ 2018-09-24  8:29 UTC (permalink / raw)
  To: igt-dev

Max sprite plane width at 2000 to avoid going over hw watermark
limits.

v2: (Ville Syrjälä) comment on source added plane width limitation.

bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105458
Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
---
 tests/kms_ccs.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
index e1ee588..64a4fdd 100644
--- a/tests/kms_ccs.c
+++ b/tests/kms_ccs.c
@@ -68,6 +68,15 @@ typedef struct {
 #define CCS_UNCOMPRESSED	0x0
 #define CCS_COMPRESSED		0x55
 
+/*
+ * Limit maximum used sprite plane width so this test will not mistakenly
+ * fail on hardware limitations which are not interesting to this test.
+ * On this test too wide sprite plane may fail during creation with dmesg
+ * comment saying:
+ * "Requested display configuration exceeds system watermark limitations"
+ */
+#define MAX_SPRITE_PLANE_WIDTH 2000
+
 struct local_drm_format_modifier {
        /* Bitmask of formats in get_plane format list this info applies to. The
 	* offset allows a sliding window of which 64 formats (bits).
@@ -408,12 +417,12 @@ static bool try_config(data_t *data, enum test_fb_flags fb_flags,
 	if (data->plane && fb_flags & FB_COMPRESSED) {
 		if (!plane_has_format_with_ccs(data, data->plane, DRM_FORMAT_XRGB8888))
 			return false;
-		generate_fb(data, &fb, drm_mode->hdisplay,
+		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
 			    drm_mode->vdisplay,
 			    (fb_flags & ~FB_COMPRESSED) | FB_HAS_PLANE);
 		generate_fb(data, &fb_sprite, 256, 256, fb_flags);
 	} else {
-		generate_fb(data, &fb, drm_mode->hdisplay,
+		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
 			    drm_mode->vdisplay, fb_flags);
 	}
 
-- 
2.7.4

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
                   ` (3 preceding siblings ...)
  2018-09-24  8:29 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
@ 2018-09-24  9:12 ` Patchwork
  2018-09-24 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
  2018-09-24 11:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-24  9:12 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

== Series Details ==

Series: tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
URL   : https://patchwork.freedesktop.org/series/50011/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4859 -> IGTPW_1867 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1867 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1867, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50011/revisions/2/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1867:

  === IGT changes ===

    ==== Possible regressions ====

    igt@drv_selftest@live_hangcheck:
      fi-kbl-7560u:       PASS -> INCOMPLETE

    igt@pm_rpm@basic-pci-d3-state:
      fi-cnl-u:           NOTRUN -> FAIL

    
== Known issues ==

  Here are the changes found in IGTPW_1867 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@gem_exec_suspend@basic-s4-devices:
      fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-cfl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-glk-j4005:       INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-cfl-8109u:       FAIL (fdo#103375) -> PASS

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (51 -> 41) ==

  Additional (2): fi-cnl-u fi-skl-caroline 
  Missing    (12): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-ilk-650 fi-snb-2520m fi-ctg-p8600 fi-kbl-7500u fi-ivb-3520m fi-icl-u 


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1867

  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1867: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1867/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1867/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
                   ` (4 preceding siblings ...)
  2018-09-24  9:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2) Patchwork
@ 2018-09-24 10:12 ` Patchwork
  2018-09-24 11:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-24 10:12 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

== Series Details ==

Series: tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
URL   : https://patchwork.freedesktop.org/series/50011/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4859 -> IGTPW_1868 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50011/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1868 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-cfl-8109u:       PASS -> INCOMPLETE (fdo#106070)

    igt@kms_psr@primary_page_flip:
      fi-cnl-u:           NOTRUN -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-cfl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-glk-j4005:       INCOMPLETE (k.org#198133, fdo#103359) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (51 -> 42) ==

  Additional (2): fi-cnl-u fi-skl-caroline 
  Missing    (11): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-ilk-650 fi-kbl-7500u fi-ctg-p8600 fi-ivb-3520m fi-icl-u 


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1868

  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1868: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1868/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1868/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
  2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
                   ` (5 preceding siblings ...)
  2018-09-24 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
@ 2018-09-24 11:01 ` Patchwork
  6 siblings, 0 replies; 9+ messages in thread
From: Patchwork @ 2018-09-24 11:01 UTC (permalink / raw)
  To: Juha-Pekka Heikkila; +Cc: igt-dev

== Series Details ==

Series: tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2)
URL   : https://patchwork.freedesktop.org/series/50011/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4648_full -> IGTPW_1868_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50011/revisions/2/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1868_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_schedule@pi-ringfull-blt:
      shard-glk:          NOTRUN -> FAIL (fdo#103158) +1

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-glk:          NOTRUN -> FAIL (fdo#106641)

    igt@kms_busy@extended-modeset-hang-newfb-render-c:
      shard-glk:          NOTRUN -> DMESG-WARN (fdo#107956) +4

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
      shard-glk:          NOTRUN -> FAIL (fdo#105363)

    igt@kms_frontbuffer_tracking@fbc-shrfb-scaledprimary:
      shard-glk:          PASS -> FAIL (fdo#103167) +1

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          NOTRUN -> FAIL (fdo#103925)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#103166, fdo#107749) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_vblank@pipe-b-query-busy-hang:
      shard-apl:          DMESG-WARN (fdo#106107) -> PASS

    igt@perf_pmu@init-wait-vcs0:
      shard-snb:          INCOMPLETE (fdo#105411, fdo#107816) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106107 https://bugs.freedesktop.org/show_bug.cgi?id=106107
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#107816 https://bugs.freedesktop.org/show_bug.cgi?id=107816
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1868
    * Linux: CI_DRM_4854 -> CI_DRM_4859

  CI_DRM_4854: 78a6bcff149f370d58fe0bf51c29cbe62d8bc27c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1868: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1868/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1868/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability
  2018-09-24  8:29 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
@ 2018-10-12 15:23   ` Maarten Lankhorst
  0 siblings, 0 replies; 9+ messages in thread
From: Maarten Lankhorst @ 2018-10-12 15:23 UTC (permalink / raw)
  To: Juha-Pekka Heikkila, igt-dev

Op 24-09-18 om 10:29 schreef Juha-Pekka Heikkila:
> Max sprite plane width at 2000 to avoid going over hw watermark
> limits.
>
> v2: (Ville Syrjälä) comment on source added plane width limitation.
>
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105458
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  tests/kms_ccs.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c
> index e1ee588..64a4fdd 100644
> --- a/tests/kms_ccs.c
> +++ b/tests/kms_ccs.c
> @@ -68,6 +68,15 @@ typedef struct {
>  #define CCS_UNCOMPRESSED	0x0
>  #define CCS_COMPRESSED		0x55
>  
> +/*
> + * Limit maximum used sprite plane width so this test will not mistakenly
> + * fail on hardware limitations which are not interesting to this test.
> + * On this test too wide sprite plane may fail during creation with dmesg
> + * comment saying:
> + * "Requested display configuration exceeds system watermark limitations"
> + */
> +#define MAX_SPRITE_PLANE_WIDTH 2000
> +
>  struct local_drm_format_modifier {
>         /* Bitmask of formats in get_plane format list this info applies to. The
>  	* offset allows a sliding window of which 64 formats (bits).
> @@ -408,12 +417,12 @@ static bool try_config(data_t *data, enum test_fb_flags fb_flags,
>  	if (data->plane && fb_flags & FB_COMPRESSED) {
>  		if (!plane_has_format_with_ccs(data, data->plane, DRM_FORMAT_XRGB8888))
>  			return false;
> -		generate_fb(data, &fb, drm_mode->hdisplay,
> +		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
>  			    drm_mode->vdisplay,
>  			    (fb_flags & ~FB_COMPRESSED) | FB_HAS_PLANE);
>  		generate_fb(data, &fb_sprite, 256, 256, fb_flags);
>  	} else {
> -		generate_fb(data, &fb, drm_mode->hdisplay,
> +		generate_fb(data, &fb, min(MAX_SPRITE_PLANE_WIDTH, drm_mode->hdisplay),
>  			    drm_mode->vdisplay, fb_flags);
>  	}
>  

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2018-10-12 15:23 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-21 13:38 [igt-dev] [PATCH i-g-t] tests/kms_ccs: Avoid using plane sizes which exceed hw capability Juha-Pekka Heikkila
2018-09-21 14:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-21 14:35 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
2018-09-21 15:41 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
2018-09-24  8:29 ` [igt-dev] [PATCH i-g-t] " Juha-Pekka Heikkila
2018-10-12 15:23   ` Maarten Lankhorst
2018-09-24  9:12 ` [igt-dev] ✗ Fi.CI.BAT: failure for tests/kms_ccs: Avoid using plane sizes which exceed hw capability (rev2) Patchwork
2018-09-24 10:12 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2018-09-24 11:01 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.