All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format.
@ 2018-09-24  6:44 Maarten Lankhorst
  2018-09-24  7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Maarten Lankhorst @ 2018-09-24  6:44 UTC (permalink / raw)
  To: igt-dev

Creating a YUV FB in a high resolution takes too long, and we end up with:
[drm:drm_crtc_add_crc_entry] *ERROR* Overflow of CRC buffer, userspace reads too slow.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106885
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
---
 tests/kms_plane.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tests/kms_plane.c b/tests/kms_plane.c
index aa36ddeba31a..d00baeaff72d 100644
--- a/tests/kms_plane.c
+++ b/tests/kms_plane.c
@@ -419,7 +419,7 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
 	igt_plane_set_fb(plane, fb);
 
 	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
-	igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
+	igt_pipe_crc_collect_crc(data->pipe_crc, crc);
 
 	igt_remove_fb(data->drm_fd, &old_fb);
 }
@@ -466,7 +466,6 @@ static void test_format_plane(data_t *data, enum pipe pipe,
 	set_legacy_lut(data, pipe, 0xfc00);
 
 	test_init(data, pipe);
-	igt_pipe_crc_start(data->pipe_crc);
 
 	igt_info("Testing format " IGT_FORMAT_FMT " on %s.%u\n",
 		 IGT_FORMAT_ARGS(format),
-- 
2.19.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for kms_plane: Do not leave CRC generation running while creating a format.
  2018-09-24  6:44 [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format Maarten Lankhorst
@ 2018-09-24  7:10 ` Patchwork
  2018-09-24  7:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  2018-09-24 12:41 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-24  7:10 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: igt-dev

== Series Details ==

Series: kms_plane: Do not leave CRC generation running while creating a format.
URL   : https://patchwork.freedesktop.org/series/50084/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4859 -> IGTPW_1866 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50084/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1866 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3:
      fi-bdw-samus:       PASS -> INCOMPLETE (fdo#107773)

    igt@kms_frontbuffer_tracking@basic:
      fi-byt-clapper:     PASS -> FAIL (fdo#103167)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#103191, fdo#107362) +1

    
    ==== Possible fixes ====

    igt@drv_selftest@live_guc:
      fi-skl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-cfl-guc:         DMESG-WARN (fdo#107258) -> PASS
      fi-kbl-guc:         DMESG-WARN (fdo#107258) -> PASS

    igt@drv_selftest@live_hangcheck:
      fi-glk-j4005:       INCOMPLETE (fdo#103359, k.org#198133) -> PASS

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     FAIL (fdo#107362) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-cfl-8109u:       FAIL (fdo#103375) -> PASS

    
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
  fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
  fdo#107258 https://bugs.freedesktop.org/show_bug.cgi?id=107258
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107773 https://bugs.freedesktop.org/show_bug.cgi?id=107773
  k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133


== Participating hosts (51 -> 42) ==

  Additional (2): fi-cnl-u fi-skl-caroline 
  Missing    (11): fi-ilk-m540 fi-bdw-5557u fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-skl-6260u fi-ilk-650 fi-kbl-7500u fi-ctg-p8600 fi-ivb-3520m fi-icl-u 


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1866

  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1866/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1866/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for kms_plane: Do not leave CRC generation running while creating a format.
  2018-09-24  6:44 [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format Maarten Lankhorst
  2018-09-24  7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-09-24  7:57 ` Patchwork
  2018-09-24 12:41 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-09-24  7:57 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: igt-dev

== Series Details ==

Series: kms_plane: Do not leave CRC generation running while creating a format.
URL   : https://patchwork.freedesktop.org/series/50084/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4648_full -> IGTPW_1866_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/50084/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1866_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#106886)

    igt@gem_exec_schedule@pi-ringfull-vebox:
      shard-glk:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-glk:          NOTRUN -> FAIL (fdo#106641)

    igt@kms_busy@extended-modeset-hang-newfb-render-c:
      shard-glk:          NOTRUN -> DMESG-WARN (fdo#107956) +1

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
      shard-snb:          NOTRUN -> DMESG-WARN (fdo#107956)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-apl:          PASS -> FAIL (fdo#102887, fdo#105363)

    igt@kms_setmode@basic:
      shard-glk:          NOTRUN -> FAIL (fdo#99912)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
      shard-glk:          DMESG-WARN (fdo#105763, fdo#106538) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749, fdo#103166) -> PASS

    igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
      shard-apl:          INCOMPLETE (fdo#103927) -> PASS

    igt@kms_vblank@pipe-b-query-busy-hang:
      shard-apl:          DMESG-WARN (fdo#106107) -> PASS

    igt@perf_pmu@init-wait-vcs0:
      shard-snb:          INCOMPLETE (fdo#107816, fdo#105411) -> PASS

    
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
  fdo#106107 https://bugs.freedesktop.org/show_bug.cgi?id=106107
  fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#107816 https://bugs.freedesktop.org/show_bug.cgi?id=107816
  fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4648 -> IGTPW_1866
    * Linux: CI_DRM_4854 -> CI_DRM_4859

  CI_DRM_4854: 78a6bcff149f370d58fe0bf51c29cbe62d8bc27c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4859: 841654aee134e50b21bf8f2aab17da8d0afd14c4 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1866: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1866/
  IGT_4648: f2919ea120660ca15622a27527e1842d0dd3f1b7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1866/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format.
  2018-09-24  6:44 [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format Maarten Lankhorst
  2018-09-24  7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
  2018-09-24  7:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
@ 2018-09-24 12:41 ` Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2018-09-24 12:41 UTC (permalink / raw)
  To: Maarten Lankhorst; +Cc: igt-dev

On Mon, Sep 24, 2018 at 08:44:49AM +0200, Maarten Lankhorst wrote:
> Creating a YUV FB in a high resolution takes too long, and we end up with:
> [drm:drm_crtc_add_crc_entry] *ERROR* Overflow of CRC buffer, userspace reads too slow.
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106885
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  tests/kms_plane.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index aa36ddeba31a..d00baeaff72d 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -419,7 +419,7 @@ static void test_format_plane_color(data_t *data, enum pipe pipe,
>  	igt_plane_set_fb(plane, fb);
>  
>  	igt_display_commit2(&data->display, data->display.is_atomic ? COMMIT_ATOMIC : COMMIT_UNIVERSAL);
> -	igt_pipe_crc_get_current(data->display.drm_fd, data->pipe_crc, crc);
> +	igt_pipe_crc_collect_crc(data->pipe_crc, crc);

That's going to slow the test down even more :(

>  
>  	igt_remove_fb(data->drm_fd, &old_fb);
>  }
> @@ -466,7 +466,6 @@ static void test_format_plane(data_t *data, enum pipe pipe,
>  	set_legacy_lut(data, pipe, 0xfc00);
>  
>  	test_init(data, pipe);
> -	igt_pipe_crc_start(data->pipe_crc);

_stop() needs removing too.

>  
>  	igt_info("Testing format " IGT_FORMAT_FMT " on %s.%u\n",
>  		 IGT_FORMAT_ARGS(format),
> -- 
> 2.19.0
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev

-- 
Ville Syrjälä
Intel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-09-24 12:41 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-24  6:44 [igt-dev] [PATCH i-g-t] kms_plane: Do not leave CRC generation running while creating a format Maarten Lankhorst
2018-09-24  7:10 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-09-24  7:57 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-09-24 12:41 ` [igt-dev] [PATCH i-g-t] " Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.