[PATCH] atmodem/sim: change vendor CINTERION in GEMALTO

[PATCH] atmodem/sim: change vendor CINTERION in GEMALTO

[Giacinto Cifelli]

[-- Attachment #1: Type: text/plain, Size: 1571 bytes --]

---
 drivers/atmodem/sim.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/atmodem/sim.c b/drivers/atmodem/sim.c
index 0907635d..2ce72c83 100644
--- a/drivers/atmodem/sim.c
+++ b/drivers/atmodem/sim.c
@@ -66,7 +66,7 @@ static const char *oercn_prefix[] = { "_OERCN:", NULL };
 static const char *cpinr_prefixes[] = { "+CPINR:", "+CPINRE:", NULL };
 static const char *epin_prefix[] = { "*EPIN:", NULL };
 static const char *simcom_spic_prefix[] = { "+SPIC:", NULL };
-static const char *cinterion_spic_prefix[] = { "^SPIC:", NULL };
+static const char *gemalto_spic_prefix[] = { "^SPIC:", NULL };
 static const char *pct_prefix[] = { "#PCT:", NULL };
 static const char *pnnm_prefix[] = { "+PNNM:", NULL };
 static const char *qpinc_prefix[] = { "+QPINC:", NULL };
@@ -1110,7 +1110,7 @@ error:
 	CALLBACK_WITH_FAILURE(cb, NULL, cbd->data);
 }
 
-static void cinterion_spic_cb(gboolean ok, GAtResult *result,
+static void gemalto_spic_cb(gboolean ok, GAtResult *result,
 							gpointer user_data)
 {
 	struct cb_data *cbd = user_data;
@@ -1227,9 +1227,9 @@ static void at_pin_retries_query(struct ofono_sim *sim,
 					upincnt_cb, cbd, g_free) > 0)
 			return;
 		break;
-	case OFONO_VENDOR_CINTERION:
-		if (g_at_chat_send(sd->chat, "AT^SPIC", cinterion_spic_prefix,
-					cinterion_spic_cb, cbd, g_free) > 0)
+	case OFONO_VENDOR_GEMALTO:
+		if (g_at_chat_send(sd->chat, "AT^SPIC", gemalto_spic_prefix,
+					gemalto_spic_cb, cbd, g_free) > 0)
 			return;
 		break;
 	default:
-- 
2.17.1

[PATCH] gemalto plugin: sim vendor to GEMALTO

[Giacinto Cifelli]

[-- Attachment #1: Type: text/plain, Size: 771 bytes --]

switched from CINTERION.
Note that the cinterion plugin itself does not use the specific vendor
for the sms atom.
---
 plugins/gemalto.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/plugins/gemalto.c b/plugins/gemalto.c
index b7734124..6e0d765b 100644
--- a/plugins/gemalto.c
+++ b/plugins/gemalto.c
@@ -571,7 +571,7 @@ static void gemalto_pre_sim(struct ofono_modem *modem)
 
 	ofono_devinfo_create(modem, 0, "atmodem", data->app);
 	ofono_location_reporting_create(modem, 0, "gemaltomodem", data->app);
-	data->sim = ofono_sim_create(modem, OFONO_VENDOR_CINTERION, "atmodem",
+	data->sim = ofono_sim_create(modem, OFONO_VENDOR_GEMALTO, "atmodem",
 						data->app);
 
 	if (data->sim && data->have_sim == TRUE)
-- 
2.17.1

Re: [PATCH] atmodem/sim: change vendor CINTERION in GEMALTO

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 314 bytes --]

On 09/25/2018 02:12 AM, Giacinto Cifelli wrote:
> ---
>   drivers/atmodem/sim.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 

Both applied.  Can you make sure that your patches are also 
sequence-numbered.

e.g.
git format-patch -2
git send-email 000*

Regards,
-Denis

Re: [PATCH] atmodem/sim: change vendor CINTERION in GEMALTO

[Giacinto Cifelli]

[-- Attachment #1: Type: text/plain, Size: 520 bytes --]

hi Denis,

On Tue, 25 Sep 2018, 16:43 Denis Kenzior, <denkenz@gmail.com> wrote:

> On 09/25/2018 02:12 AM, Giacinto Cifelli wrote:
> > ---
> >   drivers/atmodem/sim.c | 10 +++++-----
> >   1 file changed, 5 insertions(+), 5 deletions(-)
> >
>
> Both applied.  Can you make sure that your patches are also
> sequence-numbered.
>
> e.g.
> git format-patch -2
> git send-email 000*
>

yes, I have forgotten in this particular instance, apologies.

>
> Regards,
> -Denis
>

regards,
Giacinto

>

[-- Attachment #2: attachment.html --]
[-- Type: text/html, Size: 1237 bytes --]